Skip to content

fix: harden anonymization and release 1.0.93 - #5

Merged
vriesd merged 4 commits into
mainfrom
fix/privacy-review-remediations
Sep 8, 2026
Merged

vriesd merged 4 commits into
mainfrom
fix/privacy-review-remediations

Conversation

@vriesd

@vriesd vriesd commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • close paste/XML/Smart/output-publication privacy findings
  • harden Local AI transport, jobs, downloads, and frontend workflow invalidation
  • update Browserslist and prepare v1.0.93 release metadata

Verification

  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace
  • frontend tests, TypeScript compatibility, build, E2E, a11y, audit
  • contracts, docs, tooling, release metadata, Rust smoke, cargo audit, dead-code, APT installer checks

Native desktop interaction remains unavailable in this environment.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T12:26:37.974076Z dfe7578 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dfe7578ae9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +28 to +29
temporary_output_file.sync_all()?;
ensure_temporary_path_matches_handle(&temporary_output_path, &temporary_output_file)?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clean up temporary output when durability checks fail

If sync_all() fails (for example because the device runs out of space) or the handle/path metadata check returns an error, these ? operators exit before the cleanup branches below run. The complete transformed dataset is then left behind in the destination directory as a hidden .tmp file; route these failures through the same removal path used for write and publication errors.

Useful? React with 👍 / 👎.

Comment on lines +229 to +237
// Text, CDATA, and general references are one logical scalar in XML. Buffer adjacent
// content so a value split as `Ada Lovelace` is transformed once, rather than
// leaving the reference untouched or assigning separate replacements to each piece.
Event::Text(event) => {
let raw = event
.xml_content(XmlVersion::Implicit1_0)
.map_err(xml_error)?;
let replacement = xml_text_replacement(&path, &raw, &mut transform_context);
let event = match replacement.as_deref() {
Some(anonymized) => Event::Text(BytesText::new(anonymized)),
None => Event::Text(event),
};
writer.write_event(event).map_err(xml_error)?;
if selected_xml_text_path(&path, selected_by_path) {
append_pending_xml_scalar(&mut pending_scalar, &path, raw.into_owned(), false);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prepare Smart replacements from the buffered XML scalar

When a selected XML value spans text, CDATA, or a character reference, this code now transforms the concatenated scalar (for example Ada Lovelace&), but collect_xml_fields() still supplies Ada and Lovelace as separate values and ignores the reference when preparing Smart replacements. Consequently the generated replacements cannot be found under the combined key, so every such Local AI field silently uses the rule-based fallback while its report still accounts for the unused Smart replacements; collection and transformation need to construct the same logical scalar.

Useful? React with 👍 / 👎.

Comment on lines +105 to +108
transform_json_value(&mut value, &mut Vec::new(), &mut context);

let row_count = infer_value_row_count(&value);
// The output is serialized by the caller, which knows whether this document is
// JSON or YAML; everything else about the run is settled here.
let start_time = Instant::now();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Start the document timer before transforming

For JSON and YAML pasted documents, the timer is now created only after transform_json_value() has completed, so the user-facing durationMs excludes the entire transformation and will normally report 0ms regardless of document size. Initialize it before traversal, as the previous implementation did, so the displayed processing duration remains meaningful.

Useful? React with 👍 / 👎.

@vriesd
vriesd merged commit 501471b into main Sep 8, 2026
5 checks passed
@vriesd
vriesd deleted the fix/privacy-review-remediations branch September 8, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants