2.2.0

.github/workflows/pytest.yml

@@ -5,40 +5,128 @@ on:
     branches: [master]
     paths:
       - 'src/**'
+      - 'tests/**'
+      - 'pyproject.toml'
+      - '.github/workflows/pytest.yml'
+  workflow_dispatch:
+
+# One run per branch: a new push cancels the one it supersedes, so a long live
+# job doesn't keep scraping ESPN for a commit nobody is waiting on anymore.
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
-  test:
+  # Deterministic tests against recorded ESPN pages — no network. A failure
+  # here means the code changed behavior. Runs on every supported Python.
+  offline:
     runs-on: ubuntu-latest
-    timeout-minutes: 30
+    timeout-minutes: 10
     strategy:
       matrix:
         python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
       fail-fast: true
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
+      - name: Cache pip dependencies
+        uses: actions/cache@v4
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ hashFiles('**/pyproject.toml') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-${{ matrix.python-version }}-
+
       - name: Install package in editable mode
         run: |
           pip install --upgrade pip
           pip install -e .
 
-      - name: Install testing and linting tools
-        run: pip install pytest flake8 mypy
+      - name: Install testing tools
+        run: pip install pytest pyarrow flake8
+
+      # Errors only (syntax errors + undefined names) — catches latent
+      # NameErrors in branches the tests may not reach
+      - name: Lint with flake8
+        run: flake8 src/ --max-line-length=120 --count --select=E9,F63,F7,F82 --show-source --statistics
+
+      - name: Run offline tests
+        run: pytest tests/ -m "not live"
+
+  # Same offline suite, but with every dependency installed at the minimum
+  # version pyproject.toml claims to support (uv resolves the floors directly
+  # from the metadata, so there's no separate pin list to keep in sync). A
+  # failure here means a declared floor is dishonest — raise it rather than
+  # working around it. Python 3.9 because the floors must hold on the oldest
+  # supported interpreter; pytest/pyarrow are installed separately at their
+  # latest versions since lowest-direct would otherwise pick ancient ones.
+  offline-min-versions:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up uv
+        uses: astral-sh/setup-uv@v5
+        with:
+          python-version: '3.9'
+
+      - name: Install package with lowest supported dependency versions
+        run: |
+          uv pip install --resolution lowest-direct -e .
+          uv pip install pytest pyarrow
+
+      - name: Run offline tests
+        run: uv run --no-project pytest tests/ -m "not live"
+
+  # Live invariant tests against real ESPN — verifies the scraper still works
+  # against today's site. Single Python version: cross-version parsing
+  # differences are already covered by the offline matrix, and one job keeps
+  # ESPN request volume (and flake odds) down.
+  #
+  # Runs the whole suite, bulk scrapes included (~2,700 games). Slow by
+  # design — the timeout is generous because a PR waits on this.
+  live:
+    runs-on: ubuntu-latest
+    timeout-minutes: 120
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
 
       - name: Cache pip dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ~/.cache/pip
-          key: ${{ runner.os }}-pip-${{ hashFiles('**/pyproject.toml') }}
+          key: ${{ runner.os }}-pip-3.12-${{ hashFiles('**/pyproject.toml') }}
           restore-keys: |
-            ${{ runner.os }}-pip-
+            ${{ runner.os }}-pip-3.12-
+
+      - name: Install package in editable mode
+        run: |
+          pip install --upgrade pip
+          pip install -e .
+
+      - name: Install testing tools
+        run: pip install pytest pyarrow
 
-      - name: Run pytest
-        run: pytest tests/
+      - name: Run live tests
+        # -v + unbuffered so a hang is visible in the log as it happens rather
+        # than as a timeout with no output
+        env:
+          PYTHONUNBUFFERED: '1'
+        run: pytest tests/ -m live -v --durations=10

.github/workflows/python-publish.yml

@@ -32,6 +32,20 @@ jobs:
         pip install build
     - name: Build package
       run: python -m build
+    # Nothing keeps __version__ and the release tag in sync, and a wrong
+    # filename on PyPI cannot be reused once uploaded — so check the built
+    # artifact against the tag before the one irreversible step.
+    - name: Verify tag matches built version
+      run: |
+        TAG="${{ github.event.release.tag_name }}"
+        DIST=$(ls dist/cbbpy-*.tar.gz)
+        BUILT="v$(basename "$DIST" .tar.gz | sed 's/^cbbpy-//')"
+        if [ "$TAG" != "$BUILT" ]; then
+          echo "release tag $TAG does not match built version $BUILT" >&2
+          echo "fix src/cbbpy/__init__.py or retag, then re-publish" >&2
+          exit 1
+        fi
+        echo "tag $TAG matches built version"
     - name: Publish package
       uses: pypa/gh-action-pypi-publish@27b31702a0e7fc50959f5ad993c78deac1bdfc29
       with:

.github/workflows/waf-probe.yml

@@ -0,0 +1,32 @@
+name: WAF probe
+
+# Manual diagnostic: reports which curl_cffi impersonation profiles ESPN's WAF
+# accepts from a GitHub runner. The answer differs from a workstation's — a
+# fingerprint accepted from a residential IP can be challenged from a
+# datacenter one — so run this before changing IMPERSONATE for CI's benefit.
+on:
+  workflow_dispatch:
+
+jobs:
+  probe:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
+
+      - name: Install package
+        run: |
+          pip install --upgrade pip
+          pip install -e .
+
+      - name: Probe impersonation profiles
+        env:
+          PYTHONUNBUFFERED: '1'
+        run: python tests/waf_probe.py

.gitignore

@@ -1,13 +1,18 @@
-CBBpy.egg-info/
+*.egg-info/
 *.ipynb
 *.pyc
 .ipynb_checkpoints/
 testing/
 __pycache__/
 .DS_Store
 *.gz
+!tests/fixtures/pages/*.html.gz
+!tests/fixtures/pages/*.json.gz
 *.whl
 build/
 dist/
 *.log
-*.xlsx
+*.xlsx
+.vscode/
+.claude/
+.pytest_cache/