Skip to content

pbp shooter column silently removed in 2.2.0 — deprecate or document #88

Closed

Description

@dcstats

Context

On the 2.2.0 branch, the play-by-play `shooter` column from 2.1.x was replaced by `player_name` (broader semantics: the primary actor on any attributed play, sourced from ESPN's structured JSON with a text-parse fallback). Unlike `game_day`/`game_time` and `half`/`quarter`, which got deprecation shims, a CHANGELOG entry, and coverage in `DEPRECATED_COLUMNS`, `shooter` just disappeared — existing consumer code selecting it breaks with a KeyError and there's no changelog trace.

Decide before release

Either:

  1. Deprecate: re-emit `shooter` (populated only on shooting plays, as before), add it to `DEPRECATED_COLUMNS` with `player_name` as its replacement and 3.0 removal, or
  2. Document the removal: add a "Removed" entry to CHANGELOG.md's 2.2.0 section.

Also

The README pbp example table still shows the old schema: a `shooter` column and old lowercase `play_type` values (`jumper`, `jump ball`) instead of the new JSON types (`JumpShot`, `Jump Ball`). Regenerate the example table either way.

Activity

  1. self-assigned this
    on Jul 22, 2026
  2. added this to the v2.2.0 milestone on Jul 22, 2026
  3. dcstats commented on Jul 23, 2026

    @dcstats
    OwnerAuthor

    fixed with 129a037

  4. linked a pull request that will close this issue2.2.0 #94on Jul 29, 2026
  5. removed a link to a pull request2.2.0 #94on Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

compatibilityIssue related to code updates in newer versions of dependenciespriority: mediumShould fix

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions