Repository navigation
Fix chained redirects and plain HTTP checks - #23
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 24 +1
Lines 486 502 +16
=========================================
+ Hits 486 502 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 7, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
fix/redirects-and-http-scheme
branch
from
November 7, 2026 12:58
fcce96e to
a983ee7
Compare
Contributor
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolve relative redirects against the current response URL, normalize the initial loop-detection URL, preserve original/final URLs in redirect errors, and bound chains with validated
max_redirects(default 20; zero disables redirects). Net::HTTP now selects TLS from the URL scheme. Correct the retry option documentation and describe its shared budget.Shared regression tests cover all three backends. Replay setup uses WebMock consistently and lets the Async adapter generate Content-Length, avoiding duplicate framing headers with current dependencies.
Validation
bundle exec rubocoppassed. Targeted checker/config/task specs: 130 examples, zero failures.git diff --checkpassed.Fixes #7.
Implemented by AI on behalf of @dblock.