Repository navigation
Improve test coverage to 100% - #21
Merged
Merged
Conversation
dblock
force-pushed
the
improve-test-coverage
branch
from
August 18, 2026 01:49
9c99d77 to
34ca1fd
Compare
Contributor
Danger ReportNo issues found. |
Add missing specs for base Result/ResultError, Task#run!, RedirectLoopError, Callbacks method_missing and rescue branch, Tasks#retries, and .config / Result#code rescue branches across all three checkers. Also cover Typhoeus::Hydra::Checker#run and add a SimpleCov filter to exclude spec/ files from coverage measurement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
improve-test-coverage
branch
from
August 18, 2026 01:50
34ca1fd to
fa0e72e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing specs to bring line coverage from 97.69% to 100%:
LinkChecker::Result/ResultErrordefault methodsLinkChecker::Task#run!raisingNotImplementedErrorRedirectLoopError#url/#messageCallbacks#method_missing(bang vs non-bang) and its rescue branchTasks#retries.configaccessor andResult#coderescue branch for Net::HTTP, Typhoeus::Hydra, and Async::HTTP checkersTyphoeus::Hydra::Checker#rundelegating to@hydra.runAlso adds a SimpleCov filter (
add_filter '/spec/') sospec/supporthelper files (VCR hooks, request-matcher lambdas) are no longer counted toward coverage, since they're test infrastructure, not library code.