Repository navigation
Support optional search/replacement in MarkdownSection.replace - #18
Merged
Merged
Conversation
dblock
force-pushed
the
dblock/markdown-replacement-overload
branch
from
November 11, 2026 18:40
8f1b6b3 to
32d6956
Compare
dblock
force-pushed
the
dblock/markdown-replacement-overload
branch
from
November 11, 2026 18:49
32d6956 to
1d9e2db
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/markdown-replacement-overload
branch
from
November 11, 2026 18:52
1d9e2db to
6cf156f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the requested optional second string to
MarkdownSection.replacerather than a separate substitution method:The existing whole-body form is unchanged. The search/replacement form uses JavaScript string/regex replacement semantics only within the selected body, including nested subsections. It preserves surrounding content, LF/CRLF style and unmatched spacing; unmatched searches do not rewrite the file. Invalid inputs, ambiguous headings and malformed line endings fail before writing.
Adds shared source/installed behavior assertions, positive/negative declaration contracts, documentation, and a changelog entry. Validation: 88 tests via
npm run test:coverage,npm run lint,git diff --check, and strict-engine consumers installed from the exact retained archive. The Markdown module has 100% line, branch and function coverage.Follow-up to #14, which merged while implementation was in progress. This layer targets #16 and extends existing native stack #17 without rewriting merged history. No publication or merge performed.
AI-authored by GitHub Copilot on behalf of @dblock.