Repository navigation
Run tests, lint and build on every pull request - #6
Open
davis-brown wants to merge 1 commit into
Open
davis-brown wants to merge 1 commit into
davis-brown wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
I added a CI workflow that runs on every pull request and on pushes to
main. All three jobs' commands pass locally. They haven't run on GitHub yet, so this PR is their first real run.What changed
.github/workflows/ci.yml, withpermissions: contents: read. A new commit on a branch cancels that branch's older run. It has three jobs:npm ci,npm testinbackend/.npm ci,npm run lint -- --no-fix,npm run buildinfrontend/.docker compose up --build -d, then waits up to 5 minutes forhttp://localhost:8080/api/eventsto give any HTTP response, then runstests/browser/run.sh. If any step fails, it printsdocker compose logs.actions/checkout@v4andactions/setup-node@v4with the built-in npm cache, pointed at each folder'spackage-lock.json.README.md: one line saying every pull request runs these checks.deploy-backend.yml, the application code andtests/browser/are unchanged.How I verified it
backend:npm ci && npm testpasses (3 tests).frontend:npm ci && npm run lint -- --no-fix && npm run buildreports no lint errors and the build completes. My local Node is 26, not the 20 CI uses, so CI is the real check for the version.calendar.check.js's result wasn't shown. The CI run will show it in full. I then took the stack down and removed its volumes.What to check
gh pr checksand confirm all three jobs are green, especially browser and the calendar check in its log.tests/browser/run.shruns the Playwright container as the runner's user and runsnpm ciintotests/browser/on the checkout. That works locally; it should also work on GitHub's runner, which owns the checkout.