test: add ClassifyContentAsyncTests — cover all 3 branches (null response, exception, type-switch)#175
Open
davidortinau wants to merge 1 commit into
Open
test: add ClassifyContentAsyncTests — cover all 3 branches (null response, exception, type-switch)#175davidortinau wants to merge 1 commit into
davidortinau wants to merge 1 commit into
Conversation
Vocabulary / 0.5f confidence
Vocabulary / 0.3f confidence with error signals
- 4-arm type-switch (vocabulary, phrases, sentences, transcript)
Vocabulary fallback
Also adds [InternalsVisibleTo("SentenceStudio.UnitTests")] via
src/SentenceStudio.Shared/AssemblyInfo.cs to expose the internal
ContentClassificationAiResponse DTO to the test project.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
ClassifyContentAsyncTests.cs— 6 xUnit tests that directly exercise every code path inContentImportService.ClassifyContentAsync(ContentImportService.cs:870), which was previously untested. Existing tests mock away classification by pre-settingContentTypeon the request, so the mapping and fallback logic had zero coverage.Also adds
[InternalsVisibleTo("SentenceStudio.UnitTests")]via a newAssemblyInfo.csin the Shared project to expose theinternal ContentClassificationAiResponseDTO to the test project.Why
ClassifyContentAsyncis the hot auto-detect path on thefeature/import-contentbranch. Without direct tests, regressions in any of its three branches (null AI response, AI exception, type-switch mapping) would only surface as silent wrong behaviour in integration.Tests added
ClassifyContent_NullAiResponse_DefaultsToVocabularyClassifyContent_AiException_DefaultsWithLowConfidence"error"signalClassifyContent_KnownType_MapsCorrectly(Theory ×4)vocabulary,phrases,sentences,transcriptarmsClassifyContent_UnknownType_FallsBackToVocabulary_arm → VocabularyVerification
489 pre-existing tests all still pass.