feat: add geopf sync - #1178
Draft
abulte wants to merge 2 commits into
Draft
Conversation
NuxtPage's page-key was bound to an inline arrow function (`route => route.fullPath`) in two admin layouts. Vue recreates that function on every render of the owning component, and NuxtPage compares page-key by reference (not by the value it computes) to decide whether to fire the page-loading indicator. A fresh reference for the same route is treated as "the page changed", firing page:loading:start with no matching navigation to ever complete it, so the top loading bar gets stuck. This went unnoticed because nothing previously triggered it: it only fires when the owning component re-renders while mounted, e.g. when pages/admin/datasets/[id].vue's own `dataset` (fetched via the same useAPI call/URL/options as a nested tab's own dataset fetch, and therefore sharing the same Nuxt useFetch cache key) gets refreshed by that nested tab. Fix: bind page-key to a stable, hoisted function instead of an inline one in pages/admin.vue and pages/admin/datasets/[id].vue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends opendatateam/udata#3827