fix(tests): wait for chart image upload before reloading in e2e tests - #1177
Merged
Conversation
saveChart() uploads the chart preview image after the visualization POST resolves. Two tests only awaited the visualization POST before calling page.reload(), which could abort the still in-flight image upload and fail assertNoConsoleErrors with a fetch error.
nicolaskempf57
approved these changes
Jul 30, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e (chromium, 2)has been intermittently failing onmainsince 2026-07-23 ontests/visualizations/chart-configurator.spec.ts› "x-axis dropdown should show columns from all chart resources after loading", withFailed to save chart: FetchError ... POST .../image/ <no response>.saveChart()upload a chart preview image (POST /api/1/visualizations/{id}/image/) after the visualization-creation POST resolves, but two tests only awaited that first POST before callingpage.reload(). Under CI load the image upload is sometimes still in flight, so the reload aborts it and the resulting console error trips theassertNoConsoleErrorsfixture./image/upload POST to resolve before reloading, in both affected tests.Test plan
pnpm exec eslint tests/visualizations/chart-configurator.spec.tspassespnpm run typecheckpassese2e (chromium, 2)passes (this is what we're fixing — watch this run)