feat: working on explore - #1167
Open
ThibaudDauce wants to merge 34 commits into
Open
Conversation
Contributor
|
The sidebar has trouble with format that are really long like |
| @@ -1,8 +1,35 @@ | |||
| <template> | |||
| <div class="space-y-5"> | |||
| <SimpleBanner | |||
Contributor
There was a problem hiding this comment.
This is not clear that the text is clickable if you dont try to hover it. Can we use the pattern from the admin with a text + a button ?
| alt="" | ||
| > | ||
| <p class="m-0 text-sm text-gray-medium"> | ||
| {{ t('Sélectionnez une ressource dans le menu pour l\'explorer.') }} |
Contributor
There was a problem hiding this comment.
We should update this when there is a search in the sidebar that show no results. We could even provide a "reset search" like the sidebar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to datagouv/data.gouv.fr#1970
You can test it with these ids in your
.envthen visit http://dev.local:3000/explore: