Skip to content

Remove squeeze/hybrid storage path; replace with eviction-only flow and keep lineage metadata - #516

Merged
XiangpengHao merged 2 commits into
mainfrom
codex/remove-squeeze-mechanism-from-codebase
Sep 4, 2026
Merged

XiangpengHao merged 2 commits into
mainfrom
codex/remove-squeeze-mechanism-from-codebase

Conversation

@XiangpengHao

@XiangpengHao XiangpengHao commented Sep 4, 2026 •

Copy link
Copy Markdown
Collaborator

we will still squeeze, but I'd rather rewrite than improve.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 3 medium

Results:
3 new issues

Category Results
Complexity 3 medium

View in Codacy

🟢 Metrics 55 complexity · -95 duplication

Metric Results
Complexity 55
Duplication -95

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.90698% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.83%. Comparing base (feb0fd9) to head (3652cc7).

Files with missing lines Patch % Lines
dev/dev-tools/src/trace/simulator.rs 20.00% 8 Missing ⚠️
dev/dev-tools/src/trace/parser.rs 42.85% 4 Missing ⚠️
src/core/src/cache/builders.rs 69.23% 3 Missing and 1 partial ⚠️
src/core/src/cache/io_context.rs 42.85% 4 Missing ⚠️
src/core/src/cache/core.rs 93.93% 2 Missing ⚠️
src/datafusion/src/reader/plantime/source.rs 66.66% 2 Missing ⚠️
src/core/src/cache/policies/eviction.rs 97.50% 1 Missing ⚠️
src/datafusion-client/src/client_exec.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   84.46%   83.83%   -0.63%     
==========================================
  Files          85       82       -3     
  Lines       19724    16254    -3470     
  Branches    19724    16254    -3470     
==========================================
- Hits        16660    13627    -3033     
+ Misses       2751     2368     -383     
+ Partials      313      259      -54     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

📊 Benchmark Comparison

Current: cd7cd2d1 (Liquid) vs Baseline: cd7cd2d1 (DataFusionDefault)

Query Cold Time Δ Warm Time Δ CPU Time Δ
Q1 3.0ms (3.0ms) +0.0% 0.000ms (0.000ms) +0.0% 0.000ms (0.000ms) +0.0%
Q2 18.0ms (9.0ms) +100.0% 6.0ms (6.0ms) +0.0% 8.0ms (7.5ms) +6.7%
Q3 18.0ms (14.0ms) +28.6% 6.5ms (11.0ms) -40.9% 3.0ms (23.5ms) -87.2%
Q4 18.0ms (13.0ms) +38.5% 5.0ms (11.0ms) -54.5% 2.5ms (24.0ms) -89.6%
Q5 62.0ms (50.0ms) +24.0% 58.5ms (49.5ms) +18.2% 4.5ms (25.0ms) -82.0%
Q6 167.0ms (103.0ms) +62.1% 76.5ms (105.5ms) -27.5% 25.0ms (80.0ms) -68.8%
Q7 1.0ms (1.0ms) +0.0% 0.000ms (1.0ms) -100.0% 0.000ms (0.000ms) +0.0%
Q8 7.0ms (6.0ms) +16.7% 4.0ms (5.5ms) -27.3% 8.0ms (6.0ms) +33.3%
Q9 94.0ms (90.0ms) +4.4% 70.5ms (85.5ms) -17.5% 5.0ms (44.0ms) -88.6%
Q10 91.0ms (90.0ms) +1.1% 66.5ms (89.0ms) -25.3% 5.5ms (64.0ms) -91.4%
Q11 36.0ms (25.0ms) +44.0% 17.0ms (26.0ms) -34.6% 31.0ms (36.5ms) -15.1%
Q12 44.0ms (31.0ms) +41.9% 20.5ms (28.0ms) -26.8% 34.0ms (43.5ms) -21.8%
Q13 179.0ms (107.0ms) +67.3% 90.0ms (109.0ms) -17.4% 54.5ms (77.0ms) -29.2%
Q14 319.0ms (133.0ms) +139.8% 124.0ms (138.0ms) -10.1% 85.5ms (103.0ms) -17.0%
Q15 216.0ms (115.0ms) +87.8% 91.5ms (97.5ms) -6.2% 62.0ms (90.0ms) -31.1%
Q16 103.0ms (114.0ms) -9.6% 90.5ms (99.5ms) -9.0% 4.0ms (26.0ms) -84.6%
Q17 414.0ms (219.0ms) +89.0% 246.5ms (210.5ms) +17.1% 88.0ms (102.0ms) -13.7%
Q18 437.0ms (210.0ms) +108.1% 243.5ms (209.5ms) +16.2% 87.0ms (104.0ms) -16.3%
Q19 624.0ms (387.0ms) +61.2% 374.0ms (386.0ms) -3.1% 109.0ms (147.5ms) -26.1%
Q20 16.0ms (12.0ms) +33.3% 3.0ms (12.0ms) -75.0% 7.0ms (25.0ms) -72.0%
Q21 781.0ms (177.0ms) +341.2% 212.0ms (175.0ms) +21.1% 502.0ms (265.5ms) +89.1%
Q22 1.03s (160.0ms) +545.6% 315.5ms (170.5ms) +85.0% 179.0ms (336.0ms) -46.7%
Q23 2.08s (477.0ms) +336.3% 885.5ms (481.0ms) +84.1% 575.0ms (733.5ms) -21.6%
Q24 20.45s (924.0ms) +2112.8% 802.0ms (933.5ms) -14.1% 652.0ms (2.57s) -74.6%
Q25 180.0ms (74.0ms) +143.2% 15.0ms (60.0ms) -75.0% 36.0ms (115.5ms) -68.8%
Q26 107.0ms (48.0ms) +122.9% 19.5ms (44.0ms) -55.7% 52.5ms (79.0ms) -33.5%
Q27 189.0ms (74.0ms) +155.4% 27.0ms (58.0ms) -53.4% 78.0ms (118.0ms) -33.9%
Q28 1.02s (219.0ms) +367.6% 384.5ms (217.5ms) +76.8% 348.5ms (279.0ms) +24.9%
Q29 1.86s (1.02s) +82.4% 1.04s (1.00s) +3.7% 617.0ms (338.0ms) +82.5%
Q30 28.0ms (26.0ms) +7.7% 21.0ms (28.5ms) -26.3% 6.0ms (20.5ms) -70.7%
Q31 271.0ms (104.0ms) +160.6% 63.0ms (105.0ms) -40.0% 41.0ms (147.5ms) -72.2%
Q32 531.0ms (107.0ms) +396.3% 90.5ms (103.5ms) -12.6% 58.5ms (152.0ms) -61.5%
Q33 324.0ms (321.0ms) +0.9% 277.0ms (299.5ms) -7.5% 8.0ms (72.5ms) -89.0%
Q34 1.01s (411.0ms) +146.7% 454.5ms (396.5ms) +14.6% 355.5ms (266.5ms) +33.4%
Q35 1.14s (403.0ms) +182.1% 431.0ms (395.0ms) +9.1% 358.5ms (269.0ms) +33.3%
Q36 100.0ms (101.0ms) -1.0% 86.0ms (95.5ms) -9.9% 4.0ms (25.0ms) -84.0%
Q37 337.0ms (103.0ms) +227.2% 82.5ms (99.5ms) -17.1% 41.0ms (73.0ms) -43.8%
Q38 72.0ms (47.0ms) +53.2% 31.0ms (42.5ms) -27.1% 21.0ms (23.0ms) -8.7%
Q39 254.0ms (47.0ms) +440.4% 12.0ms (47.0ms) -74.5% 10.0ms (71.0ms) -85.9%
Q40 779.0ms (186.0ms) +318.8% 225.0ms (177.5ms) +26.8% 85.0ms (121.0ms) -29.8%
Q41 23.0ms (18.0ms) +27.8% 10.0ms (18.0ms) -44.4% 6.0ms (16.0ms) -62.5%
Q42 21.0ms (17.0ms) +23.5% 10.0ms (19.0ms) -47.4% 6.0ms (17.0ms) -64.7%
Q43 18.0ms (18.0ms) +0.0% 10.5ms (16.0ms) -34.4% 6.5ms (11.0ms) -40.9%

⚠️ LiquidCache is slower on 8 queries (warm)

  • Q22: warm +85.0% (315.5ms vs 170.5ms)
  • Q23: warm +84.1% (885.5ms vs 481.0ms)
  • Q28: warm +76.8% (384.5ms vs 217.5ms)
  • Q40: warm +26.8% (225.0ms vs 177.5ms)
  • Q21: warm +21.1% (212.0ms vs 175.0ms)
  • Q5: warm +18.2% (58.5ms vs 49.5ms)
  • Q17: warm +17.1% (246.5ms vs 210.5ms)
  • Q18: warm +16.2% (243.5ms vs 209.5ms)

Compared Liquid vs DataFusionDefault on the same runner
Regressions: warm-time increases of at least 15%. Cold Time: first iteration; Warm Time: median of remaining iterations.

@XiangpengHao
XiangpengHao merged commit 3c89a8d into main Sep 4, 2026
15 checks passed
@XiangpengHao
XiangpengHao deleted the codex/remove-squeeze-mechanism-from-codebase branch September 4, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant