Fix JiT assertion compilation to accept object result shape#2221
Merged
Conversation
rafal-hawrylak
requested review from
apilaskowski,
ikholopov-omni and
udim
and removed request for
a team and
udim
July 15, 2026 11:56
Assertion JiT code returning an object (rather than a bare string)
had the whole object stored into JitAssertionResult.query — a string
field — producing broken read-back and downstream encoding errors.
Coerce the result inline: string → { query }, object passes through.
Widen JitAssertionResult to `string | { query: string }` to match.
Regression tests cover the bare-object shape and an object with
additional (ignored) fields.
rafal-hawrylak
force-pushed
the
fix-jit-assertion-object-shape
branch
from
July 15, 2026 12:06
6cfdd04 to
02f3d62
Compare
ikholopov-omni
approved these changes
Jul 15, 2026
apilaskowski
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertion JiT code returning an object (rather than a bare string) had the whole object stored into JitAssertionResult.query — a string field — producing broken read-back and downstream encoding errors.
Mirror makeJitTableResult: unwrap .query from an object, keep the bare-string path unchanged. Widen JitAssertionResult to
string | { query: string }to match.Regression tests cover the bare-object shape and an object with additional (ignored) fields.
Integration of JiT assertions will come in new PR after #2211 lands.