Refactor Runner parameter overloads and resolve review comments by rafal-hawrylak · Pull Request #2210 · dataform-co/dataform

rafal-hawrylak · 2026-06-19T19:15:05Z

Pre follow up of #2184

apilaskowski · 2026-07-13T12:12:25Z

Makes some sense to include projectDir here in preparation for Integrate JiT compilation into CLI runtime #2211 (in perfect world I would prefer to have it separately).
Removing the parameter union and handleParamsOverloads in favor of Runner.create and Runner.resume makes the instantiation API significantly cleaner.
The switch statement for CancelReason exhaustiveness and the fallback guard for missing timeoutMillis look great.
LGTM! 🚀

rafal-hawrylak requested a review from ikholopov-omni June 19, 2026 19:15

rafal-hawrylak requested a review from a team as a code owner June 19, 2026 19:15

rafal-hawrylak requested review from Ceridan and removed request for a team and Ceridan June 19, 2026 19:15

rafal-hawrylak mentioned this pull request Jun 19, 2026

Integrate JiT compilation into CLI runtime #2184

Closed

rafal-hawrylak force-pushed the pr4b-refactor-runner branch from 5811b99 to d836784 Compare June 19, 2026 19:24

rafal-hawrylak mentioned this pull request Jun 20, 2026

Integrate JiT compilation into CLI #2110

Open

apilaskowski assigned rafal-hawrylak Jun 22, 2026

rafal-hawrylak force-pushed the pr4b-refactor-runner branch 3 times, most recently from 7df9bd9 to edb1e7d Compare July 2, 2026 09:30

rafal-hawrylak requested a review from apilaskowski July 2, 2026 12:02