[ENG-4138]: Make Memgraph snapshot retention count configurable#345
Open
anatoly-scherbakov wants to merge 3 commits into
Open
[ENG-4138]: Make Memgraph snapshot retention count configurable#345anatoly-scherbakov wants to merge 3 commits into
anatoly-scherbakov wants to merge 3 commits into
Conversation
Add --storage-snapshot-retention-count to the Memgraph StatefulSet args, defaulting to 32 via a new snapshotRetentionCount value so deployments can override it through rawValues.memgraph instead of relying on the unbounded default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
🔍 Kubeconform Validation Results✅ All cloud provider configurations passed Kubernetes API schema validation!
The rendered Kubernetes manifests conform to the Kubernetes API specification across all cloud providers. |
Required by ct lint version-bump gate for the Memgraph snapshot retention change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
🔍 Kubeconform Validation Results✅ All cloud provider configurations passed Kubernetes API schema validation!
The rendered Kubernetes manifests conform to the Kubernetes API specification across all cloud providers. |
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
🔍 Kubeconform Validation Results✅ All cloud provider configurations passed Kubernetes API schema validation!
The rendered Kubernetes manifests conform to the Kubernetes API specification across all cloud providers. |
cfernhout
requested changes
Jun 9, 2026
Source .env only when it exists so direnv stops erroring on a fresh checkout. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
anatoly-scherbakov
force-pushed
the
anatoly-eng-4138-increase-snapshot-count
branch
from
0342494 to
fc7c798
Compare
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
anatoly-scherbakov
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
🔍 Kubeconform Validation Results✅ All cloud provider configurations passed Kubernetes API schema validation!
The rendered Kubernetes manifests conform to the Kubernetes API specification across all cloud providers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the Memgraph snapshot retention count configurable instead of relying on Memgraph's unbounded default.
snapshotRetentionCount: 32tocharts/datafold/charts/memgraph/values.yaml.--storage-snapshot-retention-count={{ .Values.snapshotRetentionCount }}in the StatefulSet args (charts/datafold/charts/memgraph/templates/statefulset.yaml).Why
The Memgraph container args were hardcoded and did not cap snapshot retention, so on-disk snapshots could grow unbounded. This caps retention at 32 by default and lets deployments tune it.
Override
Deployments can override via the operator's
rawValues, which map straight onto subchart values:Verification
helm templatethrough the parent chart renders the new arg:Overriding
memgraph.snapshotRetentionCount=64renders--storage-snapshot-retention-count=64.No chart version bumps (memgraph dependency is pinned as
*.*.*in the parent).🤖 Generated with Claude Code