values: drop stale worker-temporal mentions in comments#337
Open
cfernhout wants to merge 1 commit into
Open
Conversation
worker-temporal is no longer a releasable worker — it only exists as the shared subchart that every per-queue worker (worker-thunderbolt, worker-io, worker-compute, worker-highmem, worker-storage, worker-storage-high, worker-monitors, worker-catalog, worker-lineage, worker-monitor, worker-singletons, worker-interactive) aliases via Chart.yaml. - L69 parenthetical "(worker-temporal)" no longer adds info; the storageClassName name is the only fact worth surfacing. - L109 "server and worker-temporal containers" was misleading: the custom codec mounts into ALL temporal worker pods, not just one named 'worker-temporal'.
🔍 Kubeconform Validation Results✅ All cloud provider configurations passed Kubernetes API schema validation!
The rendered Kubernetes manifests conform to the Kubernetes API specification across all cloud providers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two stale
worker-temporalreferences incharts/datafold/values.yamlcomments.worker-temporalno longer exists as a releasable worker — it only exists as the shared subchart that every per-queue worker (worker-thunderbolt,worker-io,worker-compute,worker-highmem,worker-storage,worker-storage-high,worker-monitors,worker-catalog,worker-lineage,worker-monitor,worker-singletons,worker-interactive) aliases viaChart.yaml.# Temporal worker StorageClass ... and PVC storageClassName (worker-temporal).# Temporal worker StorageClass ... and PVC storageClassName.# the server and worker-temporal containers at /datafold/plugins/<fileName>.# the server and all temporal worker containers at /datafold/plugins/<fileName>.The L109 wording was actively misleading: the custom codec mounts into all temporal worker pods (every alias of the worker-temporal subchart), not just one container named
worker-temporal.Verification
Test plan
worker-temporalreferences invalues.yamlPure docs change, 2 lines edited.