Ilongin/1910 preserve pydantic class identity - #1969
Open
ilongin wants to merge 10 commits into
Open
Conversation
ilongin
marked this pull request as draft
August 31, 2026 14:53
Deploying datachain with
|
| Latest commit: |
f032289
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13b00d32.datachain-2g6.pages.dev |
| Branch Preview URL: | https://ilongin-1910-preserve-pydant.datachain-2g6.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ilongin
marked this pull request as ready for review
September 2, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the identity of plain Pydantic models when reading saved datasets in a new process.
Previously, only
DataModelsubclasses were registered automatically. A plainBaseModelwas reconstructed from its stored schema during deserialization, even when the original class had already been imported. The reconstructed class had the same name and fields but different Python identity, causingisinstance()checks and nested Pydantic validation to fail.Closes #1910.
Changes
ModelStorematches before reusing them.sys.modules; dataset metadata never triggers a module import.Tests
ModelStorebehavior.Fixes #1910