Fix client/server E2E lock root isolation#1048
Merged
stephenamar-db merged 1 commit intoJun 25, 2026
Merged
Conversation
Motivation: Client/server E2E tests launched a server under a test lock directory, but the client process still used the default user.home worker directory. On shared CI hosts this could collide with stale or unrelated sjsonnet workers and leave tests waiting until the 30s client timeout. Modification: Give each E2E scenario a short, test-owned user.home, derive the matching mill-worker lockBase for both server and client, wait for the UDS socket before invoking the client, and clean up matching server processes after each scenario. Include server logs in timeout/startup failures. Result: The malformed-jsonnet and reuse E2E paths no longer depend on global ~/.sjsonnet state, avoid long UDS paths, and pass repeated stress runs without 30s hangs.
stephenamar-db
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
It was flasky