fix: std.parseJson reports truncated input cleanly#1042
Open
He-Pin wants to merge 2 commits into
Open
Conversation
Motivation: std.parseJson on truncated/incomplete JSON input leaked a raw Java ujson.IncompleteParseException stack trace instead of a clean error message. The catch block only handled ujson.ParseException but not its sibling IncompleteParseException. Modification: - Catch ujson.IncompleteParseException alongside ParseException in ManifestModule.ParseJson.evalRhs. - Produce a clean "Invalid JSON: unexpected end of JSON input" message matching go-jsonnet's wording for truncated input. - Add golden test for truncated JSON input. Result: - Truncated JSON input produces a clean CLI error with no stack trace. - Happy path and malformed (non-truncated) JSON are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
std.parseJsonon truncated/incomplete JSON input leaked a raw Javaujson.IncompleteParseExceptionstack trace instead of a clean error message. The catch block only handledujson.ParseExceptionbut not its siblingIncompleteParseException.'{"a":'Internal Error+ full Java stack tracefailed to parse JSON: unexpected end of JSON inputInvalid JSON: unexpected end of JSON input""Internal Error+ full Java stack tracefailed to parse JSON: unexpected end of JSON inputInvalid JSON: unexpected end of JSON input"[1,2"Internal Error+ full Java stack tracefailed to parse JSON: unexpected end of JSON inputInvalid JSON: unexpected end of JSON inputModification
ujson.IncompleteParseExceptionalongsideParseExceptioninManifestModule.ParseJson.evalRhs."Invalid JSON: unexpected end of JSON input"message matching go-jsonnet's wording.Result
References
ParseExceptionandIncompleteParseExceptionboth implementParsingFailedExceptionbut neither extends the other.