Repository navigation
test(blocksync): build handover tests against BlockResponse.Height - #1621
Conversation
#1595 replaced the decoded block in the synchronizer's BlockResponse with its committed bytes and a Height field. The handover tests from #1618, merged after it, still set and read BlockResponse.Block, so the blocksync test package no longer compiled on dev. They only need the height, which addBlock reads from Height. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgi2uMsQDcBcKAwLdt
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
✅ Final review complete — no blockers (commit 03258aa) · triage: low |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
At head 03258aa, the test-only changes correctly replace stale BlockResponse.Block references with Height while preserving the fixtures' heights, ordering, and timing behavior. No in-scope issues were found; current CI passes build, lint, vet, all six test shards, and both e2e jobs, with only PastaClaw review and PR Hygiene pending. Validation was static; no local builds or tests were run.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a small, contained test-only update that replaces obsolete BlockResponse.Block references with the existing Height field and does not change production behavior. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 91% left, weekly 59% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer
Out-of-scope follow-up suggestions (1)
These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.
- Stacked-PR merge order broke dev despite per-PR CI — The proposed post-merge CI follow-up is already implemented: .github/workflows/tests.yml and build.yml both run on pushes to dev. The asserted merge order is also reversed in the actual history: #1595's commit 0bdad33 directly follows #1618's commit 4e15907. The base's stale test references are real and this PR repairs them, but they do not establish the claimed missing post-merge checks; adding a merge queue is a broader workflow proposal outside this test repair's responsibility.
- Follow-up: Consider creating a separate issue or author/maintainer-requested PR for this.
|
Policy satisfied — this can merge. |
TL;DR: The block sync tests on
devno longer compile after two PRs merged on top of each other; this updates the tests sodevbuilds and passes CI again.Detailed discussion
Internal test-only change, no user-observable effect, so there is no user story or scenario.
#1595 replaced the decoded block in the synchronizer's
BlockResponsewith its committed bytes (BlockBytes) and aHeightfield. #1618 was merged after it, and its handover tests still set and readBlockResponse.Block. Each PR passed CI on its own; together they leave theinternal/blocksynctest package uncompilable (unknown field Block in struct literal of type BlockResponse), which failsgolangci-lintand the test jobs on every PR based ondev, including thev2.0.0-dev.2release PR #1620.The affected tests only use the height (
Synchronizer.addBlockreadsresp.Height), so they now setHeightand readresp.Height.Blocks #1620 (release
v2.0.0-dev.2), which will be re-frozen on thedevtip containing this fix.Testing
go test -count=1 ./internal/blocksync/: okgo vet ./...: clean;gofmt -l internal/blocksync: clean🤖 Generated with Claude Code
https://claude.ai/code/session_01WunYYgi2uMsQDcBcKAwLdt
🤖 Co-authored by Claudius the Magnificent AI Agent
PR Hygiene ·
03258aainternal/blocksync/ask_every_peer_test.go,internal/blocksync/handover_deadline_test.go,internal/blocksync/handover_late_supply_test.goand 1 more) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.