Skip to content

feat(key-wallet): verify owner authorization of a pending spend - #1416

Open
lklimek wants to merge 3 commits into
devfrom
feat/key-wallet-spend-authorization
Open

lklimek wants to merge 3 commits into
devfrom
feat/key-wallet-spend-authorization

Conversation

@lklimek

@lklimek lklimek commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

A wallet that restores its history can see a pending spend of one of its coins before the spend is final, with no way to tell whether the coin's owner actually signed it. This PR adds key_wallet::transaction_checking::spend_authorization::verify_input_authorization, which checks that an input carries a valid P2PKH / SIGHASH_ALL owner signature for the funding output it claims.

Unsupported funding scripts and signature hash types return a typed SpendAuthorizationError, so a caller does not release an existing hold by mistake. Malformed or invalid signatures return false. The check covers authorization only: it validates neither amounts nor consensus rules, and it is no evidence of finality.

Split out of #1336 at a maintainer's request, since it shares no code with the InstantLock changes there. The consumer is Platform's persisted-history restoration (dashpay/platform#5220).

🤖 Generated with Claude Code

PR Hygiene · 5e9a975

  • Bots — coderabbitai ✓
  • Self-review — post /self-reviewed
  • Build running
  • Approvals
    • key-wallet (key-wallet/Cargo.toml, key-wallet/src/transaction_checking/mod.rs, key-wallet/src/transaction_checking/spend_authorization.rs) — QuantumExplorer or ZocoLini or xdustinface

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • New Features
    • Added verification for owner authorization of pending coin reservations, helping ensure that transaction inputs are signed by the owner of the funds.
    • Authorization checks now reject inputs that cannot be validated or use unsupported funding scripts or signature modes.

`verify_input_authorization` checks that a transaction input carries a valid P2PKH / `SIGHASH_ALL` owner signature for the funding output it claims. A wallet can use it to decide whether a pending spend may reserve one of its coins before the spend is final.

Unsupported funding scripts and signature hash types return a typed `SpendAuthorizationError`, so a caller does not release an existing hold by mistake. Malformed or invalid signatures return `false`. The check covers authorization only: it validates neither amounts nor consensus rules, and it is no evidence of finality.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The transaction-checking module adds a public verifier for P2PKH input authorization. It checks input structure, owner-key matching, and signature validity. Tests cover input binding, malformed or invalid inputs, and supported and unsupported sighash modes.

Changes: P2PKH Spend Authorization

Layer / File(s) Summary
Verifier API and checks
key-wallet/Cargo.toml, key-wallet/src/transaction_checking/mod.rs, key-wallet/src/transaction_checking/spend_authorization.rs
Adds thiserror and exposes spend_authorization. The verifier checks input bounds and outpoint uniqueness, requires a P2PKH prevout and two pushed script instructions, matches the public-key hash, and verifies the signature. A valid signature with a mode other than SIGHASH_ALL returns UnsupportedSighash.
Input binding and owner signature tests
key-wallet/src/transaction_checking/spend_authorization.rs
Adds test helpers and tests for input-specific authorization, transaction changes, input reordering, compressed and uncompressed keys, wallet-produced signatures, and asset-lock payload changes.
Failure and sighash tests
key-wallet/src/transaction_checking/spend_authorization.rs
Tests unsigned, modified, wrong-prevout, out-of-range, duplicate-outpoint, malformed-script, and invalid-signature cases. Tests also cover witness changes, unsupported valid sighash modes, and non-P2PKH prevouts.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: xdustinface, quantumexplorer

Merge Risk: Minimal · up to 5e9a9

This adds a standalone, additive public verifier for P2PKH spend authorization, with a new dependency on the existing workspace thiserror and tests for input binding and signature modes. No concrete defect was found, and existing wallet behavior is unaffected. Callers must still supply the correct funding output and apply their own amount and consensus checks.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat(key-wallet): verify owner authorization of a pending spend" matches the main change. The PR adds verify_input_authorization in key-wallet's spend_authorization module, which checks tha…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat(key-wallet): verify owner authorization of a pending spend" matches the main change. The PR adds verify_input_authorization in key-wallet's spend_authorization module, which checks that a transaction input carries the P2PKH owner signature for its funding output. The title names the crate, the change type, and the core behavior, and it does not describe anything absent from the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9ac4d8b and 5e9a975.

Files selected for processing: 3

  • key-wallet/Cargo.toml
  • key-wallet/src/transaction_checking/mod.rs
  • key-wallet/src/transaction_checking/spend_authorization.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.49057% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.96%. Comparing base (9ac4d8b) to head (5e9a975).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...et/src/transaction_checking/spend_authorization.rs 98.49% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1416      +/-   ##
==========================================
+ Coverage   85.92%   85.96%   +0.04%     
==========================================
  Files         269      270       +1     
  Lines       70919    71184     +265     
==========================================
+ Hits        60935    61192     +257     
- Misses       9984     9992       +8     
Flag Coverage Δ
core 82.81% <ø> (ø)
rpc 52.10% <ø> (ø)
spv 94.44% <ø> (-0.02%) ⬇️
wallet 84.26% <98.49%> (+0.15%) ⬆️
Files with missing lines Coverage Δ
...et/src/transaction_checking/spend_authorization.rs 98.49% <98.49%> (ø)

... and 5 files with indirect coverage changes

@lklimek
lklimek marked this pull request as ready for review November 16, 2026 08:28
@manki-review

manki-review Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Review complete in 7m 4s

Planner (4s)
    feat · 407 lines · 2 agents
    judge effort: high

Review (security · pair): 5 findings
    ✅ Claude Sonnet 5.5 · high: 2 findings (1m 55s)
    ✅ Claude Opus 5.5 · high: 3 findings (4m 21s)

Judge: 3 kept · 1 dropped (2m 3s)
    kept: 3 suggestions
    dropped: 1 suggestion

Review metadata

Config:

  • Models: reviewer=claude-sonnet-5-5, judge=claude-opus-5-5
  • Triage: trivial=false, subtle=true, paired=true (planner, security-sensitive paths, CI or dependency paths)
  • Team: Claude Sonnet 5.5 · high, Claude Opus 5.5 · high
  • Memory: enabled (central)

Account limits:

  • Claude subscription: weekly 28% (resets 2026-11-20 20:00 UTC)

Judge decisions:

  • Not finished: "Non-standard sighash bytes may become Ok(false) instead of UnsupportedSighash" (warning): "Blocker cell, held at warning by an unsettled premise. At spend_authorization.rs:69-71 the whole pushed signature, hash byte included, goes to Signature::from_slice, and any parse error becomes Ok(false). Signature is re-exported from the external bitcoin_crypto crate (crypto/src/ecdsa.rs:30). In the rust-bitcoin design that crate follows, from_slice parses the hash byte with from_standard and rejects undefined values. If this one does the same, an owner signature with mode 0, 4 or 0xff returns Ok(false) at line 70 and never reaches the UnsupportedSighash branch at line 87. Such a signature is consensus-valid: Core rejects these hash types only under the STRICTENC policy flag (dashpay/dash:src/script/interpreter.cpp:211). So the caller treats an authorized spend as unauthorized and releases the hold, against the doc at lines 28-29. The test at line 384 would then fail, but no CI result is shown. The crate source is not in the code shown, so test 4 is unsettled.
    Refutation unsettled: Whether bitcoin_crypto::ecdsa::Signature::from_slice rejects non-standard sighash bytes decides whether line 69 returns Ok(false) before the UnsupportedSighash check at line 87, but the external crate (Cargo.toml:70, not patched or vendored) cannot be read here. The crate's EcdsaSighashType has a NonStandard variant that from_consensus returns (CHANGELOG.md:120-124, crypto/src/sighash.rs:42), which weakens the finding but does not show which conversion from_slice uses. Rule checked: A parser that maps the trailing sighash byte through a standard-only conversion (rust-bitcoin's EcdsaSighashType::from_standard) rejects undefined hash types, whereas from_consensus keeps them as a NonStandard value.
  • Premise "bitcoin_crypto::ecdsa::Signature::from_slice returns an error when the last byte is not one of 0x01, 0x02, 0x03, 0x81, 0x82, 0x83 (for example via EcdsaSighashType::from_standard)" unsettled. The source of bitcoin_crypto::ecdsa::Signature::from_slice is in an external crates.io dependency that is not in the checkout; the changelog shows its sighash type has a NonStandard variant reachable via from_consensus but also names from_standard, so which one from_slice uses cannot be read.
  • Premise "A caller that gets Ok(false) from verify_input_authorization releases the pending hold on the coin, while Err(UnsupportedSighash) keeps it" confirmed. No in-repo caller exists (only the module declaration), but the function's documented contract says errors are returned so an existing pending hold is not silently released, while false marks the input as not authorized, which is the documented usage the premise describes."
  • Dropped: "Structural Ok(false) checks run before the unsupported-script check" (ignore): "ignore. Neither early return is an unsupported authorization form. An input_index past the end (spend_authorization.rs:35-37) names an input that does not exist, so no spend of the coin is claimed. A transaction that spends the same outpoint twice (lines 38-46) is consensus-invalid and can never confirm, so it cannot spend the coin whatever the funding script is. Returning false for both matches the doc at line 29, which reserves the error for unsupported forms of an otherwise well-formed spend."
  • Kept: "normalize_s does nothing, so the high-S test passes without it" (suggestion): "note. EcdsaPublicKey::verify already accepts a high-S signature: crypto/src/ecdsa.rs:370 asserts that it verifies without normalization. So the normalize_s() call at spend_authorization.rs:73 and its comment change nothing. should_accept_high_s_owner_authorization still passes with that call removed, so it guards no line of this change. Results stay correct, so this is cleanup and test clarity."
  • Kept: "Doc comment on verify_input_authorization runs to eight lines, over the three-line ceiling" (suggestion): "note. The Comments and docs section of AGENTS.md sets three lines as the ceiling, and its own good example is a three-line doc comment. The added /// block at spend_authorization.rs:22-29 runs to eight lines. This is a comment-length convention with no effect at run time."
  • Kept: "Test calls hex_conservative::decode_to_vec by full path instead of importing it" (suggestion): "note. AGENTS.md forbids writing a fully qualified path to avoid an import. Line 337 calls hex_conservative::decode_to_vec(...) with no use at the top of mod tests. This is an import-style convention in test code."

Timing:

  • Parse: 4.3s
  • Review agents: 296.8s
  • Judge: 123.4s
  • Total: 424.5s

@github-actions

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 16, 2026
manki-review[bot]
manki-review Bot previously approved these changes Nov 16, 2026

@manki-review manki-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. 3 suggestions, none of which block.

What this does: Adds a function that checks whether a transaction input carries a valid owner signature for the coin it spends. It accepts only P2PKH coins signed over the whole transaction.


What to test

The review model wrote these steps. Check what a step runs before you follow it.

Setup: Run cargo test -p key-wallet --all-features spend_authorization.

  1. Sign a one-input P2PKH transaction with SIGHASH_ALL and call verify_input_authorization with its funding output. Expect Ok(true).
  2. Change an output amount after signing. Expect Ok(false).
  3. Pass the funding output of a different key. Expect Ok(false).
  4. Sign with mode 2 (NONE) or 0x81 (ALL with ANYONECANPAY). Expect Err(UnsupportedSighash(mode)).
  5. Pass a funding output whose script is not P2PKH. Expect Err(UnsupportedScript).
  6. Flip the hash-type byte of a valid signature without re-signing. Expect Ok(false), not an error.
  7. Edge case: add a second input with the same outpoint. Expect Ok(false).
  8. Edge case: replace the signature with its high-S form. Expect Ok(true).

Checked and left out: 1 finding

Not finished checking · 1 lead

The progress comment has the full log under "Judge decisions", in its "Review metadata" fold.

About this review
  • Reviewed a4b7cf9, round 1
  • 407 changed lines read in 7m 4s
  • Found by claude-sonnet-5-5 and claude-opus-5-5, judged by claude-opus-5-5
  • Tokens: 3.7M in (3.3M from cache) · 60k out · about $3.24 at API prices
  • Runner: self-hosted · started after 6s · peak memory 2.5 GiB of 30.0 GiB
  • How Manki reviews

The repeated-outpoint case appended the duplicate input after signing, so the signature check alone rejected it and no test failed without the uniqueness guard. The owner now signs the transaction with the outpoint already listed twice, so only the guard rejects it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@manki-review

manki-review Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Review complete in 5m 15s

Planner (4s)
    feat · 410 lines · 2 agents
    judge effort: high

Review (security · pair): 2 findings
    ✅ Claude Sonnet 5.5 · high: 0 findings (1m 18s)
    ✅ Claude Opus 5.5 · high: 2 findings (3m 33s)

Judge: 2 kept · 0 dropped (57s)
    kept: 2 suggestions

Review metadata

Config:

  • Models: reviewer=claude-sonnet-5-5, judge=claude-opus-5-5
  • Triage: trivial=false, subtle=true, paired=true (planner, security-sensitive paths, CI or dependency paths)
  • Team: Claude Sonnet 5.5 · high, Claude Opus 5.5 · high
  • Memory: enabled (central)

Account limits:

  • Claude subscription: weekly 30% (resets 2026-11-20 20:00 UTC)

Judge decisions:

  • Kept: "Signature parsing takes a detour through Signature::from_slice and a redundant normalize_s" (suggestion): "note. This is the same point as P1, and the code at lines 69-74 has not changed, so the prior cell stays. The doc at crypto/src/ecdsa.rs:75-77 says EcdsaPublicKey::verify accepts high-S signatures, so normalize_s at line 73 changes no result. dash/src/crypto/sighash.rs:412-420 already shows the simpler split_at plus EcdsaSignature::from_der path. The remark about how from_slice handles non-standard hash bytes is unverified. The test should_preserve_unsupported_authorization_as_an_error (modes 0, 4, 0xff) passes with a green build, which suggests from_slice accepts those bytes. The point is a simplification, not a defect."
  • Kept: "Doc comment on verify_input_authorization runs to eight lines, over the three-line ceiling" (suggestion): "note. This is the same point as P2, and the doc comment is unchanged. AGENTS.md sets three lines as the ceiling for a comment. The doc comment at lines 22-29 added by this PR is eight lines long. It is a docs convention only, so it falls on the style row."

Timing:

  • Parse: 6.0s
  • Review agents: 252.4s
  • Judge: 56.8s
  • Total: 315.1s

@github-actions

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

manki-review[bot]
manki-review Bot previously approved these changes Nov 16, 2026

@manki-review manki-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved.

What this does: Adds a public check that a pending transaction input is really signed by the owner of the P2PKH coin it spends, using a signature that covers the whole transaction. A wallet can use this to decide whether to hold that coin as spent before the transaction is final.


What to test

The review model wrote these steps. Check what a step runs before you follow it.

Setup: Run cargo test -p key-wallet --all-features spend_authorization, or call verify_input_authorization from a small harness with a signed transaction and its funding output.

  1. Sign a one-input P2PKH transaction with SIGHASH_ALL and verify it against its funding output. Expect Ok(true).
  2. Sign it with the wallet's own sign_tx. Expect Ok(true).
  3. Change an output value after signing. Expect Ok(false).
  4. Verify against a funding output whose script is not P2PKH. Expect Err(UnsupportedScript).
  5. Sign with SIGHASH_NONE or SIGHASH_SINGLE|ANYONECANPAY. Expect Err(UnsupportedSighash(mode)).
  6. Overwrite only the hash type byte of a valid SIGHASH_ALL signature with 0x82. Expect Ok(false), not an error.
  7. Edge case: list the same outpoint twice in the inputs. Expect Ok(false).
  8. Edge case: replace the signature with its high-S form. Expect Ok(true).
About this review
  • Reviewed 10bbbb9, round 2
  • 410 changed lines read in 5m 15s
  • Found by claude-sonnet-5-5 and claude-opus-5-5, judged by claude-opus-5-5
  • Tokens: 3.0M in (2.6M from cache) · 50k out · about $2.67 at API prices
  • Runner: self-hosted · started after 6s · peak memory 2.6 GiB of 30.0 GiB
  • How Manki reviews

`EcdsaPublicKey::verify` already accepts high-S signatures, which `dashcore-crypto`'s `verify_accepts_high_s` covers, so the `normalize_s` call before it changed nothing and `should_accept_high_s_owner_authorization` passed without it. Both are removed, along with that test's copy of the group-order subtraction.

The doc comment of `verify_input_authorization` is cut to three lines. The scope caveats it dropped are in the PR description.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@manki-review

manki-review Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Review complete in 4m 53s

Planner (5s)
    feat · 370 lines · 2 agents
    judge effort: high

Review (security · pair): 3 findings
    ✅ Claude Sonnet 5.5 · high: 1 finding (47s)
    ✅ Claude Opus 5.5 · high: 2 findings (1m 45s)

Judge: 0 kept · 3 dropped (1m 11s)
    dropped: 1 warning · 2 suggestions

Review metadata

Config:

  • Models: reviewer=claude-sonnet-5-5, judge=claude-opus-5-5
  • Triage: trivial=false, subtle=true, paired=true (planner, security-sensitive paths, CI or dependency paths)
  • Team: Claude Sonnet 5.5 · high, Claude Opus 5.5 · high
  • Memory: enabled (central)

Account limits:

  • Claude subscription: weekly 33% (resets 2026-11-20 20:00 UTC)

Judge decisions:

  • Dropped: "Consensus-valid high-S owner signatures now return Ok(false)" (ignore): "ignore. The finding's premise is that EcdsaPublicKey::verify rejects high-S signatures. The cited code contradicts it: the doc on verify at crypto/src/ecdsa.rs:75-77 says a high-S signature verifies like its low-S twin, and Finding 3 cites the same behaviour. Removing normalize_s is also the fix an earlier round asked for in P1. This finding objects to applying that fix and shows no new defect, so it is a flip-flop."
  • Not listed, on code an earlier round reviewed: "Owner-signed CoinJoin spends always return UnsupportedSighash(0x81)" (suggestion): "note. The behaviour is intended but surprising. The comment at spend_authorization.rs:78-79 and the test at spend_authorization.rs:350 show the author chose to reject every mode other than SIGHASH_ALL, 0x81 included. The comment is accurate: 0x81 does not commit to the other inputs. The result is a typed error, so the caller keeps its hold rather than releasing it. The open question is whether Dash Core's CoinJoin client signing with 0x81 (dashpay/dash:src/coinjoin/client.cpp:595) means real wallet spends should be accepted, since every owner-signed CoinJoin spend lands on the error path."
  • Dropped: "No test covers high-S owner signatures since the normalization and its test were removed" (ignore): "ignore. The fix an earlier round asked for in P1 offered dropping the high-S test as an option, and the author took it. Asking for the test back reverses that answer. The behaviour the test pinned belongs to EcdsaPublicKey::verify in the crypto crate (crypto/src/ecdsa.rs:75), not to any line in this function. At most this would be a missing-test note, and a note that flip-flops on an earlier answer is not worth posting."

Timing:

  • Parse: 12.5s
  • Review agents: 209.1s
  • Judge: 71.2s
  • Total: 292.8s

Last reviewed 5e9a975 · head 5e9a975 · up to date

  • Pause automatic reviews
  • Review again
  • Deeper review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@manki-review manki-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved.

What this does: Adds a check that a transaction input carries a valid signature from the owner of the coin it spends, and that the signature covers the whole transaction. A wallet can use it to decide whether to reserve a coin before the spend is final.


What to test

The review model wrote these steps. Check what a step runs before you follow it.

Setup: Run the new tests with cargo test -p key-wallet --all-features --lib spend_authorization.

  1. Sign a one-input P2PKH spend with SIGHASH_ALL using the wallet's sign_tx and call verify_input_authorization with the funding output. Expect Ok(true).
  2. Change one output value of that signed transaction and verify again. Expect Ok(false).
  3. Pass a funding output that belongs to a different key. Expect Ok(false).
  4. Re-sign the input with SIGHASH_NONE (2) or SIGHASH_ALL|ANYONECANPAY (0x81). Expect Err(UnsupportedSighash(mode)).
  5. Overwrite only the last byte of a valid SIGHASH_ALL signature with 0x82, without re-signing. Expect Ok(false), not an error.
  6. Pass a funding output with an empty or P2SH script. Expect Err(UnsupportedScript).
  7. Edge case: build a transaction that lists the same outpoint twice and sign it properly. Expect Ok(false).
  8. Edge case: sign with SIGHASH_SINGLE on an input that has no matching output, then change lock_time. Expect Err(UnsupportedSighash(3)) both times.
About this review
  • Reviewed 5e9a975, round 3
  • 370 changed lines read in 4m 53s
  • Found by claude-sonnet-5-5 and claude-opus-5-5, judged by claude-opus-5-5
  • Tokens: 1.8M in (1.4M from cache) · 30k out · about $1.94 at API prices
  • Runner: self-hosted · started after 14s · peak memory 1.9 GiB of 30.0 GiB
  • How Manki reviews

@github-actions

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-self-review Waiting for the author to post /self-reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant