Skip to content

fix(dash-spv): detect forks with a full block locator - #1398

Open
ZocoLini wants to merge 3 commits into
devfrom
fix/stale-tip-fork
Open

ZocoLini wants to merge 3 commits into
devfrom
fix/stale-tip-fork

fix(dash-spv): keep stored header events on a failed locator refresh

1dd28bb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2026 in 1s

85.79% (+0.00%) compared to 6b985d1

View this Pull Request on Codecov

85.79% (+0.00%) compared to 6b985d1

Details

Codecov Report

❌ Patch coverage is 95.94595% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.79%. Comparing base (6b985d1) to head (1dd28bb).
⚠️ Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
dash-spv/src/sync/block_headers/manager.rs 93.18% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1398   +/-   ##
=======================================
  Coverage   85.78%   85.79%           
=======================================
  Files         269      269           
  Lines       70619    70643   +24     
=======================================
+ Hits        60582    60608   +26     
+ Misses      10037    10035    -2     
Files with missing lines Coverage Δ
dash-spv/src/network/mod.rs 97.14% <100.00%> (-0.23%) ⬇️
dash-spv/src/sync/block_headers/pipeline.rs 98.03% <100.00%> (+0.05%) ⬆️
dash-spv/src/sync/block_headers/segment_state.rs 98.89% <100.00%> (+0.01%) ⬆️
dash-spv/src/sync/block_headers/sync_manager.rs 92.85% <ø> (+7.14%) ⬆️
dash-spv/src/sync/filter_headers/manager.rs 96.70% <100.00%> (ø)
dash-spv/src/sync/block_headers/manager.rs 95.03% <93.18%> (+0.12%) ⬆️

... and 4 files with indirect coverage changes