Skip to content

refactor(key-wallet)!: simplify and encapsulate AddressPool - #1377

Open
ZocoLini wants to merge 22 commits into
devfrom
refactor/address-pool-next-unused-index
Open

ZocoLini wants to merge 22 commits into
devfrom
refactor/address-pool-next-unused-index

fix(key-wallet): reject index gaps in `AddressPool::insert`

850431f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2026 in 0s

86.02% (+0.38%) compared to ce3c27a

View this Pull Request on Codecov

86.02% (+0.38%) compared to ce3c27a

Details

Codecov Report

❌ Patch coverage is 82.92683% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.02%. Comparing base (ce3c27a) to head (850431f).
⚠️ Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
...wallet/src/transaction_checking/account_checker.rs 50.00% 31 Missing ⚠️
key-wallet/src/managed_account/address_pool.rs 94.17% 12 Missing ⚠️
.../src/managed_account/managed_core_funds_account.rs 20.00% 8 Missing ⚠️
...allet/src/managed_account/managed_account_trait.rs 71.42% 4 Missing ⚠️
key-wallet/src/wallet/managed_wallet_info/mod.rs 50.00% 4 Missing ⚠️
...et/src/managed_account/managed_platform_account.rs 25.00% 3 Missing ⚠️
...c/wallet/managed_wallet_info/asset_lock_builder.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1377      +/-   ##
==========================================
+ Coverage   85.64%   86.02%   +0.38%     
==========================================
  Files         268      267       -1     
  Lines       70110    69545     -565     
==========================================
- Hits        60043    59825     -218     
+ Misses      10067     9720     -347     
Files with missing lines Coverage Δ
dash-spv/src/sync/mempool/sync_manager.rs 99.52% <100.00%> (ø)
key-wallet-manager/src/events.rs 69.74% <ø> (-0.99%) ⬇️
key-wallet-manager/src/process_block.rs 93.54% <100.00%> (ø)
.../src/managed_account/managed_account_collection.rs 68.34% <ø> (ø)
...wallet/src/managed_account/managed_account_type.rs 82.82% <ø> (ø)
...-wallet/src/transaction_checking/wallet_checker.rs 99.34% <100.00%> (-0.01%) ⬇️
.../wallet/managed_wallet_info/transaction_builder.rs 94.18% <100.00%> (-0.02%) ⬇️
...wallet/managed_wallet_info/transaction_building.rs 95.50% <100.00%> (ø)
...c/wallet/managed_wallet_info/asset_lock_builder.rs 93.79% <90.00%> (-0.03%) ⬇️
...et/src/managed_account/managed_platform_account.rs 66.55% <25.00%> (+2.27%) ⬆️
... and 5 more

... and 8 files with indirect coverage changes