Repository navigation
fix(dash-spv): retry a refused request at another peer - #1374
Draft
xdustinface wants to merge 1 commit into
Draft
xdustinface wants to merge 1 commit into
xdustinface wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/peer-exploration #1374 +/- ##
========================================================
+ Coverage 81.11% 86.02% +4.91%
========================================================
Files 171 268 +97
Lines 46147 71820 +25673
========================================================
+ Hits 37430 61783 +24353
- Misses 8717 10037 +1320
|
xdustinface
force-pushed
the
fix/peer-exploration
branch
from
November 10, 2026 06:23
af7ed75 to
30b3af3
Compare
Contributor
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
xdustinface
force-pushed
the
fix/retry-refused-requests
branch
from
November 10, 2026 06:26
b58028c to
983e28b
Compare
xdustinface
force-pushed
the
fix/retry-refused-requests
branch
from
November 10, 2026 14:27
983e28b to
467c455
Compare
xdustinface
force-pushed
the
fix/peer-exploration
branch
from
November 10, 2026 14:27
30b3af3 to
259d131
Compare
Dash Core sends nothing for a `getcfheaders` or `getcfilters` whose range its filter index lacks, nor for a block it does not have. The byte charge of such a request stayed on the peer, a skipped `getcfilters` stopped every later filter batch of that peer from settling, and a skipped request at a busy peer never expired, since any answer refreshed all its requests. Once it did expire, the retry could go straight back to the same peer. A dev testnet run sent three filter header batches to three such peers 45 to 47 times each over 9 minutes. - Peers answer in request order, so a filter header, filter or block reply settles the charge of every earlier request of those kinds still awaited, and a `cfilter` settles the batch whose stop hash it carries. - Such a skipped request, one that expired without a kick and a block the peer sent `notfound` for are retried at a peer that did not refuse them in the last `REFUSAL_HELD` (10 s). - While every connected peer refused a queued request, the supervisor swaps the slowest one out through the existing swap path. - Refusals lapse, so a node whose index was only catching up, or a lone configured peer, is asked again.
xdustinface
force-pushed
the
fix/retry-refused-requests
branch
from
November 11, 2026 01:21
467c455 to
2bda02a
Compare
xdustinface
force-pushed
the
fix/peer-exploration
branch
from
November 11, 2026 01:21
259d131 to
9402114
Compare
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dash Core sends nothing for a
getcfheadersorgetcfilterswhose range its filter index lacks, nor for a block it does not have. The byte charge of such a request stayed on the peer, a skippedgetcfiltersstopped every later filter batch of that peer from settling, and the retry could go straight back to the same peer. A testnet run sent three filter header batches to such peers 45 to 47 times each over 9 minutes.Peers answer in request order, so a filter header, filter or block reply now settles the charge of every earlier request of those kinds still awaited. A skipped request, an expired one and a block the peer sent
notfoundfor are retried at a peer that has not refused them in the lastREFUSAL_HELD. While every connected peer refused a queued request, the supervisor swaps the slowest one out. Refusals lapse, so a node whose index was only catching up is asked again.Stacked on #1373, and will be retargeted to
devwhen that one merges.