Skip to content

fix(dash-spv): skip re-applying blocks on rescan - #1344

Merged
ZocoLini merged 4 commits into
devfrom
fix/rescan-reapplied-blocks
Nov 9, 2026
Merged

ZocoLini merged 4 commits into
devfrom
fix/rescan-reapplied-blocks

fix(dash-spv): let an untested element beat older scripts

3859390
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2026 in 0s

85.42% (+0.06%) compared to 451c6cc

View this Pull Request on Codecov

85.42% (+0.06%) compared to 451c6cc

Details

Codecov Report

❌ Patch coverage is 97.12794% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.42%. Comparing base (451c6cc) to head (3859390).

Files with missing lines Patch % Lines
dash-spv/src/sync/filters/manager.rs 96.53% 9 Missing ⚠️
dash-spv/src/sync/blocks/manager.rs 96.87% 1 Missing ⚠️
dash-spv/src/sync/filters/block_match_tracker.rs 98.76% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1344      +/-   ##
==========================================
+ Coverage   85.35%   85.42%   +0.06%     
==========================================
  Files         268      268              
  Lines       68948    69228     +280     
==========================================
+ Hits        58853    59135     +282     
+ Misses      10095    10093       -2     
Files with missing lines Coverage Δ
dash-spv/src/sync/events.rs 94.23% <ø> (ø)
dash-spv/src/sync/filters/batch.rs 97.63% <100.00%> (+0.01%) ⬆️
dash-spv/src/sync/filters/sync_manager.rs 100.00% <ø> (ø)
dash-spv/src/sync/blocks/manager.rs 95.49% <96.87%> (+0.09%) ⬆️
dash-spv/src/sync/filters/block_match_tracker.rs 99.51% <98.76%> (+0.15%) ⬆️
dash-spv/src/sync/filters/manager.rs 97.98% <96.53%> (-0.17%) ⬇️

... and 3 files with indirect coverage changes