Skip to content

fix(dash-spv)!: deliver only verified InstantLocks - #1336

Open
lklimek wants to merge 41 commits into
devfrom
fix/wallet-restore-authorization
Open

lklimek wants to merge 41 commits into
devfrom
fix/wallet-restore-authorization

test(dash-spv): check a foreign-type cycle without hand-set state

1818275
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 16, 2026 in 1s

85.99% (+0.07%) compared to 9ac4d8b

View this Pull Request on Codecov

85.99% (+0.07%) compared to 9ac4d8b

Details

Codecov Report

❌ Patch coverage is 99.24812% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.99%. Comparing base (9ac4d8b) to head (1818275).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
dash/src/ephemerealdata/instant_lock.rs 88.00% 3 Missing ⚠️
dash-spv/src/sync/instantsend/manager.rs 99.54% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1336      +/-   ##
==========================================
+ Coverage   85.92%   85.99%   +0.07%     
==========================================
  Files         269      269              
  Lines       70919    71303     +384     
==========================================
+ Hits        60935    61320     +385     
+ Misses       9984     9983       -1     
Files with missing lines Coverage Δ
dash-spv/src/client/queries.rs 54.00% <100.00%> (+10.09%) ⬆️
dash-spv/src/lib.rs 46.66% <ø> (ø)
dash-spv/src/network/costs.rs 95.95% <100.00%> (-0.05%) ⬇️
dash-spv/src/sml_engine.rs 97.73% <100.00%> (+0.06%) ⬆️
dash-spv/src/sync/events.rs 94.23% <100.00%> (-0.22%) ⬇️
dash-spv/src/sync/instantsend/sync_manager.rs 100.00% <100.00%> (ø)
dash-spv/src/sync/mempool/manager.rs 98.15% <100.00%> (+0.03%) ⬆️
dash-spv/src/sync/mempool/sync_manager.rs 99.53% <100.00%> (-0.01%) ⬇️
dash-spv/src/validation/instantlock.rs 99.19% <100.00%> (+4.88%) ⬆️
dash-spv/src/sync/instantsend/manager.rs 98.08% <99.54%> (+1.48%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes