Repository navigation
ci: stop dev PRs from editing the changelog #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Changelog Guard | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, edited, synchronize, reopened, labeled, unlabeled] | ||
| paths: | ||
| - '**/CHANGELOG.md' | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| changelog-guard: | ||
| # Every feature PR appending to the same changelog section conflicts with every other open PR. | ||
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'release') }} | ||
| runs-on: ${{ vars.DASH_LIGHT_RUNNER || 'ubuntu-latest' }} | ||
| steps: | ||
| - name: Reject changelog edits outside release PRs | ||
| run: | | ||
| echo "::error file=CHANGELOG.md::CHANGELOG.md is written when a release is cut. Revert the changelog edit, or add the 'release' label if this is a release PR." | ||
| exit 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: dashpay/rust-dashcore
Length of output: 4901
Script executed:
Repository: dashpay/rust-dashcore
Length of output: 22116
Script executed:
Repository: dashpay/rust-dashcore
Length of output: 6552
Register
Changelog Guardwith the review-label gate.validate-triggersscans all workflows with apull_request:trigger, including path-filtered workflows. It skips onlyready-for-review.yml, soChangelog Guardcauses validation to fail while it is absent fromworkflow_run.workflows.The label gate also has no completion trigger for
Changelog Guard. It can therefore leaveready-for-reviewstale when the guard finishes after the last evaluation, including after thereleaselabel is removed.Suggested fix
workflows: - "Continuous integration" - "Pre-commit Checks" - "Sanitizer" - "Ready for Review Trigger" + - "Changelog Guard"