Skip to content

feat(key-wallet)!: return zeroizing buffers from the mnemonic phrase and seed accessors - #1266

Merged
xdustinface merged 1 commit into
devfrom
pasta/zeroizing-seed-accessors
Nov 1, 2026
Merged

xdustinface merged 1 commit into
devfrom
pasta/zeroizing-seed-accessors

feat(key-wallet)!: return zeroizing buffers from the mnemonic phrase …

0a7943c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2026 in 0s

80.70% (+0.00%) compared to 6d291cd

View this Pull Request on Codecov

80.70% (+0.00%) compared to 6d291cd

Details

Codecov Report

❌ Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.70%. Comparing base (6d291cd) to head (0a7943c).

Files with missing lines Patch % Lines
key-wallet/src/account/derivation.rs 0.00% 2 Missing ⚠️
key-wallet/src/wallet/accounts.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1266   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files         291      291           
  Lines       77763    77782   +19     
=======================================
+ Hits        62755    62773   +18     
- Misses      15008    15009    +1     
Files with missing lines Coverage Δ
key-wallet-ffi/src/mnemonic.rs 46.45% <100.00%> (ø)
key-wallet/src/account/account_collection_test.rs 100.00% <100.00%> (ø)
key-wallet/src/account/mod.rs 64.43% <100.00%> (ø)
key-wallet/src/bip32.rs 85.65% <100.00%> (ø)
key-wallet/src/derivation.rs 74.60% <100.00%> (ø)
key-wallet/src/managed_account/address_pool.rs 79.65% <100.00%> (ø)
key-wallet/src/mnemonic.rs 98.53% <100.00%> (+0.03%) ⬆️
key-wallet/src/wallet/helper.rs 62.50% <100.00%> (ø)
key-wallet/src/wallet/initialization.rs 98.44% <100.00%> (ø)
key-wallet/src/wallet/accounts.rs 83.33% <85.71%> (-0.20%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes