Skip to content

fix(dash-spv)!: resolve masternode engine heights from the header storage - #1094

Merged
xdustinface merged 6 commits into
devfrom
fix/masternode-quorum-heights
Oct 7, 2026
Merged

xdustinface merged 6 commits into
devfrom
fix/masternode-quorum-heights

fix(dash-spv): reject malformed InstantLocks before looking up their …

cc66be0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2026 in 0s

77.51% (-0.47%) compared to 5628202

View this Pull Request on Codecov

77.51% (-0.47%) compared to 5628202

Details

Codecov Report

❌ Patch coverage is 96.81698% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.51%. Comparing base (5628202) to head (cc66be0).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
dash-spv/src/sml_engine.rs 97.79% 27 Missing ⚠️
...-spv/src/sml_engine/rotated_quorum_construction.rs 94.10% 22 Missing ⚠️
dash-spv/src/sml_engine/validation.rs 90.99% 10 Missing ⚠️
dash-spv/src/validation/instantlock.rs 94.56% 5 Missing ⚠️
dash-spv/src/sync/instantsend/manager.rs 90.69% 4 Missing ⚠️
dash-spv/src/client/core.rs 0.00% 2 Missing ⚠️
dash/src/sml/masternode_list/apply_diff.rs 97.67% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1094      +/-   ##
==========================================
- Coverage   77.98%   77.51%   -0.47%     
==========================================
  Files         320      319       -1     
  Lines       82245    81444     -801     
==========================================
- Hits        64136    63132    -1004     
- Misses      18109    18312     +203     
Files with missing lines Coverage Δ
dash-spv-ffi/src/client.rs 44.91% <ø> (+1.16%) ⬆️
dash-spv-ffi/src/platform_integration.rs 29.76% <ø> (+2.58%) ⬆️
dash-spv/src/client/lifecycle.rs 91.02% <100.00%> (+1.02%) ⬆️
dash-spv/src/client/queries.rs 43.54% <100.00%> (+10.85%) ⬆️
dash-spv/src/lib.rs 46.66% <ø> (ø)
dash-spv/src/sml_engine/helpers.rs 99.35% <100.00%> (ø)
dash-spv/src/storage/masternode.rs 99.54% <100.00%> (+<0.01%) ⬆️
dash-spv/src/storage/mod.rs 88.52% <ø> (+0.51%) ⬆️
dash-spv/src/sync/chainlock/manager.rs 95.72% <100.00%> (+0.30%) ⬆️
dash-spv/src/sync/events.rs 94.23% <ø> (ø)
... and 18 more

... and 48 files with indirect coverage changes