Skip to content

CI: Windows dashd_sync tests intermittently fail during node startup #903

Closed

Description

@thepastaclaw

Summary

The Windows dash-spv dashd_sync integration suite intermittently fails while starting its per-test Dash Core nodes. The failing test names vary, but the failure signature is consistent:

  • dashd failed to start within timeout at dash-spv/src/test_utils/node.rs:188
  • failed to create wallet 'default' ... Database already exists at dash-spv/src/test_utils/node.rs:265

Evidence

All corresponding Ubuntu, Ubuntu ARM, and macOS SPV jobs passed in both runs. The varying test names and repeated Windows-only startup/wallet failures indicate shared integration-test infrastructure flakiness rather than test assertions tied to either PR.

Reproduction

On a Windows runner, provision Dash Core and the regtest fixture with contrib/setup-dashd.py, then repeatedly run the suite with its default test concurrency:

cargo test -p dash-spv --test dashd_sync

The suite launches many independent Dash Core processes in parallel. Under the failing runs, some processes do not become ready within the fixed 30-second window, and one process reaches the load_wallet/create_wallet fallback after the default database path already exists.

Investigation notes

  • Capture/retain the failing node's dashd log on Windows; both referenced jobs reported no retained artifacts.
  • Check whether Windows runner resource pressure requires bounded integration-test concurrency or a longer readiness deadline.
  • Make ensure_wallet distinguish a missing wallet from transient load errors and an already-created database instead of treating every load_wallet error as permission to call create_wallet.

Activity

  1. thepastaclaw commented on Jul 23, 2026

    @thepastaclaw
    ContributorAuthor

    Follow-up from the duplicate CI alert for PR #901: the failure is still the same run/job already captured above (Windows / spv: https://github.com/dashpay/rust-dashcore/actions/runs/29502822011/job/87635842091), with two dashd failed to start within timeout failures and one default wallet database-already-exists failure in unchanged dash-spv test infrastructure.

    The dedicated harness fix is now in draft PR #904: #904. Its current Windows / spv job passes, along with the rest of the substantive matrix. PR #901 remains unchanged because its four-file diff is confined to key-wallet transaction routing/tests.

  2. added a commit that references this issue on Aug 3, 2026
    4959004
  3. added a commit that references this issue on Aug 6, 2026
    41835c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions