You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
dash-spv: a start with no new block overwrites the stored QRInfo, so the next start re-requests the work-block diffs #1109
Masternode messages are stored by tip height (qrinfo_<height>.dat). A start whose header tip equals the tip of the stored QRInfo (no block since the last run) requests a new QRInfo for that same tip. Its base is the list the stored QRInfo built, and storing it overwrites that QRInfo.
On the next start the replacement no longer applies, since the list it is based on is gone, and every diff built on its lists fails too. Those work-block diffs are requested again.
Mainnet CLI (--no-filters --no-mempool), same storage, restarted with no block in between:
Start
Replay
MnListDiffs requested
2
48/48
0 (overwrites qrinfo_2550299)
3
25/48 (Masternode message at 2550299 does not apply + 22 diffs)
22
4
49/49
0 (overwrites qrinfo_2550301)
It alternates on every start with no new block. Same on dev (5628202) and on #1094.
Possible fixes: do not store a QRInfo whose tip already has one stored, or skip the startup QRInfo when the replayed engine already holds the tip list.
The restart test in dashd_masternode/tests_sync.rs does not check that the second session requests no diffs, so it misses this.
Activity
fix(dash-spv): keep the stored QRInfo a same-tip QRInfo builds on
fix(dash-spv): keep the stored QRInfo a same-tip QRInfo builds on
fix(dash-spv): keep the stored QRInfo a same-tip QRInfo builds on
fix(dash-spv): keep the stored QRInfo a same-tip QRInfo builds on
test: cover the work-block requests and the fixes for #1109, #939 and #…
fix(dash-spv)!: resolve masternode engine heights from the header sto…