Skip to content

dash-spv: a start with no new block overwrites the stored QRInfo, so the next start re-requests the work-block diffs #1109

Closed

Description

@ZocoLini

Masternode messages are stored by tip height (qrinfo_<height>.dat). A start whose header tip equals the tip of the stored QRInfo (no block since the last run) requests a new QRInfo for that same tip. Its base is the list the stored QRInfo built, and storing it overwrites that QRInfo.

On the next start the replacement no longer applies, since the list it is based on is gone, and every diff built on its lists fails too. Those work-block diffs are requested again.

Mainnet CLI (--no-filters --no-mempool), same storage, restarted with no block in between:

Start Replay MnListDiffs requested
2 48/48 0 (overwrites qrinfo_2550299)
3 25/48 (Masternode message at 2550299 does not apply + 22 diffs) 22
4 49/49 0 (overwrites qrinfo_2550301)

It alternates on every start with no new block. Same on dev (5628202) and on #1094.

Possible fixes: do not store a QRInfo whose tip already has one stored, or skip the startup QRInfo when the replayed engine already holds the tip list.

The restart test in dashd_masternode/tests_sync.rs does not check that the second session requests no diffs, so it misses this.

Activity

  1. added 5 commits that reference this issue on Oct 5, 2026
    9253b71
    33e67ae
    49a4439
    9826534
    86d722e
  2. added a commit that references this issue on Oct 7, 2026
    c5a9b94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions