Repository navigation
chore: update rust-dashcore dependency to store TransactionContext in TransactionRecord #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,12 +5,12 @@ edition = "2021" | |
|
|
||
| [dependencies] | ||
| # dash-sdk = { git = "https://github.com/dashpay/platform", tag = "v1.8.0" } | ||
| dashcore = { git = "https://github.com/dashpay/rust-dashcore", tag = "v0.40.0", default-features = false, features = [ | ||
| dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "5114330ae564858803d656efba84bb4adacb2a2e", default-features = false, features = [ | ||
| "std", | ||
| "secp-recovery", | ||
| "bincode", | ||
| ] } | ||
| dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", tag = "v0.40.0" } | ||
| dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "5114330ae564858803d656efba84bb4adacb2a2e" } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Blocking: Update Cargo.lock alongside the Git dependency pointers Cargo.lock is unchanged and still records dashcore, dashcore-rpc, and their workspace dependencies from source: ['claude'] |
||
| crossbeam-channel = "0.5.13" | ||
| futures = "0.3.31" | ||
| serde = { version = "1.0.217", features = ["derive"] } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Adapt the manifest requirements to the selected upstream revision
Revision 5114330 provides dashcore 0.42.0, which no longer defines the requested
stdfeature. Consequently, locked build, test, and Clippy commands fail during dependency resolution, before validating the upstream refactor. Removing onlystdexposes a second manifest incompatibility: dashcore requires bincode and bincode_derive^2.0.1, and dashcore-rpc-json also requires bincode^2.0.1, while this application pins both codec packages to=2.0.0-rc.3at lines 19–20. Cargo rejects that graph as well. Remove the obsolete feature and align both codec pins with the selected revision, or remove the unused direct codec dependencies, so this integration can reach compilation.source: ['claude']