Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ edition = "2021"

[dependencies]
# dash-sdk = { git = "https://github.com/dashpay/platform", tag = "v1.8.0" }
dashcore = { git = "https://github.com/dashpay/rust-dashcore", tag = "v0.40.0", default-features = false, features = [
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "5114330ae564858803d656efba84bb4adacb2a2e", default-features = false, features = [
"std",
"secp-recovery",
"bincode",
] }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", tag = "v0.40.0" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "5114330ae564858803d656efba84bb4adacb2a2e" }
Comment on lines +8 to +13

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blocking: Adapt the manifest requirements to the selected upstream revision

Revision 5114330 provides dashcore 0.42.0, which no longer defines the requested std feature. Consequently, locked build, test, and Clippy commands fail during dependency resolution, before validating the upstream refactor. Removing only std exposes a second manifest incompatibility: dashcore requires bincode and bincode_derive ^2.0.1, and dashcore-rpc-json also requires bincode ^2.0.1, while this application pins both codec packages to =2.0.0-rc.3 at lines 19–20. Cargo rejects that graph as well. Remove the obsolete feature and align both codec pins with the selected revision, or remove the unused direct codec dependencies, so this integration can reach compilation.

source: ['claude']

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blocking: Update Cargo.lock alongside the Git dependency pointers

Cargo.lock is unchanged and still records dashcore, dashcore-rpc, and their workspace dependencies from ?tag=v0.40.0#c877c1a74d145e2003d549619698511513db925c, rather than the selected revision. After correcting the feature and codec requirements in an isolated copy, cargo build --locked --offline independently fails because the lockfile needs updating. This also blocks the Dockerfile's cargo build --release --locked step. Regenerate and include Cargo.lock with the compatible manifest, then rerun the locked validation commands.

source: ['claude']

crossbeam-channel = "0.5.13"
futures = "0.3.31"
serde = { version = "1.0.217", features = ["derive"] }
Expand Down