Repository navigation
chore(deps): update Rust dependencies #5948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5.1-dev
Are you sure you want to change the base?
Changes from all commits
e4ee74e
cbdcf0c
822d6e7
458aab0
297da5e
b19d3e9
89d32c9
15e328e
2c151a3
fe06f11
6eed0ba
f551eaf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -593,6 +593,35 @@ fn should_accept_an_ordinary_format_regex_value_at_both_protocol_versions() { | |
| assert!(format_regex_errors(value, protocol_version_14).is_empty()); | ||
| } | ||
|
|
||
| /// Validation errors for a document `{ "u": value }` against a type whose `u` is a | ||
| /// `format: uri` string, at `platform_version`. The contract is registered then read anew, | ||
| /// so the protocol version decides which validator checks the value. | ||
| fn format_uri_errors(value: &str, platform_version: &PlatformVersion) -> Vec<ConsensusError> { | ||
| let contract = item_contract(platform_value!({ | ||
| "u": { "type": "string", "format": "uri", "maxLength": 40, "position": 0 }, | ||
| })); | ||
| document_errors( | ||
| &read_anew(&contract), | ||
| platform_value!({ "u": value }), | ||
| platform_version, | ||
| ) | ||
| } | ||
|
|
||
| /// Pins consensus to the Unicode 17 ICU data behind `url`'s IDNA host mapping: U+0558 is | ||
| /// unassigned there, so a host holding it is not a URI. A failure means a dependency update | ||
| /// changed consensus. | ||
| #[test] | ||
| fn should_refuse_a_format_uri_value_whose_host_holds_a_code_point_unassigned_in_unicode_17() { | ||
| let latest = PlatformVersion::latest(); | ||
| let protocol_version_14 = PlatformVersion::get(14).expect("expected protocol version 14"); | ||
| let value = "https://a\u{0558}b.com/"; | ||
| assert!(!format_uri_errors(value, latest).is_empty()); | ||
| assert!(!format_uri_errors(value, protocol_version_14).is_empty()); | ||
| // An ASCII host is a URI at both protocol versions. | ||
| assert!(format_uri_errors("https://ab.com/", latest).is_empty()); | ||
| assert!(format_uri_errors("https://ab.com/", protocol_version_14).is_empty()); | ||
| } | ||
|
Comment on lines
+610
to
+623
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Suggestion: Add a regression test for schema metadata URI validation The added guard exercises only a document property with source: |
||
|
|
||
| /// A pattern that parses but that the `regex` crate does not compile under its default size | ||
| /// limit. | ||
| const PATTERN_BEYOND_THE_SIZE_LIMIT: &str = "^\\p{L}{400}$"; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Suggestion: The ICU pin does not freeze the complete behavior dependency graph
The four exact ICU pins constrain the normalizer and property data packages, but their manifests still allow supporting packages such as
icu_provider,icu_locale_core,zerovec,litemap, and related crates to move within their compatible ranges. The current lockfile resolves those packages to 2.2.0, but a later lockfile refresh can change them without changing any of the four exact pins. Since these packages implement data-provider and normalization support behavior used by the URL/IDNA path, the manifest does not fully establish the stated consensus freeze. Pin the complete relevant ICU closure, or document why each remaining floating package cannot affect the URI verdict and extend the guard if needed.source:
muse-spark-1.3-contributor(phase1-reviewer: general, rust-quality)