Skip to content

style(drive-abci): fix the formatting that fails every v5.1-dev PR - #5932

Open
PastaPastaPasta wants to merge 1 commit into
v5.1-devfrom
fix/fmt-is-allowed-tradeable-doc
Open

PastaPastaPasta wants to merge 1 commit into
v5.1-devfrom
fix/fmt-is-allowed-tradeable-doc

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

#5910 left two doc-comment lines in is_allowed.rs unindented. The Rust workspace "Check formatting" step now fails on v5.1-dev and on every PR into it, because CI checks the merge with the base.

What was done?

Ran rustfmt on the file. Only the indentation of those two comment lines changes.

How Has This Been Tested?

cargo fmt --all -- --check passes on this branch.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · 0cba952

  • Bots — thepastaclaw ✓
  • Self-review — posted; again after any push
  • Reviewer requests paused — your 5 review slots are occupied; this PR is excluded from reviewers' queues. Required approvals still count without a slot.
  • Build green
  • Approvals
    • rs-drive-abci (packages/rs-drive-abci/src/execution/validation/state_transition/processor/traits/is_allowed.rs) — QuantumExplorer or shumkov

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • Style
    • Re-indented comments describing protocol versions that reject tradeable tokens. No behavior changed.

#5910 left two doc-comment lines unindented, so the Rust workspace
"Check formatting" step fails on v5.1-dev and on every PR into it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v5.1.0 milestone Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 14, 2026
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Two comments about protocol versions that reject tradeable tokens were re-indented. No behavior changed.

Changes: Comment formatting

Layer / File(s) Summary
Protocol-version comment indentation
packages/rs-drive-abci/src/execution/validation/state_transition/processor/traits/is_allowed.rs
Two comments were re-indented. Their text is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: quantumexplorer

Merge Risk: Minimal · up to 0cba9

This is a whitespace-only change to comments that fixes a formatting check failure. It has no runtime impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names a style fix in drive-abci, and the raw summary confirms the only change is re-indenting two comment lines in is_allowed.rs. The title is related to the change and specific about the fo…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names a style fix in drive-abci, and the raw summary confirms the only change is re-indenting two comment lines in is_allowed.rs. The title is related to the change and specific about the formatting fix. It does not name the file or the comment-only nature, but it is not misleading or off-topic. The 'style(drive-abci):' prefix follows conventional commits. The phrase 'every v5.1-dev PR' is a broad claim taken from the objectives, not from the diff itself, but it describes the motivation accurately.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between adfa029 and 0cba952.

Files selected for processing: 1

  • packages/rs-drive-abci/src/execution/validation/state_transition/processor/traits/is_allowed.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@thepastaclaw

thepastaclaw commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — Phase 1 only — no blockers (commit 0cba952) · triage: trivial

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review — Phase 1 only (trivial change)

The PR contains only a two-line indentation correction for doc comments inside a test module. The exact diff is limited to is_allowed.rs, introduces no code or behavior changes, and the reported Rust workspace check passed on the reviewed head.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: architecture-layering); reviewer 3: glm-5.3-flash (agent: phase1-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

  • Triage: trivial by gpt-6.1-sol (effort low) — This change only re-indents two doc-comment lines in a single Rust file and does not alter behavior, logic, or configuration.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — architecture-layering (completed, effort high); agent phase1-reviewer, glm-5.3-flash — rust-quality (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 100% left, weekly 52% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
  • Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves

@github-actions

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 14, 2026
@PastaPastaPasta

Copy link
Copy Markdown
Member Author

/self-reviewed 0cba952

@github-actions

Copy link
Copy Markdown
Contributor

Missing human approval. Automatic reviewer requests are paused and this PR is excluded from reviewers' queues. Merge, close, or draft another active PR by this author to free a review slot. Required human review can be satisfied without a slot; once all merge requirements are met, PR Hygiene passes.
Full checklist in the description.

@github-actions github-actions Bot added too-many-open-prs Beyond the author's 5 open PRs; waits for one to merge before a human is asked. and removed waiting-self-review Waiting for the author to post /self-reviewed labels Nov 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

too-many-open-prs Beyond the author's 5 open PRs; waits for one to merge before a human is asked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants