Repository navigation
feat(platform-wallet): top up someone else's identity from the Core balance #5931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HashEngineering
wants to merge
10
commits into
v5.2-dev
Choose a base branch
from
HashEngineering/platform-wallet-top-up-someone-elses-identity-fr
base: v5.2-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5850435
feat(platform-wallet): record the identity an unbound top-up lock pays
HashEngineering da658bd
feat(platform-wallet): top up someone else's identity from the Core b…
HashEngineering 170b0be
refactor(platform-wallet): simplify the identity top-up recipient code
HashEngineering a42ef7e
fix(platform-wallet): check and keep an assigned top-up recipient, fl…
HashEngineering ae9f3b8
fix(platform-wallet): address the #5924 plan review in the Core top-u…
HashEngineering 3b30b1e
fix(platform-wallet): keep inputs reserved when an abandoned lock row…
HashEngineering 282c6df
fix(platform-wallet): send asset locks only on the live wallet, keep …
HashEngineering 6c3548a
fix(platform-wallet): remove an unsent lock of a replaced wallet, gat…
HashEngineering 93c61ac
fix(platform-wallet): build asset locks only on the handle's wallet, …
HashEngineering 4cb8c71
fix(platform-wallet): keep an unsent lock of a replaced wallet that a…
HashEngineering File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Tracked-lock array element strides changed without ABI negotiation
TrackedAssetLockFFIis returned as a contiguous bare-pointer array byasset_lock_manager_list_tracked_locks, andTrackedAssetLockEntryFFIis returned the same way byplatform_wallet_tracked_asset_locks_list. Appending the identity-recipient fields changessizeofand therefore the element stride. A host compiled against the previous header will index the second and later elements using the old stride, reading fields from the middle of the newer elements and potentially displaying or resuming the wrong lock. The paired free functions receive only the pointer and count, so they cannot recover the stride. The size-gated persistence extension does not protect these arrays. Preserve the existing V1 element types and add V2 list functions, or add explicit element-size/ABI negotiation.source:
gpt-6.1-sol(phase2-reviewer: general, architecture-layering, ffi-engineer, platform-versioning, rust-quality, security-auditor)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining, as on #5762 (#5762 (comment), withdrawn there):
TrackedAssetLockFFIandTrackedAssetLockEntryFFIhave no layout freeze or size negotiation, they are not part of the published persistence ABI, and their only consumers are the Swift and Kotlin SDKs built from this tree against the generated header. The appended fields are listed under Breaking Changes in the PR description.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Withdrawn (re-reviewed at
282c6df7): The stated release model is sufficient for this diagnostic surface: it is not a frozen published persistence ABI, its supported Swift and Kotlin consumers rebuild against the new header, and the appended fields are explicitly called out as a host-breaking change. The separate persistence row remains size-gated.