Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
23a55c0
fix(platform-wallet): keep contact request holds consistent after an …
QuantumExplorer Nov 13, 2026
2d7c3ee
fix(platform-wallet): close the review's gaps in the contact request …
QuantumExplorer Nov 13, 2026
974c9da
fix(platform-wallet): settle a held request once, and count every flu…
QuantumExplorer Nov 13, 2026
a7157ff
fix(platform-wallet): pay for a private request only once its marker …
QuantumExplorer Nov 13, 2026
143d4bd
fix(platform-wallet): count transient flush failures, and keep a newe…
QuantumExplorer Nov 13, 2026
901eeec
fix(platform-wallet): record a flush whose backend panics as lost
QuantumExplorer Nov 13, 2026
3ad292d
fix(platform-wallet): certify the manager's backfill flush, and fence…
QuantumExplorer Nov 13, 2026
9aa9a1b
fix(platform-wallet): forget stored private markers once any flush of…
QuantumExplorer Nov 14, 2026
76c5630
fix(platform-wallet): keep a newer tracked request when an older one …
QuantumExplorer Nov 14, 2026
67945bb
refactor(platform-wallet): keep the order of a pair's sent requests i…
QuantumExplorer Nov 15, 2026
b260047
fix(platform-wallet): keep a backend's flush ledgers with the backend…
QuantumExplorer Nov 15, 2026
1e40bd8
fix(platform-wallet): let the backend own its flush ledgers, and neve…
QuantumExplorer Nov 15, 2026
81d9151
test(platform-wallet): show that backends of zero-sized types have th…
QuantumExplorer Nov 15, 2026
4116484
fix(platform-wallet): raise the private payment hold only between rep…
QuantumExplorer Nov 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,10 @@ sealed class DashSdkError(
* DashPay sync settles it (the request found: recorded as sent; its
* nonce proved used: the pair freed), and
* `Dashpay.publicContactRequestsUnconfirmed` reads whether it still
* stands. Not a private request pending ([PrivateContactRequestPending]).
* stands. Also thrown by a public send or accept made while another
* public request to that identity is being sent: one is sent at a
* time, and nothing is signed for the second. Not a private request
* pending ([PrivateContactRequestPending]).
* ← Swift `PlatformWalletError.publicContactRequestUnconfirmed`.
*/
class PublicContactRequestUnconfirmed(message: String, cause: Throwable? = null) :
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,9 @@ class Dashpay internal constructor(private val walletHandle: Long,
* a host shows the pair as unconfirmed and offers neither. A DashPay sync
* settles it: a request found is recorded as sent, a nonce proved used
* frees the pair, and otherwise the same signed bytes are broadcast
* again. Read it beside [privateRepliesPending]. Empty when the identity
* again only while the wallet's tracked state still allows a public
* request to the contact; a private send never broadcasts them again.
* Read it beside [privateRepliesPending]. Empty when the identity
* isn't managed.
* ← Swift `ManagedPlatformWallet.publicContactRequestUnconfirmed(senderId:recipientId:)`
* (packages/swift-sdk/Sources/SwiftDashSDK/PlatformWallet/PrivateContactRequests.swift).
Expand Down
2 changes: 1 addition & 1 deletion packages/rs-platform-wallet-ffi/ERROR_CODE_REGISTRY.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ Fork-era numbers remain in the collision history, which is immutable record.
| 73 | `ErrorPrivateContactRecoveryUnsupported` | DashPay private contact requests | Proposed. Maps `PlatformWalletError::PrivateContactRecoveryUnsupported`: the persister does not declare `PRIVATE_CONTACT_REQUEST_SCAN_STATE` (bit 15) together with `ATOMIC_CHANGESETS` (bit 0, with the changeset begin and end callbacks wired), so the private send, the private accept and the in-kind accept's private reply are refused before anything is sealed or paid. The payment's recovery marker could not survive a restart, and a process reopening the wallet without the `shielded` feature, or before the shielded store is configured, could publish the pair while the payment may still execute. Not retryable as it is: a host that persists the private contact request scan state in changesets it commits whole declares both. The FFI constant is `PLATFORM_WALLET_PERSISTENCE_CAPABILITY_PRIVATE_CONTACT_REQUEST_SCAN_STATE` (`1 << 15`). Swift types it (`PlatformWalletError.privateContactRecoveryUnsupported`, `ErrorHandlingTests` pin), SwiftExampleApp shows it as a storage configuration error, and the SwiftData handler declares bit 0 and bit 15 with the begin and end callbacks wired; Kotlin types it (`DashSdkError.PlatformWallet.PrivateContactRecoveryUnsupported`, `DashSdkErrorTest` pin), KotlinExampleApp shows it as a storage configuration error, and the Room handler declares bit 0 and bit 15 with the begin and end callbacks wired |
| 74 | `ErrorPrivateContactStoreNotRead` | DashPay private contact requests | Proposed. Maps `PlatformWalletError::PrivateContactStoreNotRead`: DashPay's private contact request store was not read to its end for the identity, with the keys Platform proves it holds, before a contact request or acceptance, public or private, was decided (every one reads it from the identity's cursor first). Nothing was reserved, sealed, paid or broadcast; calling again continues the read from where it stopped. A node behind the store already seen, or keys that kept changing, stop it. It was reported as 71 before, which says not to submit again. Mapped by the blanket conversion and kept by the shielded spend contract (`map_spend_result`). Swift types it (`PlatformWalletError.privateContactStoreNotRead`, `ErrorHandlingTests` pin) and SwiftExampleApp offers a retry with no pending row; Kotlin types it (`DashSdkError.PlatformWallet.PrivateContactStoreNotRead`, `DashSdkErrorTest` pin) and KotlinExampleApp offers a retry with no pending row |
| 75 | `ErrorSdkPinnedBelowProtocolVersion` | DashPay private contact requests | Proposed. The SDK refused a request without sending it because the SDK itself is pinned below the protocol version the request needs (`dash_sdk::Error::ProtocolVersionNotActive` with `pinned`), whatever the network runs: for example every contact request's private store read with the SDK pinned below protocol version 15 on a network at 15. A network upgrade does not lift it; only raising or removing the pin does. Before, it shared 70 with a network proven below the version, which lifts by itself. Mapped by the blanket conversion. Swift types it (`PlatformWalletError.sdkPinnedBelowProtocolVersion`, `ErrorHandlingTests` pin) and SwiftExampleApp shows a developer-facing message; Kotlin types it (`DashSdkError.PlatformWallet.SdkPinnedBelowProtocolVersion`, `DashSdkErrorTest` pin) and KotlinExampleApp shows a developer-facing message |
| 76 | `ErrorPublicContactRequestUnconfirmed` | DashPay private contact requests | Proposed. Maps `PlatformWalletError::PublicContactRequestUnconfirmed`: a public contact request to that identity was broadcast and may have been delivered, and no proof settled its outcome yet, so the wallet holds the pair and signs nothing new to it, public or private. The send or accept that broadcast it reported 20; every later one is refused with 76 until a public contact request sync settles it (its document proved on Platform: recorded as sent; its transition proved unable to write it: the pair freed), broadcasting the same signed bytes again meanwhile. Not a private request pending (71). Mapped by the blanket conversion and by `map_spend_result`. `platform_wallet_get_public_contact_request_unconfirmed` reads the hold per pair (`DashPayView::public_contact_request_unconfirmed`; 7 for a sender the wallet does not hold). Swift types it (`PlatformWalletError.publicContactRequestUnconfirmed`, `ErrorHandlingTests` pin) and wraps the read (`ManagedPlatformWallet.publicContactRequestUnconfirmed`); SwiftExampleApp shows the pair as being checked, with no request or accept offered, until the read says settled, and its refreshes run the DashPay sync that settles it; Kotlin types it (`DashSdkError.PlatformWallet.PublicContactRequestUnconfirmed`, `DashSdkErrorTest` pin), bridges the read (`DashpayNative.publicContactRequestUnconfirmed`, `Dashpay.publicContactRequestsUnconfirmed`), and KotlinExampleApp shows the pair as SwiftExampleApp does |
| 76 | `ErrorPublicContactRequestUnconfirmed` | DashPay private contact requests | Proposed. Maps `PlatformWalletError::PublicContactRequestUnconfirmed`: a public contact request to that identity was broadcast and may have been delivered, and no proof settled its outcome yet, so the wallet holds the pair and signs nothing new to it, public or private. The send or accept that broadcast it reported 20; every later one is refused with 76 until a public contact request sync settles it (its document proved on Platform: recorded as sent; its transition proved unable to write it: the pair freed), broadcasting the same signed bytes again meanwhile where a public request to that identity would still go out (not once the pair is held or tracked as private, and never from a private send). Also what a public send or accept gets while another public request to that identity is being sent: one public send holds a pair at a time, and the per-pair read below does not report that one. Not a private request pending (71). Mapped by the blanket conversion and by `map_spend_result`. `platform_wallet_get_public_contact_request_unconfirmed` reads the hold per pair (`DashPayView::public_contact_request_unconfirmed`; 7 for a sender the wallet does not hold). Swift types it (`PlatformWalletError.publicContactRequestUnconfirmed`, `ErrorHandlingTests` pin) and wraps the read (`ManagedPlatformWallet.publicContactRequestUnconfirmed`); SwiftExampleApp shows the pair as being checked, with no request or accept offered, until the read says settled, and its refreshes run the DashPay sync that settles it; Kotlin types it (`DashSdkError.PlatformWallet.PublicContactRequestUnconfirmed`, `DashSdkErrorTest` pin), bridges the read (`DashpayNative.publicContactRequestUnconfirmed`, `Dashpay.publicContactRequestsUnconfirmed`), and KotlinExampleApp shows the pair as SwiftExampleApp does |

**Code 31 left this table on 2026-08-04.** `ErrorSigningKeyUnavailable` sat here
as #4183's proposal until #4183 merged (`189a3abb1c`); it is now in the merged
Expand Down
3 changes: 3 additions & 0 deletions packages/rs-platform-wallet-ffi/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,9 @@ pub enum PlatformWalletFFIResultCode {
/// failed: do not submit it again. A public contact request sync settles
/// it, recording the request once its document is proved on Platform and
/// freeing the pair once its transition is proved unable to write it.
/// Also what a public send or accept gets while another public request
/// to that identity is being sent: one public request to an identity is
/// sent at a time, and nothing is signed for the second.
/// A private request pending to the identity is
/// [`Self::ErrorPrivateContactRequestPending`] (71).
ErrorPublicContactRequestUnconfirmed = 76,
Expand Down
Loading
Loading