Repository navigation
feat(platform)!: dashpay contact requests carry an encrypted shielded address (PV15) #5892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QuantumExplorer
merged 8 commits into
v5.1-dev
from
claude/dashpay-v3-encrypted-shielded-address
Nov 12, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
05d0167
feat(platform)!: dashpay contact requests carry an encrypted shielded…
QuantumExplorer 3fe572f
test(platform): cover the contact request's shielded address and move…
QuantumExplorer f3d4bb8
Merge remote-tracking branch 'origin/v5.1-dev' into claude/dashpay-v3…
QuantumExplorer f1dbeb2
test(dpp): store DashPay v3 with its shielded address in the stored c…
QuantumExplorer b05c943
Merge remote-tracking branch 'origin/v5.1-dev' into claude/dashpay-v3…
QuantumExplorer cfc246d
docs(platform): say that consensus accepts an 80-byte shielded addres…
QuantumExplorer 1535eb5
Merge remote-tracking branch 'origin/v5.1-dev' into claude/dashpay-v3…
QuantumExplorer 71ecfc2
docs(platform): describe 64 bytes as the current encoding of the shie…
QuantumExplorer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Suggestion: Describe 64 bytes as the wallet encoding, not the only valid length
This section says
encryptedShieldedAddressis exactly 64 bytes, but the next paragraph and the schema accept both 64-byte and 80-byte ciphertexts. Readers implementing a wallet or SDK could therefore reject a consensus-valid 80-byte value. Describe 64 bytes as the current wallet encoding while retaining the subsequent explanation that consensus accepts 64 or 80 bytes.source:
gpt-6.1-sol(phase2-reviewer: general, architecture-layering, platform-versioning, rust-quality)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved (re-reviewed at
71ecfc28): Your change in 71ecfc2 resolves this: the book now distinguishes the current 64-byte wallet encoding from both accepted ciphertext lengths and tells readers to ignore an undecodable value rather than refuse the contact request.