Repository navigation
docs(dashmate): describe how a DKG-safe stop decides - #5878
Conversation
Adds a reference page for maintainers: why stopping a masternode during a DKG risks a PoSe penalty, the blockers dashmate derives from Core's DKG data, what each Core version (23, 24.0, 24.1+) provides, how Core is read consistently (syncing Core, reorgs), the confirmation on Core older than 24.1, plain stop versus --safe and what --safe remembers, the progress estimate, known limits, and which file does what. Linked from the docs index and the stop command page. Documentation only, no behaviour change, so no test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The comment on reading a syncing Core said Core stays in initial block download only while connecting blocks over 6 hours old. A reindexing Core stays in it whatever the age of its blocks, so a syncing Core is usually, not always, catching up on DKGs the network ran long ago. Comment only, no behaviour change, so no test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.
Commit e9fbf0c. Normal review starts when eligible; priority review starts as soon as a slot is available. |
Issue being fixed or feature implemented
The DKG-safe stop shipped in #5841, #5842 and #5843 has no maintainer documentation. Operators have the
stopcommand page; what dashmate checks, why, and which Dash Core behaviour it relies on lived only in a working design doc and in review threads.What was done?
packages/dashmate/docs/specs/dkg-safe-stop.md, describing the merged behaviour:upcoming,imminent,session,new-round,unrecorded,active-count,unreadable) and the Core data each comes from;getnetworkinfo;--safe, what--saferemembers and when it gives up, and the local-network exemption;stoppage's "Stopping a masternode safely" section.checkMasternodeSafeToStop.jsno longer says a syncing Core only connects blocks over 6 hours old: a reindexing Core stays in initial block download whatever the age of its blocks.How Has This Been Tested?
Documentation and a comment only. Every claim on the page was checked by two independent reviews: one against dashmate's code at the merge of #5843, one against Dash Core's source (v24.0.0 and
developat 24.1.0). Their corrections are folded in.eslintpasses on the changed JS file.Breaking Changes
None.
Checklist:
structure.rs, regeneratedgrovedb-structure.json, and checked the structure viewer link posted on this pull requestFor repository code-owners and collaborators only
🤖 Generated with Claude Code
PR Hygiene ·
e9fbf0c/skip-botsproceeds without the ones not yet reported/self-reviewedWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.Summary by CodeRabbit
--safewaits, and how behavior varies by Core version.