Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9803ab6
feat(platform-wallet): top up an identity the wallet does not manage …
romchornyi Nov 11, 2026
b1b7129
feat(swift-sdk): topUpExternalIdentityFromAddresses
romchornyi Nov 11, 2026
2271e8c
fix(platform-wallet): fence the external identity top-up and own the …
romchornyi Nov 11, 2026
77c2161
fix(platform-wallet-ffi): release the wallet registry before waiting …
romchornyi Nov 12, 2026
a982205
fix(platform-wallet): keep the external identity top-up behind the ga…
romchornyi Nov 12, 2026
a31d6dc
Merge remote-tracking branch 'origin/v5.1-dev' into feat/platform-wal…
romchornyi Nov 13, 2026
ccf95e5
fix(platform-wallet): report a failed recipient lookup in the externa…
romchornyi Nov 13, 2026
a08f7ff
fix(platform-wallet-ffi): number the identity lookup failure 80, clea…
romchornyi Nov 13, 2026
091026e
fix(platform-wallet): do not report an address top-up as done from an…
romchornyi Nov 13, 2026
3cfd952
fix(platform-wallet-ffi): turn a panic in the address top-up exports …
romchornyi Nov 13, 2026
df3000a
fix(platform-wallet): keep unpromoted SDK errors in the address top-up
romchornyi Nov 13, 2026
4642808
fix(kotlin-sdk): mark a failed identity lookup as retryable
romchornyi Nov 13, 2026
69ffa84
fix(platform-wallet): report an address top-up whose identity balance…
romchornyi Nov 13, 2026
9470844
fix(swift-sdk): pin the wallet across the address top-up export call
romchornyi Nov 13, 2026
d448bb9
fix(platform-wallet): fence the managed address top-up against wallet…
romchornyi Nov 13, 2026
12b698e
fix(platform-wallet): refuse an address top-up without funding rows b…
romchornyi Nov 13, 2026
d41a053
fix(platform-wallet): measure a managed address top-up against Platfo…
romchornyi Nov 13, 2026
bb2e0f2
docs(platform-wallet): state the balance-growth condition of an uncon…
romchornyi Nov 13, 2026
8089a7e
docs(platform-wallet): state the residual limit of binding a top-up p…
romchornyi Nov 13, 2026
2ce86e8
fix(platform-wallet): keep the managed address top-up behind the life…
romchornyi Nov 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions docs/sdk/sdk-parity-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"platform_wallet_token_purchase": "packages/rs-platform-wallet-ffi/src/tokens/purchase.rs",
"platform_wallet_token_transfer": "packages/rs-platform-wallet-ffi/src/tokens/transfer.rs",
"platform_wallet_token_update_config": "packages/rs-platform-wallet-ffi/src/tokens/update_config.rs",
"platform_wallet_top_up_external_identity_from_addresses_with_signer": "packages/rs-platform-wallet-ffi/src/identity_top_up.rs",
"platform_wallet_top_up_from_addresses_with_signer": "packages/rs-platform-wallet-ffi/src/identity_top_up.rs",
"platform_wallet_topup_identity_with_existing_asset_lock_signer": "packages/rs-platform-wallet-ffi/src/identity_registration_funded_with_signer.rs",
"platform_wallet_tracked_asset_locks_free": "packages/rs-platform-wallet-ffi/src/manager_diagnostics.rs",
Expand Down Expand Up @@ -1468,6 +1469,39 @@
}
]
},
{
"id": "identity.external_top_up_from_addresses",
"title": "Top up an identity the wallet does not manage from Platform addresses",
"area": "correctness",
"shared_apis": [
"platform_wallet_top_up_external_identity_from_addresses_with_signer"
],
"required_persistence_capabilities": [],
"hosts": {
"swift": {
"sdk": "supported",
"example_app": "unsupported",
"restart": "not_applicable",
"reason": "ManagedPlatformWallet.topUpExternalIdentityFromAddresses bridges the export; the example app has no screen that pays to someone else's identity."
},
"kotlin": {
"sdk": "unsupported",
"example_app": "unsupported",
"restart": "not_applicable",
"reason": "No JNI bridge or Kotlin wrapper for the external identity top-up yet."
}
},
"verification": [
{
"host": "swift",
"kind": "unit",
"file": "packages/swift-sdk/SwiftTests/SwiftDashSDKTests/ExternalIdentityTopUpTests.swift",
"id": "testMarshalsArgumentsAndReturnsTheBalanceTheExportWrites",
"command": "cd packages/swift-sdk && xcodebuild test -scheme SwiftDashSDK -destination 'platform=iOS Simulator,name=iPhone 17 Pro' -only-testing:SwiftDashSDKTests/ExternalIdentityTopUpTests",
"covers_restart": false
}
]
},
{
"id": "tokens.authorization_decisions",
"title": "Shared token authorization and group-proposal decisions",
Expand Down
15 changes: 8 additions & 7 deletions packages/kotlin-sdk/PARITY_SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@
# Kotlin/Swift executable parity summary

Audit baseline: `PR #3999 @ 6dbc72a54df72d26eb9c4a014b425d2b95134e4e`
Capabilities tracked: **30**
Capabilities tracked: **31**

## Status counts

| Host | Surface | Supported | Partial | Unsupported | Not applicable |
| --- | --- | ---: | ---: | ---: | ---: |
| Swift | SDK | 17 | 11 | 1 | 1 |
| Swift | Example app | 5 | 14 | 2 | 9 |
| Kotlin | SDK | 14 | 14 | 1 | 1 |
| Kotlin | Example app | 6 | 13 | 1 | 10 |
| Swift | SDK | 18 | 11 | 1 | 1 |
| Swift | Example app | 5 | 14 | 3 | 9 |
| Kotlin | SDK | 14 | 14 | 2 | 1 |
| Kotlin | Example app | 6 | 13 | 2 | 10 |

## Restart coverage

| Host | Tested | Required | Not applicable |
| --- | ---: | ---: | ---: |
| Swift | 2 | 10 | 18 |
| Kotlin | 5 | 8 | 17 |
| Swift | 2 | 10 | 19 |
| Kotlin | 5 | 8 | 18 |

## Capability status

Expand All @@ -42,6 +42,7 @@ Capabilities tracked: **30**
| `persistence.dashpay_payment_history` | partial / not-applicable / required | not-applicable / not-applicable / not_applicable |
| `network.masternode_discovery` | partial / not-applicable / not_applicable | partial / not-applicable / not_applicable |
| `identity.platform_address_auto_funding` | partial / partial / not_applicable | partial / partial / not_applicable |
| `identity.external_top_up_from_addresses` | supported / unsupported / not_applicable | unsupported / unsupported / not_applicable |
| `tokens.authorization_decisions` | partial / partial / not_applicable | partial / partial / not_applicable |
| `tokens.direct_purchase_quote` | partial / partial / not_applicable | partial / partial / not_applicable |
| `protocol.address_validation` | supported / supported / not_applicable | partial / partial / not_applicable |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,19 @@ sealed class DashSdkError(
class PublicContactRequestUnconfirmed(message: String, cause: Throwable? = null) :
PlatformWallet(message, cause)

/**
* `ErrorIdentityLookupFailed` (native code 80). Platform could not be
* asked for an identity the operation names (the lookup failed, which
* is not Platform's answer that it does not exist, code 7). Nothing
* was signed, reserved or broadcast, so the operation may be retried
* as it is and is never a possibly delivered one.
* ← Swift `PlatformWalletError.identityLookupFailed`.
*/
class IdentityLookupFailed(message: String, cause: Throwable? = null) :
PlatformWallet(message, cause) {
override val isRetryable: Boolean get() = true
}

/**
* Any other `PlatformWalletFFIResultCode` without a dedicated type.
* Carries the platform-wallet [nativeCode] (already de-offset) and
Expand Down Expand Up @@ -1004,6 +1017,7 @@ sealed class DashSdkError(
74 -> PlatformWallet.PrivateContactStoreNotRead(message, cause) // ErrorPrivateContactStoreNotRead
75 -> PlatformWallet.SdkPinnedBelowProtocolVersion(message, cause) // ErrorSdkPinnedBelowProtocolVersion
76 -> PlatformWallet.PublicContactRequestUnconfirmed(message, cause) // ErrorPublicContactRequestUnconfirmed
80 -> PlatformWallet.IdentityLookupFailed(message, cause) // ErrorIdentityLookupFailed
else ->
// @Deprecated fallback — see the code-6 arm; code 31 is the
// real discriminator.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,20 @@ class DashSdkErrorTest {
assertFalse("a sync settles it, not a retry", mapped.isRetryable)
}

/**
* A failed identity lookup sent nothing: its own code, retryable as it is,
* apart from the unmapped SDK errors a host reads as possibly delivered.
*/
@Test
fun shouldReportAFailedIdentityLookupByItsOwnCode() {
val detail = "could not look up identity on Platform; nothing was sent"
val native = DashSDKException(DashSdkError.PLATFORM_WALLET_CODE_OFFSET + 80, detail)
val mapped = DashSdkError.fromNative(native)
assertTrue(mapped is DashSdkError.PlatformWallet.IdentityLookupFailed)
assertEquals(detail, mapped.message)
assertTrue("nothing was sent, so it may be retried as it is", mapped.isRetryable)
}

@Test
fun platformShieldCapacityCode41MapsTyped() {
val message =
Expand Down
Loading
Loading