Skip to content

fix(dashmate): key the protxinfo whitelist migration to 5.1.0-dev.1 - #5844

Merged
shumkov merged 1 commit into
v5.1-devfrom
shumkov/v51-dashmate-migration-key-dev1
Nov 10, 2026
Merged

shumkov merged 1 commit into
v5.1-devfrom
shumkov/v51-dashmate-migration-key-dev1

Conversation

@shumkov

@shumkov shumkov commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

#5775 added a dashmate config migration that puts protxinfo on Drive's consensus RPC whitelist (from protocol 15 Drive reads protx info for operator key changes; without the method Core answers 403 and the block fails on that node). It was keyed 5.1.0-beta.1. The first 5.1 release will be 5.1.0-dev.1, and semver sorts beta below dev, so once any config carries a 5.1.0-dev.N stamp a migration keyed beta.1 would be skipped for it.

What was done?

  • Keyed the migration to 5.1.0-dev.1, the release that first ships it.
  • The migration fixture test now strips protxinfo from fixtures of releases below 5.1.0-dev.1.

No release with a 5.1.0 version exists yet (latest is v5.0.3), so no config is stamped above the new key.

How Has This Been Tested?

CI's dashmate unit tests (migrateConfigFileFactory.spec.js builds a config as each earlier release wrote it and migrates it). Not run locally: the test needs the built workspace packages.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • My Rust, FFI, WASM, Swift or Kotlin changes follow the coding conventions
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed
  • If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request
  • If I added or changed a system contract's document schemas, I checked the contract viewer link posted on this pull request

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · a4dcd4f

  • Bots — thepastaclaw ✓
  • Self-review — post /self-reviewed
  • Build running
  • Approvals — you own every area touched; none needed

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • Bug Fixes
    • Updated configuration migration versioning for the 5.1.0 development release. Existing configurations continue to receive the protxinfo whitelist entry when the whitelist is an array and does not already contain it.
    • Updated the configuration fixture cutoff so releases before 5.1.0-dev.1 remove protxinfo from older defaults.

The migration that adds `protxinfo` to Drive's consensus RPC whitelist was
keyed 5.1.0-beta.1. The first 5.1 release is 5.1.0-dev.1, and semver sorts
"beta" below "dev", so a config already stamped by a 5.1.0-dev release would
skip a migration keyed beta.1. Keyed to the release that first ships it, it
runs once for every config written by 5.0.x or earlier and is skipped by
configs that already went through it.

No behaviour test added: the existing migration fixture test covers the key
(it now strips protxinfo from fixtures of releases below 5.1.0-dev.1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shumkov shumkov added this to the v5.1.0 milestone Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The protxinfo migration key and the test fixture cutoff both change to 5.1.0-dev.1. The migration logic is unchanged.

Changes: Config migration cutoff

Layer / File(s) Summary
Align migration and fixture cutoffs
packages/dashmate/configs/getConfigFileMigrationsFactory.js, packages/dashmate/test/unit/config/configFile/migrateConfigFileFactory.spec.js
The migration key and fixture release threshold change to 5.1.0-dev.1. The migration behavior is unchanged.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related issues

  • dashpay/platform#5820 — This issue describes the protxinfo whitelist migration. This change updates its version threshold.

Possibly related PRs

  • dashpay/platform#5775 — This PR added the same migration and fixture cutoff that this change updates.

Suggested reviewers: quantumexplorer

Merge Risk: Minimal · up to a4dcd

No merge-blocking risk is established. The migration test was not reported as run locally.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the change: updating the protxinfo whitelist migration key to 5.1.0-dev.1.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5345437 and a4dcd4f.

Files selected for processing: 2

  • packages/dashmate/configs/getConfigFileMigrationsFactory.js
  • packages/dashmate/test/unit/config/configFile/migrateConfigFileFactory.spec.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 10, 2026
@thepastaclaw

thepastaclaw commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit a4dcd4f) · triage: low

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

The two-line change correctly moves the Dashmate migration boundary to 5.1.0-dev.1 and updates the historical fixture cutoff to match. Migration dispatch, defaults, idempotence, and existing whitelist coverage are consistent with this boundary; no in-scope defects were found. Dashmate tests and linting were still pending, with no failed code checks reported.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: architecture-layering); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: platform-versioning); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — This is a small, well-contained dashmate migration-version and fixture-cutoff update whose behavior is straightforward to verify and does not alter consensus, funds, cryptography, or storage.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 89% left, weekly 88% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — architecture-layering (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — platform-versioning (completed, effort medium); agent phase2-reviewer

@github-actions

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 10, 2026
@shumkov
shumkov merged commit 3d1b500 into v5.1-dev Nov 10, 2026
32 of 33 checks passed
@shumkov
shumkov deleted the shumkov/v51-dashmate-migration-key-dev1 branch November 10, 2026 15:44
shumkov added a commit that referenced this pull request Nov 11, 2026
Brings in #5775 (operator payouts and keys at protocol 15), #5844 and the
other v5.1-dev merges since 9b36712.

Conflict in packages/rs-drive-abci/src/rpc/core.rs: both sides appended
tests at the end of `mod tests`. Kept both: this branch's
`chain_lock_requests` module and v5.1-dev's `protx info` answer tests.

Doc text updated for #5775: protocol 15 now uses `update_masternode_list`
2, whose operator key normalization reads V24 from the Core fork record
instead of asking Core. This branch had documented that the normalization
"still asks", which was true before #5775. v15 note 18, the
DRIVE_ABCI_METHOD_VERSIONS_V11 doc and the doc of
`should_never_ask_core_about_v24_again_once_it_is_recorded_even_after_a_restart`
now say it reads the record, and that `update_state_masternode_list` v0 and
v1 (protocol 14 and earlier) ask Core. Text only; v15 note numbers are
unchanged (this branch adds no notes, v5.1-dev adds 28 to 32).

The golden masternode-list snapshot
(should_store_the_mainnet_masternode_lists_as_shipped_protocol_versions_do)
passes unchanged: PV13/PV14 replay stores the same lists and app hashes.

Verified: RUST_MIN_STACK=4194304 cargo test -p drive-abci --lib (4619
passed, 17 ignored, 0 failed), cargo test -p platform-version --lib (29
passed), scoped clippy -D warnings --all-targets --all-features, cargo fmt
--check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-self-review Waiting for the author to post /self-reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants