Repository navigation
chore: bump GroveDB, and rusqlite and refinery to match - #5828
QuantumExplorer wants to merge 2 commits into
Conversation
Moves the pin from 12adbd35 to 45e2d84f, bringing in dashpay/grovedb#1025 and dashpay/grovedb#1033. Both are gated on GROVE_V5, which only protocol version 15 selects. The new struct fields keep today's behaviour: `offset: None` on the Query literals and `allow_replacement_accounting: false` on the BatchApplyOptions literals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
🔍 Review in progress — actively reviewing now (commit 704d3f0) · triage: low |
Moves the pin to fa92511c, which removes that batch option and bundles SQLite 3.54 through rusqlite 0.41. Only one SQLite can be linked, so the wallet crates move to rusqlite 0.41 and refinery 0.10, whose migrations support it. That also picks up the fix for RUSTSEC-2026-0459. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
Closing: folded into #5829 so the GroveDB bump and the change that needs it get one review and one CI run. 🤖 Generated with Claude Code |
Basic explanation
What this does: Moves Platform's GroveDB dependency forward to pick up count tree paging by offset (grovedb#1025), letting a flags update hand an element to a new owner (grovedb#1033, grovedb#1035) and a newer bundled SQLite (grovedb#1034). The wallet crates move to the matching
rusqliteandrefinery, because only one SQLite can be linked. Platform does not use the two new GroveDB features yet.Value: Later protocol version 15 work needs these, starting with storage refunds for transfers, purchases and gas sponsors. The SQLite update also fixes the RUSTSEC-2026-0459 audit failure.
Risks: Low. The GroveDB behaviour changes are gated on
GROVE_V5, which only protocol version 15 selects, and that version is not released. Protocol version 14 stays onGROVE_V4. The wallet's SQLite library moves up threerusqliteminor versions, with its storage tests passing.Issue being fixed or feature implemented
Platform pins GroveDB at
12adbd35, which has neither change.What was done?
Pin moved from
12adbd35tofa92511cinCargo.tomlandCargo.lock.rusqlite0.38 to 0.41 andrefinery0.9.2 to 0.10 in the wallet crates. Four test call sites changed becausecommit_hookandtrace_v2now take&mut self.The GroveDB API gained one struct field, so struct literals had to change. The new value keeps today's behaviour:
Public interface
Platform's own API is unchanged. Code that builds this GroveDB type directly as a struct literal needs the new field:
grovedb_query::Queryoffset: Option<u16>NoneIn-place changes to shipped generations
verify_shielded_encrypted_notesv0 and theencrypted_notesquery v0 gained onlyoffset: None, which is what GroveDB did before the field existed, so consensus cannot change.How Has This Been Tested?
cargo check -p drive -p drive-abci -p platform-wallet -p platform-wallet-storage --all-targets --all-featuresandcargo check -p drive --no-default-features --features verify.cargo test -p platform-wallet-storage --all-features(1,009 passed across its test targets).cargo test -p drive --libfiltered toutil::grove_operationsanddrive::document::updateand the query tests (476 passed).cargo test -p drive-abci --libfiltered to gas sponsorship and NFT document tests, the nullifier batch guard pins and shielded queries (107 passed).Breaking Changes
None at any released protocol version.
Checklist:
🤖 Generated with Claude Code
PR Hygiene ·
704d3f0/skip-botsproceeds without the ones not yet reported/self-reviewedrs-drive-abci— you own itrs-drive— you own itwallet-storage(packages/rs-platform-wallet-storage/Cargo.toml,packages/rs-platform-wallet-storage/tests/integration/sqlite_buffer_semantics.rs,packages/rs-platform-wallet-storage/tests/integration/sqlite_load_reconstruction.rs) — lklimekrs-platform-wallet(packages/rs-platform-wallet/Cargo.toml) — HashEngineering or ZocoLini or llbartekll or romchornyiWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.