Skip to content

chore: bump GroveDB, and rusqlite and refinery to match - #5828

Closed
QuantumExplorer wants to merge 2 commits into
v5.1-devfrom
claude/grovedb-pin-flags-handover
Closed

QuantumExplorer wants to merge 2 commits into
v5.1-devfrom
claude/grovedb-pin-flags-handover

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Basic explanation

What this does: Moves Platform's GroveDB dependency forward to pick up count tree paging by offset (grovedb#1025), letting a flags update hand an element to a new owner (grovedb#1033, grovedb#1035) and a newer bundled SQLite (grovedb#1034). The wallet crates move to the matching rusqlite and refinery, because only one SQLite can be linked. Platform does not use the two new GroveDB features yet.

Value: Later protocol version 15 work needs these, starting with storage refunds for transfers, purchases and gas sponsors. The SQLite update also fixes the RUSTSEC-2026-0459 audit failure.

Risks: Low. The GroveDB behaviour changes are gated on GROVE_V5, which only protocol version 15 selects, and that version is not released. Protocol version 14 stays on GROVE_V4. The wallet's SQLite library moves up three rusqlite minor versions, with its storage tests passing.

Issue being fixed or feature implemented

Platform pins GroveDB at 12adbd35, which has neither change.

What was done?

  • Pin moved from 12adbd35 to fa92511c in Cargo.toml and Cargo.lock.

  • rusqlite 0.38 to 0.41 and refinery 0.9.2 to 0.10 in the wallet crates. Four test call sites changed because commit_hook and trace_v2 now take &mut self.

  • The GroveDB API gained one struct field, so struct literals had to change. The new value keeps today's behaviour:

    // Before
    Query { read_mode: None, limit: None, items, /* ... */ }
    
    // After
    Query { read_mode: None, limit: None, offset: None, items, /* ... */ }

Public interface

Platform's own API is unchanged. Code that builds this GroveDB type directly as a struct literal needs the new field:

Type New field Value that keeps today's behaviour
grovedb_query::Query offset: Option<u16> None

In-place changes to shipped generations

verify_shielded_encrypted_notes v0 and the encrypted_notes query v0 gained only offset: None, which is what GroveDB did before the field existed, so consensus cannot change.

How Has This Been Tested?

  • cargo check -p drive -p drive-abci -p platform-wallet -p platform-wallet-storage --all-targets --all-features and cargo check -p drive --no-default-features --features verify.
  • cargo test -p platform-wallet-storage --all-features (1,009 passed across its test targets).
  • cargo test -p drive --lib filtered to util::grove_operations and drive::document::update and the query tests (476 passed).
  • cargo test -p drive-abci --lib filtered to gas sponsorship and NFT document tests, the nullifier batch guard pins and shielded queries (107 passed).
  • No full suite was run locally.

Breaking Changes

None at any released protocol version.

Checklist:

  • I have performed a self-review of my own code
  • My Rust, FFI, WASM, Swift or Kotlin changes follow the coding conventions
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

🤖 Generated with Claude Code

PR Hygiene · 704d3f0

  • Bots — thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed
  • Reviewer requests paused — your 5 review slots are occupied; this PR is excluded from reviewers' queues. Required approvals still count without a slot.
  • Build running
  • Approvals
    • files with no dedicated owner — you own it
    • rs-drive-abci — you own it
    • rs-drive — you own it
    • wallet-storage (packages/rs-platform-wallet-storage/Cargo.toml, packages/rs-platform-wallet-storage/tests/integration/sqlite_buffer_semantics.rs, packages/rs-platform-wallet-storage/tests/integration/sqlite_load_reconstruction.rs) — lklimek
    • rs-platform-wallet (packages/rs-platform-wallet/Cargo.toml) — HashEngineering or ZocoLini or llbartekll or romchornyi

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Moves the pin from 12adbd35 to 45e2d84f, bringing in dashpay/grovedb#1025
and dashpay/grovedb#1033. Both are gated on GROVE_V5, which only protocol
version 15 selects.

The new struct fields keep today's behaviour: `offset: None` on the
Query literals and `allow_replacement_accounting: false` on the
BatchApplyOptions literals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9b36712 and 704d3f0.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 7

  • Cargo.toml
  • packages/rs-drive-abci/src/query/shielded/encrypted_notes/v0/mod.rs
  • packages/rs-drive/src/verify/shielded/verify_shielded_encrypted_notes/v0/mod.rs
  • packages/rs-platform-wallet-storage/Cargo.toml
  • packages/rs-platform-wallet-storage/tests/integration/sqlite_buffer_semantics.rs
  • packages/rs-platform-wallet-storage/tests/integration/sqlite_load_reconstruction.rs
  • packages/rs-platform-wallet/Cargo.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 9, 2026
@thepastaclaw

thepastaclaw commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

🔍 Review in progress — actively reviewing now (commit 704d3f0) · triage: low
░░░░░░░░░░░░░░░░░░░░ 2% · about 30 min left · running for 0 min
✅ triage → ⏳ Phase 1 (0/1 lanes) → ▫️ verify 1 → ▫️ gate → ▫️ Phase 2 → ▫️ verify 2 → ▫️ publish
Estimated from recent reviews of this tier · updated 19:13 UTC · live progress

Moves the pin to fa92511c, which removes that batch option and bundles
SQLite 3.54 through rusqlite 0.41. Only one SQLite can be linked, so the
wallet crates move to rusqlite 0.41 and refinery 0.10, whose migrations
support it. That also picks up the fix for RUSTSEC-2026-0459.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@QuantumExplorer QuantumExplorer changed the title chore: bump GroveDB past the flags handover and count tree offset work chore: bump GroveDB, and rusqlite and refinery to match Nov 9, 2026
@github-actions github-actions Bot added this to the v5.1.0 milestone Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@QuantumExplorer

Copy link
Copy Markdown
Member Author

Closing: folded into #5829 so the GroveDB bump and the change that needs it get one review and one CI run.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants