Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
196 commits
Select commit Hold shift + click to select a range
5fa4714
test(sdk): open an entry with the first of a wallet's prepared keys
QuantumExplorer Nov 8, 2026
1549627
feat(sdk): send, scan and read private contact requests
QuantumExplorer Nov 8, 2026
a6ca844
feat(sdk): name the sender key of a recovered private contact request
QuantumExplorer Nov 8, 2026
74c0d7d
feat(platform-wallet): send, read and accept DashPay private contact …
QuantumExplorer Nov 8, 2026
c3f1b0d
feat(sdk): sign private contact requests with the sender's signing key
QuantumExplorer Nov 8, 2026
f556feb
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
63e1f69
fix(platform-wallet): sign private contact requests and keep them pri…
QuantumExplorer Nov 8, 2026
6db333e
fix(sdk): bind the recipient key into a private request's signature
QuantumExplorer Nov 8, 2026
e12cb96
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
3d510b8
fix(sdk): export private_contact_request_signing_keys
QuantumExplorer Nov 8, 2026
197ca08
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
f248319
fix(platform-wallet): sign private requests only with keys the SDK al…
QuantumExplorer Nov 8, 2026
cc2c7bc
feat(platform-wallet): accept a contact request replying the way it came
QuantumExplorer Nov 8, 2026
d4efa2e
fix(sdk): validate private requests with dpp and check proved identit…
QuantumExplorer Nov 8, 2026
009747a
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
7bd302a
fix(platform-wallet): keep paid private replies and pay a reply lazily
QuantumExplorer Nov 8, 2026
473a440
fix(sdk): refuse expired signing keys and refresh a DashPay without t…
QuantumExplorer Nov 8, 2026
f518421
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
d0db59f
fix(platform-wallet): record a private request only once read back, o…
QuantumExplorer Nov 8, 2026
4a4826a
fix(sdk): keep encryption keys inside their contract bounds and check…
QuantumExplorer Nov 8, 2026
ff59d59
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
9a4ca7f
fix(platform-wallet): refuse a public request while a private one is …
QuantumExplorer Nov 8, 2026
f83284e
fix(platform-wallet): tie each pending private request to its attempt…
QuantumExplorer Nov 8, 2026
f8e20bb
fix(platform-wallet): refuse a contact request once every rotation ve…
QuantumExplorer Nov 8, 2026
785e493
fix(sdk): give an empty context provider the DashPay it fetches, and …
QuantumExplorer Nov 8, 2026
b95c212
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
8c5968c
fix(platform-wallet): fence a private contact request payment against…
QuantumExplorer Nov 8, 2026
9f5db04
fix(platform-wallet): read the private store before an identity's fir…
QuantumExplorer Nov 8, 2026
b3a0ad3
fix(wasm-dpp2): key the constructor's tokens by position as text, and…
QuantumExplorer Nov 8, 2026
875326b
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
f5dde30
fix(wasm-dpp2): refuse tokens for a contract that cannot hold them
QuantumExplorer Nov 8, 2026
77e943e
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
410b38c
fix(sdk): refuse a scan of another store as DashPay private contact r…
QuantumExplorer Nov 8, 2026
6b54d0d
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
9ea2325
fix(platform-wallet): restore an unconfirmed rotation over the reques…
QuantumExplorer Nov 8, 2026
ab68754
refactor(dpp): give the document signing levels of a security require…
QuantumExplorer Nov 8, 2026
1bd3788
fix(sdk): read a private contact request only through a key it could …
QuantumExplorer Nov 8, 2026
609f529
fix(sdk): wipe the outgoing viewing key a private contact request is …
QuantumExplorer Nov 8, 2026
5839100
fix(sdk): give a private page reader's context provider the contract …
QuantumExplorer Nov 8, 2026
be7fba8
feat(sdk): stream a private document store's pages, many fetched at once
QuantumExplorer Nov 8, 2026
b5e2eb2
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
f479c94
perf(platform-wallet): read the private contact request store many pa…
QuantumExplorer Nov 8, 2026
76c5418
feat(platform-wallet): keep the private contact request read position…
QuantumExplorer Nov 8, 2026
d5db080
fix(platform-wallet): claim a contact pair for a public request as a …
QuantumExplorer Nov 8, 2026
3698f6a
fix(platform-wallet): read the private store again when an identity's…
QuantumExplorer Nov 8, 2026
f7761d0
fix(platform-wallet): release a private reservation until its payment…
QuantumExplorer Nov 8, 2026
1ebd255
fix(platform-wallet): release a private reservation once its payment …
QuantumExplorer Nov 8, 2026
3012b4e
fix(platform-wallet): save a private payment's signed transition befo…
QuantumExplorer Nov 8, 2026
0a3b859
fix(platform-wallet): adopt a reply another accept recorded once the …
QuantumExplorer Nov 8, 2026
b8e41ab
fix(sdk): refuse a private document read below protocol version 15 as…
QuantumExplorer Nov 8, 2026
8950232
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
afc6b7e
fix(platform-wallet): hold a contact pair across a restart before any…
QuantumExplorer Nov 8, 2026
d91c1c6
fix(sdk): name the SDK's protocol version when building a private doc…
QuantumExplorer Nov 8, 2026
0e3f521
fix(wasm-dpp2): refuse tokens set on a data contract that holds none
QuantumExplorer Nov 8, 2026
3f546c0
docs(dpp): say at the batch signing levels why the in-place change ke…
QuantumExplorer Nov 8, 2026
e710dd7
docs(sdk): say what the private contact request parser and signing le…
QuantumExplorer Nov 8, 2026
454f25c
test(sdk): check a recipient key holding another point is refused by …
QuantumExplorer Nov 8, 2026
3b68903
test(sdk): pin a private page stream's order and its cursor under a g…
QuantumExplorer Nov 8, 2026
898e8fc
fix(sdk): keep the store a private document scan was read from, and r…
QuantumExplorer Nov 8, 2026
fa18256
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 8, 2026
91d8782
fix(sdk): send a private document transition only once the network is…
QuantumExplorer Nov 9, 2026
19ab417
fix(sdk): keep each outgoing viewing key in place as scan senders are…
QuantumExplorer Nov 9, 2026
75cd978
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 9, 2026
59e047a
fix(sdk): learn a private store's chunk size only from a page that en…
QuantumExplorer Nov 9, 2026
314d957
fix(sdk): refuse a private contact request scan of a contract whose t…
QuantumExplorer Nov 9, 2026
f98c1bd
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 9, 2026
dcc0b15
fix(platform-wallet): mark a private payment started only once its re…
QuantumExplorer Nov 9, 2026
d15c5c9
fix(platform-wallet): release a dropped spend's notes until the spend…
QuantumExplorer Nov 9, 2026
0dc72a0
fix(platform-wallet): take private payment rejection notices only und…
QuantumExplorer Nov 9, 2026
757474b
fix(platform-wallet): skip the private store read only on a network v…
QuantumExplorer Nov 9, 2026
ea2a66b
feat(platform-wallet-ffi): scan the private contact request store thr…
QuantumExplorer Nov 9, 2026
df8cba5
fix(platform-wallet): release a public request's claim only by the at…
QuantumExplorer Nov 9, 2026
6c3abe0
fix(platform-wallet): drop a private contact request association with…
QuantumExplorer Nov 9, 2026
e11ef7c
fix(sdk): keep a newer contract over a registered older one
QuantumExplorer Nov 9, 2026
856fd6b
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 9, 2026
c33583a
fix(platform-wallet): read the private store again before a send once…
QuantumExplorer Nov 9, 2026
efa0fc8
fix(sdk): complete a private store chunk an older snapshot ended part…
QuantumExplorer Nov 9, 2026
baa3092
fix(sdk): gate every type 29 broadcast and refuse it with the structu…
QuantumExplorer Nov 9, 2026
40e4f57
fix(sdk): keep a newer contract in the gRPC context provider, and say…
QuantumExplorer Nov 9, 2026
f7fcc44
fix(sdk): report an identity proved before its entry as a retryable s…
QuantumExplorer Nov 9, 2026
a35fe84
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 9, 2026
b065ca3
fix(sdk): read a private contact request under an eligible alias of i…
QuantumExplorer Nov 9, 2026
4712db7
fix(sdk): fetch again a private page an older snapshot left empty, th…
QuantumExplorer Nov 9, 2026
8558e83
feat(sdk): schedule a private store's page walk from the chunk size i…
QuantumExplorer Nov 9, 2026
fdc50a2
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 9, 2026
8079cb8
feat(platform-wallet-ffi): give the private contact request outcomes …
QuantumExplorer Nov 9, 2026
e3654c2
fix(platform-wallet): wipe a private request's sealing seed when its …
QuantumExplorer Nov 9, 2026
8f7088b
docs(platform-wallet): note the ShieldedStore 'static bound in the AP…
QuantumExplorer Nov 9, 2026
e37af8e
fix(platform-wallet): keep a failed spend's notes in its guard until …
QuantumExplorer Nov 9, 2026
d768705
fix(platform-wallet): keep a private payment's rejection for the sess…
QuantumExplorer Nov 9, 2026
cc6fef5
fix(platform-wallet): hold a reloaded wallet's public contact request…
QuantumExplorer Nov 9, 2026
a3a7fc4
fix(platform-wallet): refuse a private contact request pass whose pro…
QuantumExplorer Nov 9, 2026
4386ec0
docs(sdk): say that a private request's key expiry is the identity's …
QuantumExplorer Nov 9, 2026
2b5e86f
Merge remote-tracking branch 'origin/feat/sdk-private-documents-send-…
QuantumExplorer Nov 9, 2026
f9d669f
fix(sdk-trusted-context-provider): keep a newer known contract over a…
QuantumExplorer Nov 9, 2026
311ae62
fix(sdk): keep a failed refresh as the cause of a private document se…
QuantumExplorer Nov 9, 2026
4e75e27
fix(sdk): read a private page against a newer contract with the type …
QuantumExplorer Nov 9, 2026
235a4f8
fix(sdk): take the network as proven below a version only on a curren…
QuantumExplorer Nov 9, 2026
03cea26
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 9, 2026
5a91dc7
fix(platform-wallet-ffi): keep a missing mnemonic as key-unavailable …
QuantumExplorer Nov 9, 2026
4c81017
fix(platform-wallet): hold an identity reloaded with an unresolved pr…
QuantumExplorer Nov 9, 2026
91678f5
feat(platform-wallet-ffi): report unrestored private payments by thei…
QuantumExplorer Nov 9, 2026
ecf621d
docs(wasm-sdk): say that a registration keeps a held contract of a hi…
QuantumExplorer Nov 9, 2026
0dc274c
fix(sdk): ask the protocol gate before refusing a private document send
QuantumExplorer Nov 9, 2026
9b8589a
test(drive-abci): export a protocol 15 epoch probe for the SDK's gate…
QuantumExplorer Nov 9, 2026
50658b5
fix(sdk): establish protocol 15 through the gate for DashPay's privat…
QuantumExplorer Nov 9, 2026
c7502c4
Merge branch 'feat/sdk-private-documents-send-and-scan' into feat/pla…
QuantumExplorer Nov 9, 2026
3deebd5
fix(platform-wallet): fail a private payment restore closed on a save…
QuantumExplorer Nov 9, 2026
8cdeadf
fix(platform-wallet): match a recovered private request's recipient k…
QuantumExplorer Nov 9, 2026
8260a1c
fix(platform-wallet): keep a private payment's hold durable, required…
QuantumExplorer Nov 9, 2026
84c2b96
feat(platform-version): double a private document store's chunk targe…
QuantumExplorer Nov 9, 2026
b2af518
Merge remote-tracking branch 'origin/feat/sdk-private-documents-send-…
QuantumExplorer Nov 9, 2026
27e4173
fix(platform-wallet): fail a private payment restore on a saved trans…
QuantumExplorer Nov 9, 2026
f2b9c7d
fix(platform-wallet): keep a private contact payment reserved through…
QuantumExplorer Nov 9, 2026
d6279b0
fix(platform-wallet-ffi): report an unsupported private recovery by i…
QuantumExplorer Nov 9, 2026
acb98eb
fix(platform-wallet): free a pair rejected for good on the next priva…
QuantumExplorer Nov 9, 2026
194acb9
Merge remote-tracking branch 'origin/v5.1-dev' into feat/platform-wal…
QuantumExplorer Nov 9, 2026
f7a1204
test(drive-abci): expect DashPay v3's private store at chunk power 10…
QuantumExplorer Nov 9, 2026
b4b976f
Merge remote-tracking branch 'origin/v5.1-dev' into feat/platform-wal…
QuantumExplorer Nov 9, 2026
4f3bd84
fix(platform-wallet): hold private contact request pairs from a durab…
QuantumExplorer Nov 9, 2026
1fb46dd
fix(platform-wallet-ffi): report a broadcast that may have been deliv…
QuantumExplorer Nov 9, 2026
3ad51a3
docs(platform-wallet): describe the private payment journal and maybe…
QuantumExplorer Nov 9, 2026
e312365
fix(platform-wallet): own note reservations by attempt, and save a pr…
QuantumExplorer Nov 9, 2026
a1748d9
fix(platform-wallet): replay the last private payment marker, and flu…
QuantumExplorer Nov 9, 2026
94b4c83
fix(platform-wallet-ffi): keep code 70 for genuine protocol-version r…
QuantumExplorer Nov 9, 2026
360fb00
test(platform-wallet): restore a saved private payment in both startu…
QuantumExplorer Nov 9, 2026
c16c01b
Merge remote-tracking branch 'origin/v5.1-dev' into feat/platform-wal…
QuantumExplorer Nov 9, 2026
26de923
fix(drive): drop the argument #5798 removed from add_document_for_con…
QuantumExplorer Nov 9, 2026
8728bcd
test(platform-wallet): rebind identically while a scan holds the shie…
QuantumExplorer Nov 9, 2026
1b3a37b
Merge branch 'v5.1-dev' into feat/platform-wallet-private-contact-req…
QuantumExplorer Nov 9, 2026
5c99f46
fix(platform-wallet): count no endpoint verdict as proof a shielded s…
QuantumExplorer Nov 9, 2026
94452e6
fix(platform-wallet): keep a stale restoration from reserving a disch…
QuantumExplorer Nov 9, 2026
2197ec6
fix(platform-wallet): bind a public contact request to its wallet gen…
QuantumExplorer Nov 9, 2026
8ede791
fix(platform-wallet): discharge a private payment proven expired and …
QuantumExplorer Nov 9, 2026
ac4459a
feat(sdk): stream private document pages with their proved heights
QuantumExplorer Nov 9, 2026
d0d337b
fix(sdk): give a completed private document page the lowest height of…
QuantumExplorer Nov 9, 2026
0996db2
feat(sdk): let the mock SDK report a chosen response height
QuantumExplorer Nov 9, 2026
ad25184
fix(platform-wallet): prove a private payment expired only on evidenc…
QuantumExplorer Nov 9, 2026
c81424f
fix(platform-wallet): restore a private payment's reservation through…
QuantumExplorer Nov 9, 2026
f7510b4
fix(platform-wallet): retire a never-delivered payment's record and j…
QuantumExplorer Nov 9, 2026
0e24035
fix(platform-wallet): discharge an expired private payment whose inpu…
QuantumExplorer Nov 9, 2026
92569e7
feat(sdk): let the mock SDK prove each response type at its own height
QuantumExplorer Nov 9, 2026
e5f8ed9
fix(platform-wallet): release a stranded note only on height-pinned p…
QuantumExplorer Nov 9, 2026
6789d60
fix(platform-wallet): publish a never-delivered payment's retirement …
QuantumExplorer Nov 9, 2026
5ff0302
refactor(platform-wallet): keep an unknown journal anchor height as N…
QuantumExplorer Nov 9, 2026
17497a4
fix(platform-wallet): hold an unresolved private payment's pair at th…
QuantumExplorer Nov 9, 2026
cce059d
docs(platform-wallet): tell a pinned SDK's refusal apart and list eve…
QuantumExplorer Nov 9, 2026
98aa2f2
test(platform-wallet-ffi): cover a pinned refusal with a cause and a …
QuantumExplorer Nov 9, 2026
5cf6cab
fix(platform-wallet): keep no read-back set without shielded, and syn…
QuantumExplorer Nov 9, 2026
6d0f2e9
fix(platform-wallet): free notes an earlier process reserved before a…
QuantumExplorer Nov 9, 2026
ac533fd
perf(platform-wallet): read the private store no more for an entry an…
QuantumExplorer Nov 9, 2026
7e11255
fix(platform-wallet): keep a restored wallet available on a busy rebi…
QuantumExplorer Nov 9, 2026
0754c4e
fix(platform-wallet): leave the lifecycle gate clear while the host s…
QuantumExplorer Nov 9, 2026
ea35875
fix(platform-wallet): free the deferred restore queue however its tas…
QuantumExplorer Nov 9, 2026
5987ecb
fix(platform-wallet): read the private store before a public send's l…
QuantumExplorer Nov 9, 2026
d5448b6
test(platform-wallet): resolve a pair's wallet-level hold through the…
QuantumExplorer Nov 9, 2026
2e94b35
docs(platform-wallet): list the attempt-owned reservation methods for…
QuantumExplorer Nov 9, 2026
2191099
fix(platform-wallet): hold an absent sender's pair through the commit…
QuantumExplorer Nov 9, 2026
863cf9c
test(platform-wallet): write the absent-sender test's identity change…
QuantumExplorer Nov 9, 2026
7d053ca
fix(platform-wallet): refuse removing an identity while its contact r…
QuantumExplorer Nov 9, 2026
a2630b2
feat(platform-wallet): keep the largest commitment tree the shielded …
QuantumExplorer Nov 9, 2026
192d5d8
fix(platform-wallet): prove a heightless anchor recorded by the pool'…
QuantumExplorer Nov 9, 2026
5d2084f
docs(platform-wallet): describe how heightless anchor records are rel…
QuantumExplorer Nov 9, 2026
e0f384f
fix(platform-wallet): store the private payment marker whenever it di…
QuantumExplorer Nov 9, 2026
c4e2f3a
fix(platform-wallet): refresh the sender's keys from a proved fetch b…
QuantumExplorer Nov 9, 2026
cecf62f
fix(platform-wallet): decide a public request only with keys proved a…
QuantumExplorer Nov 9, 2026
c22910b
fix(sdk): yield the lowest and highest proved heights of a private do…
QuantumExplorer Nov 10, 2026
5466247
fix(platform-wallet): keep read-back notices whose flush failed until…
QuantumExplorer Nov 10, 2026
9d385c7
fix(platform-wallet): count a rewound private store read only once it…
QuantumExplorer Nov 10, 2026
fbb4d36
fix(platform-wallet): flush read-back notices without holding their lock
QuantumExplorer Nov 10, 2026
d4d55bd
fix(platform-wallet): raise a private store read's height only by pag…
QuantumExplorer Nov 10, 2026
94d81d1
fix(platform-wallet): hold a re-created wallet's journaled private pa…
QuantumExplorer Nov 10, 2026
98b9174
Merge branch 'v5.1-dev' into feat/platform-wallet-private-contact-req…
QuantumExplorer Nov 10, 2026
23ee059
fix(platform-wallet): read the store before every contact request and…
QuantumExplorer Nov 10, 2026
aa0e2a2
fix(platform-wallet): sync the shielded recovery records to the drive…
QuantumExplorer Nov 10, 2026
c7606fc
fix(platform-wallet): drop read-back notices a backend lost and disch…
QuantumExplorer Nov 10, 2026
9b5df14
test(platform-wallet): cover forged entries, the expiry's start posit…
QuantumExplorer Nov 10, 2026
83d86fa
test(platform-wallet): cover the restoration retry before a send, its…
QuantumExplorer Nov 10, 2026
ebb0464
test(platform-wallet): cover the re-check after publication, the firs…
QuantumExplorer Nov 10, 2026
e53aa68
docs(platform-wallet): describe the wallet hold, the tail read and co…
QuantumExplorer Nov 10, 2026
4a0707b
test(platform-wallet): import the journal record type once in the pri…
QuantumExplorer Nov 10, 2026
ddcb8bd
fix(platform-wallet): discharge no settled journal record after a flu…
QuantumExplorer Nov 10, 2026
6033d65
docs(platform-wallet): name the two scan state capability bits plainly
QuantumExplorer Nov 10, 2026
f95f634
fix(platform-wallet): keep journal records a lost flush left, carry t…
QuantumExplorer Nov 10, 2026
2fd3599
fix(platform-wallet-ffi): read the private contact readiness outside …
QuantumExplorer Nov 10, 2026
034b73d
fix(platform-wallet): save shielded spend records before broadcast an…
QuantumExplorer Nov 10, 2026
cfe7c1f
Merge branch 'v5.1-dev' into feat/platform-wallet-private-contact-req…
QuantumExplorer Nov 10, 2026
0a2d984
fix(platform-wallet): read the SDK's unconfirmed broadcast outcome in…
QuantumExplorer Nov 10, 2026
207bd72
docs(platform-wallet-ffi): note code 20's unconfirmed state transitio…
QuantumExplorer Nov 10, 2026
93b2abd
fix(platform-wallet): fence contact request cleanup to the wallet gen…
QuantumExplorer Nov 10, 2026
6d6744f
fix(platform-wallet): discharge a settled private payment record only…
QuantumExplorer Nov 10, 2026
828de98
docs(platform-wallet): say which shield keeps its own broadcast handling
QuantumExplorer Nov 10, 2026
3f8a914
feat(sdk): report the height a transition's inputs were seen consumed
QuantumExplorer Nov 10, 2026
8cd8e6d
feat(sdk): sign a contact request without broadcasting it
QuantumExplorer Nov 10, 2026
e818375
fix(platform-wallet): hold a public contact request whose outcome is …
QuantumExplorer Nov 10, 2026
54ae054
feat(platform-wallet-ffi): code 76 for an unconfirmed public contact …
QuantumExplorer Nov 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ class IdentityRegistrationController(
data class Failed(val message: String) : Phase

/**
* Broadcast-succeeded-but-confirmation-failed terminal state
* (shielded only). The identity at [identityId] MAY already be live;
* the slot must stay held so a re-submission can't burn funds against
* the registered-key-hash check.
* Unconfirmed terminal state (shielded only): the transition may have
* reached a node and its result is not proved. The identity at
* [identityId] MAY already be live; the slot must stay held so a
* re-submission can't burn funds against the registered-key-hash check.
*/
data class Unconfirmed(val identityId: ByteArray, val message: String) : Phase {
override fun equals(other: Any?): Boolean =
Expand All @@ -90,12 +90,13 @@ class IdentityRegistrationController(

/**
* Which stage a shielded [Phase.Failed] failed at, so the progress
* screen can attribute the red marker. Only [BroadcastRejected] is
* attributable with confidence; every other failure leaves this null and
* the progress screen falls back to its elapsed-time heuristic.
* screen can attribute the red marker. Only [BroadcastNotSent] (the
* transition was refused before anything was sent) is attributable with
* confidence; every other failure leaves this null and the progress
* screen falls back to its elapsed-time heuristic.
* ← Swift `FailureStage`.
*/
enum class FailureStage { BroadcastRejected }
enum class FailureStage { BroadcastNotSent }

private val _phase = MutableStateFlow<Phase>(Phase.Idle)
val phase: StateFlow<Phase> = _phase.asStateFlow()
Expand Down Expand Up @@ -136,7 +137,7 @@ class IdentityRegistrationController(
fun submit(
body: suspend () -> ByteArray,
isUnconfirmed: (Throwable) -> ByteArray? = { null },
isBroadcastRejected: (Throwable) -> Boolean = { false },
isBroadcastNotSent: (Throwable) -> Boolean = { false },
) {
when (_phase.value) {
is Phase.Idle, is Phase.PreparingKeys, is Phase.Failed -> Unit
Expand All @@ -157,7 +158,7 @@ class IdentityRegistrationController(
terminalAt = now()
_phase.value = Phase.Unconfirmed(unconfirmedId, e.message ?: "Confirmation pending")
} else {
_failureStage.value = if (isBroadcastRejected(e)) FailureStage.BroadcastRejected else null
_failureStage.value = if (isBroadcastNotSent(e)) FailureStage.BroadcastNotSent else null
terminalAt = now()
_phase.value = Phase.Failed(e.message ?: "Registration failed")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class RegistrationCoordinator(
fundingKind: IdentityRegistrationController.FundingKind = IdentityRegistrationController.FundingKind.AssetLock,
body: suspend () -> ByteArray,
isUnconfirmed: (Throwable) -> ByteArray? = { null },
isBroadcastRejected: (Throwable) -> Boolean = { false },
isBroadcastNotSent: (Throwable) -> Boolean = { false },
): IdentityRegistrationController {
val key = SlotKey(walletId.toHex(), identityIndex)
val existing = _controllers.value[key]
Expand All @@ -89,7 +89,7 @@ class RegistrationCoordinator(
-> {
// Legitimate restart: a fresh idle controller, or a retry after failure.
existing.enterPreparingKeys()
existing.submit(body, isUnconfirmed, isBroadcastRejected)
existing.submit(body, isUnconfirmed, isBroadcastNotSent)
scheduleRetentionSweep(key, existing)
return existing
}
Expand All @@ -98,7 +98,7 @@ class RegistrationCoordinator(
val controller = IdentityRegistrationController(walletId, identityIndex, fundingKind, scope, now)
_controllers.update { it + (key to controller) }
controller.enterPreparingKeys()
controller.submit(body, isUnconfirmed, isBroadcastRejected)
controller.submit(body, isUnconfirmed, isBroadcastNotSent)
scheduleRetentionSweep(key, controller)
return controller
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -730,10 +730,11 @@ fun SendTransactionScreen(
}
}
} catch (e: DashSdkError.PlatformWallet.ShieldedSpendUnconfirmed) {
// Broadcast accepted but its execution result couldn't
// be confirmed β€” the spend may already be on chain and
// the notes stay reserved Rust-side, so this must NOT
// read as a retryable failure (← SendViewModel.swift:790).
// It may have reached a node and its result is not
// proved (a node's refusal or verdict included), so it
// may already be on chain and a retry signs a second
// transition: this must NOT read as a retryable
// failure (← SendViewModel.swift:790).
successMessage = "Transaction may have gone through β€” waiting for " +
"the next shielded sync to confirm. Do not retry."
} catch (t: Throwable) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class RegistrationCoordinatorTest {
}

@Test
fun `broadcast-rejected classifier sets failure stage`() = runTest {
fun `broadcast-not-sent classifier sets failure stage`() = runTest {
val coordinator = coordinator()
val gate = CompletableDeferred<ByteArray>()

Expand All @@ -119,14 +119,14 @@ class RegistrationCoordinatorTest {
identityIndex = 0,
fundingKind = IdentityRegistrationController.FundingKind.ShieldedPool,
body = { gate.await() },
isBroadcastRejected = { true },
isBroadcastNotSent = { true },
)
gate.completeExceptionally(RuntimeException("broadcast rejected"))
gate.completeExceptionally(RuntimeException("nothing was sent"))
advanceUntilIdle()

assertTrue(controller.phase.value is Phase.Failed)
assertEquals(
IdentityRegistrationController.FailureStage.BroadcastRejected,
IdentityRegistrationController.FailureStage.BroadcastNotSent,
controller.failureStage.value,
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -274,31 +274,32 @@ sealed class DashSdkError(

/**
* `ErrorShieldedSpendUnconfirmed` (native code 18). A shielded spend
* (transfer / unshield / withdraw / shield) was broadcast and
* accepted, but its execution result couldn't be confirmed β€” it may
* already be on chain. Rust intentionally KEEPS the spent notes'
* reservations, so the caller must NOT retry (a retry would rebuild
* the bundle against other notes and could double-spend); the next
* shielded sync reconciles the outcome. The Android analog of
* (transfer / unshield / withdraw / shield from Platform addresses)
* may have reached a node and its result is not proved (a failed
* result wait, a node's refusal or a consensus verdict, stale address
* nonce included), so it may already be on chain. Do NOT retry: a
* retry signs a second transition. Spends keep their notes reserved
* for the wallet to resolve; a shield stays pending until the
* shielded scan observes its note. The Android analog of
* Swift's `PlatformWalletError.shieldedSpendUnconfirmed`, which the
* iOS send flow surfaces as a non-retryable "may have gone through"
* outcome rather than an error.
*/
class ShieldedSpendUnconfirmed(message: String, cause: Throwable? = null) :
PlatformWallet(
"$message (do NOT retry: the spend may already be on chain; " +
"the wallet keeps the spent notes reserved until the next " +
"shielded sync reconciles the outcome)",
"$message (do NOT retry: it may already be on chain or may " +
"still execute, and a retry signs a second transition)",
cause,
)

/**
* `ErrorMasternodeWithdrawalUnconfirmed` (native code 42). A
* masternode (evonode) identity credit withdrawal was broadcast and
* accepted, but its execution result couldn't be confirmed β€” it may
* already have executed, and the identity nonce was consumed for it,
* so a blind retry could submit a SECOND withdrawal. Do NOT retry;
* re-read the identity's claimable balance and reconcile first. The
* masternode (evonode) identity credit withdrawal may have reached a
* node and its remaining balance is not proved (a failed result wait,
* a node's refusal or a consensus verdict included). It may have
* executed; a retry signs a second withdrawal with the next identity
* nonce. Do NOT retry; re-read the claimable balance first. Only a
* failure before anything was sent keeps an ordinary code. The
* Android analog of Swift's
* `PlatformWalletError.masternodeWithdrawalUnconfirmed`.
*/
Expand All @@ -311,10 +312,10 @@ sealed class DashSdkError(

/**
* `ErrorShieldedBroadcastFailed` (native code 16). A DEFINITIVE
* non-execution outcome β€” relay/CheckTx rejected the transaction
* before it entered the chain, and any note reservations were
* released. Safe to retry (the opposite of the ambiguous
* [ShieldedSpendUnconfirmed]).
* non-execution outcome: the transition never left the wallet
* (refused before anything was sent), so it can never execute, and
* any note reservations were released. Safe to retry (the opposite
* of the ambiguous [ShieldedSpendUnconfirmed]).
*/
class ShieldedBroadcastFailed(message: String, cause: Throwable? = null) :
PlatformWallet(message, cause) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2010,10 +2010,11 @@ class PlatformWalletManager(
// (cached by [bindShielded]), so no signer or resolver handle crosses
// JNI β€” matching the Swift counterparts, which take no signer either.
// Each blocks for the ~30s Halo 2 proof on Dispatchers.IO. On the
// AMBIGUOUS outcome (broadcast accepted, execution unconfirmed) they
// throw [org.dashfoundation.dashsdk.errors.DashSdkError.PlatformWallet.ShieldedSpendUnconfirmed]
// β€” the caller must NOT retry (the spent notes stay reserved Rust-side;
// the next shielded sync reconciles the outcome).
// AMBIGUOUS outcome (the spend may have reached a node and its result is
// not proved, a node's refusal or verdict included) they
// throw [org.dashfoundation.dashsdk.errors.DashSdkError.PlatformWallet.ShieldedSpendUnconfirmed]:
// the caller must NOT retry (the spent notes stay reserved Rust-side
// until a later shielded sync resolves them).

/**
* Shielded β†’ shielded transfer (Type 16) β€” port of Swift's
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class DashSdkErrorTest {
DashSdkError.fromNative(DashSDKException(offset + 18, "ambiguous spend"))
assertTrue(spendUnconfirmed is DashSdkError.PlatformWallet.ShieldedSpendUnconfirmed)
assertFalse(
"ShieldedSpendUnconfirmed must NOT be retryable (notes stay reserved)",
"ShieldedSpendUnconfirmed must NOT be retryable (a retry signs a second transition)",
spendUnconfirmed.isRetryable,
)
// The message must warn against retrying, like the broadcast sibling.
Expand Down
Loading
Loading