Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
51528a8
feat(sdk)!: decide which networks serve a document query from its fea…
shumkov Oct 28, 2026
b074935
docs(book): explain how the SDK resolves network and node protocol ve…
shumkov Oct 28, 2026
fee5120
fix(sdk): check document windows and ranked indexes before sending
shumkov Oct 28, 2026
b2c2e85
docs(book): note that a pinned SDK's refusal outlasts the activation
shumkov Oct 28, 2026
87d384f
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Oct 28, 2026
de96e86
fix(sdk): ask the network once for calls made while a probe runs
shumkov Oct 28, 2026
0498b78
fix(sdk): refuse before sending a window named by its start that name…
shumkov Oct 28, 2026
382f1af
fix(sdk): report an overflowing document count as an unusable verifie…
shumkov Oct 28, 2026
a59c23d
test(sdk): pin that an aggregate with several in clauses needs no ver…
shumkov Oct 28, 2026
0120f79
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Oct 28, 2026
1a6ee20
fix(sdk): let a probe that answered decide the calls that waited for it
shumkov Oct 28, 2026
3b3dfde
docs(sdk): say which aggregates several in clauses are served in
shumkov Oct 28, 2026
66009fd
fix(sdk): refuse before sending a newest or oldest window that does n…
shumkov Oct 28, 2026
5d63853
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Oct 28, 2026
b2ad331
fix(sdk): resolve a documents select's windows before sending it
shumkov Oct 28, 2026
98fe8b7
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Oct 29, 2026
73edebe
fix(sdk): count several in clauses as a feature only on distinct fields
shumkov Oct 29, 2026
95bb5a7
fix(sdk): refuse windows on two fields and a missing document type be…
shumkov Oct 29, 2026
c4d2eb7
docs(sdk): describe what the ranked and having checks resolve before …
shumkov Oct 29, 2026
3749fe8
fix(wasm-sdk): let the SDK refuse a ranked or having query before dec…
shumkov Oct 30, 2026
5fdeba5
refactor(sdk): declare the document features and their list from one …
shumkov Oct 30, 2026
5a91ea5
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Oct 30, 2026
84417fa
docs(sdk): say the probe hold saves probes rather than promising one …
shumkov Oct 30, 2026
a36181e
fix(sdk): refuse a having clause without a group by before sending
shumkov Oct 30, 2026
3297ce8
test(wasm-sdk): import FromProof for the grouped-query test after the…
shumkov Oct 30, 2026
ef1d3e6
fix(sdk): refuse any having in an aggregate view, and a documents sel…
shumkov Oct 30, 2026
e23f49f
Merge remote-tracking branch 'origin/v5.1-dev' into shumkov/v51-f0-pr…
shumkov Oct 30, 2026
8bd3eb1
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Oct 30, 2026
cfa1125
Merge remote-tracking branch 'origin/v5.1-dev' into shumkov/v51-f0-pr…
shumkov Oct 30, 2026
45e3895
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Oct 30, 2026
7c2638b
Merge remote-tracking branch 'origin/v5.1-dev' into shumkov/v51-f0-pr…
shumkov Nov 3, 2026
0056bab
Merge branch 'shumkov/v51-f0-pr2-document-request-version' into shumk…
shumkov Nov 3, 2026
68565fd
Merge remote-tracking branch 'origin/v5.1-dev' into shumkov/v51-f0-pr…
shumkov Nov 4, 2026
d8fcfb7
test(sdk): pin that a window past its ttl is left to the answer's blo…
shumkov Nov 4, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,10 @@ pub fn key_element_clauses(
)
}

/// [`aggregate_where_clauses`] of `request` before it is sent, its pending
/// window selections left unresolved: a relative time selection resolves only
/// against the answer's signed block time. Resolving a selection adds an
/// equality pin alone, which can add a refusal but never lift one, so whatever
/// this refuses the verifier refuses too.
/// [`aggregate_where_clauses`] of `request` before it is sent. Callers pass the
/// request with its pending window selections resolved, as the verifier resolves
/// them (`DocumentQuery::resolved_for_checking`), so whatever this refuses the
/// verifier refuses too.
pub(super) fn aggregate_request_where_clauses(
request: &DocumentQuery,
folds_entries: bool,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,11 @@ pub(super) fn check_average_request(
) -> Result<(), drive_proof_verifier::Error> {
request.ensure_no_sub_queries()?;
assert_select_is_avg(request)?;
let (resolved, _) = request.resolved_for_checking()?;
let request = &resolved;
let where_clauses = aggregate_request_where_clauses(request, folds_entries, platform_version)?;
resolve_sum_mode(&request.group_by, &where_clauses).map(|_| ())
resolve_sum_mode(&request.group_by, &where_clauses)?;
request.ensure_no_having()
}

/// Verify an AVG-shape proof and return per-branch `AverageEntry`s.
Expand Down
Loading
Loading