Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
223 commits
Select commit Hold shift + click to select a range
49ad468
chore(platform)!: bump rust-dashcore to 719de34b (secp256k1 0.33)
PastaPastaPasta Sep 23, 2026
b3904ee
fix(wallet): use upstream late transaction accounting corrections
lklimek Sep 28, 2026
a72737a
fix(swift-sdk): reconcile persisted Core transaction accounting
lklimek Sep 28, 2026
c4a3be4
fix(swift-sdk): exclude contact TXOs from history accounting
lklimek Sep 28, 2026
60e1f6d
fix(wallet): reconcile persisted Core transaction accounting
lklimek Sep 28, 2026
82cec94
refactor(wallet): pin minimal Core transaction accounting fix
lklimek Sep 28, 2026
85deb41
test(drive): track latest protocol version in grovedb structure snapshot
PastaPastaPasta Sep 28, 2026
7b63fc6
ci: bootstrap trusted publisher before feature runner adoption
infraclaw-dash Sep 29, 2026
37ea1bb
Merge branch 'v4.3-dev' into fix/pr-5126
lklimek Sep 29, 2026
e2fd47d
Merge pull request #5175: bootstrap trusted CI image publisher
ktechmidas Sep 29, 2026
e80b55e
Merge remote-tracking branch 'origin/v4.3-dev' into fix/pr-5126
lklimek Sep 29, 2026
c0425f7
fix(platform-wallet-storage): restore confirmed spends before wallet …
lklimek Sep 29, 2026
9c8dff2
fix(platform-wallet-storage): keep each replayed UTXO in one funds ac…
lklimek Sep 29, 2026
4b80513
fix(platform-wallet-storage): never load contact-only outputs as spen…
lklimek Sep 29, 2026
3d04bb0
fix(swift-sdk): skip load-time accounting repair inside an open chang…
lklimek Sep 29, 2026
55730ff
Merge remote-tracking branch 'origin/v4.3-dev' into fix/pr-5126
lklimek Sep 30, 2026
9766169
fix(platform-version): select folded DRIVE_ABCI_QUERY_VERSIONS_V2 in …
lklimek Sep 30, 2026
28796ac
fix(platform-wallet): drop unused IdentityGettersV0 import in dpns
lklimek Sep 30, 2026
c2a5765
test(drive): regenerate GroveDB structure for protocol version 15
lklimek Sep 30, 2026
c4a5b23
fix(platform-wallet-storage)!: harden wallet history restore after #5…
lklimek Sep 30, 2026
1279864
fix(platform-wallet-storage): gate V019 blob length before reading it…
lklimek Sep 30, 2026
b4b7366
fix(platform-wallet): let the higher-ranked record win account coales…
lklimek Sep 30, 2026
fcfa464
test(swift-sdk): expect the load-time accounting reads before the loc…
lklimek Sep 30, 2026
b004bc9
fix(swift-sdk): keep incoming amounts when a payment has foreign inputs
lklimek Sep 30, 2026
1c8ec82
test(swift-sdk): cover wallet-scoped direction and amounts
lklimek Sep 30, 2026
a70ee60
fix(platform-wallet-storage): validate birth height before scheduling…
lklimek Sep 30, 2026
c0f3a4c
fix(platform-wallet): classify asset locks as internal on the live path
lklimek Sep 30, 2026
6e82bf1
test(platform-wallet): pin live-fold accounting for non-asset-lock tr…
lklimek Sep 30, 2026
7002582
docs(swift-sdk): point the direction rule comment at wallet_direction
lklimek Sep 30, 2026
a1f46c0
Merge branch 'v5.1-dev' into fix/structure-tests-latest-protocol
PastaPastaPasta Oct 1, 2026
cbed68d
test(drive): regenerate grovedb structure snapshot after v5.0-dev merge
PastaPastaPasta Oct 1, 2026
5e74f42
Merge branch 'v5.1-dev' into fix/pr-5126
lklimek Oct 1, 2026
b1610d3
fix(platform-wallet-storage): ignore witness-only body differences fo…
lklimek Oct 1, 2026
a4e1c3f
refactor(platform-wallet): share the net-amount formula with the SQLi…
lklimek Oct 1, 2026
be7f8ec
fix(swift-sdk): read account wallets through the Optional cast in acc…
lklimek Oct 1, 2026
628efc3
test(drive): relabel team-action layers in grovedb-structure.json for…
lklimek Oct 1, 2026
f78bccb
perf(platform-wallet): index accounted outputs once in wallet accounting
lklimek Oct 1, 2026
3eff6f6
Merge branch 'v5.1-dev' into fix/pr-5126
lklimek Oct 2, 2026
aec5bb8
Merge remote-tracking branch 'origin/fix/structure-tests-latest-proto…
lklimek Oct 2, 2026
bfbaf31
Merge branch 'v5.1-dev' into fix/structure-tests-latest-protocol
lklimek Oct 2, 2026
b042573
Merge remote-tracking branch 'origin/fix/structure-tests-latest-proto…
lklimek Oct 2, 2026
defafa2
fix(platform-wallet-storage): rebuild spend marks for height-only fun…
lklimek Oct 2, 2026
0f09a3a
fix(platform-wallet-storage): settle InstantSend conflicts regardless…
lklimek Oct 2, 2026
bd49cfe
fix(platform-wallet-storage): gate owned-output script length before …
lklimek Oct 2, 2026
d82b65e
docs(swift-sdk): mark shared-wallet amount gap for Rust-sourced accou…
lklimek Oct 2, 2026
999a9ae
Merge branch 'v5.1-dev' into fix/structure-tests-latest-protocol
lklimek Oct 2, 2026
536a004
Merge branch 'v5.0-dev' into chore/bump-rust-dashcore-secp-033
PastaPastaPasta Oct 5, 2026
bf382b1
fix(sdk)!: require Node.js 20 for the WASM packages
PastaPastaPasta Oct 5, 2026
1b82309
fix(sdk): move v5.0-dev's encrypted-for and moderation-charter code t…
PastaPastaPasta Oct 5, 2026
754e7fa
Merge remote-tracking branch 'origin/fix/structure-tests-latest-proto…
lklimek Oct 5, 2026
4e632ce
fix(platform-wallet-storage): sweep confirmed conflicts after history…
lklimek Oct 5, 2026
97179c6
fix(platform-wallet-storage): reconcile settled history across accounts
lklimek Oct 5, 2026
8d6d9e7
fix(swift-sdk): preserve wallet accounting when participants change
lklimek Oct 5, 2026
9894a0c
fix(wallet-storage): preserve durable claims during replay recovery
lklimek Oct 5, 2026
9cd322f
Merge remote-tracking branch 'origin/v5.1-dev' into fix/pr-5126
lklimek Oct 5, 2026
a2b6f50
fix(wallet-storage): retain unknown claims during startup repair
lklimek Oct 5, 2026
f2e572b
test(wallet-storage): verify clean event-driven spend restoration
lklimek Oct 6, 2026
5ee6f20
chore(platform)!: merge rust-dashcore migration and pin spent-claim API
lklimek Oct 6, 2026
ad2b8c2
chore: port rust-dashcore migration to v5.1
lklimek Oct 6, 2026
d397edb
chore: stack wallet accounting repairs on the v5.1 rust-dashcore port
lklimek Oct 6, 2026
d3861e4
chore: merge v5.1-dev into rust-dashcore migration
lklimek Oct 6, 2026
efa487d
fix(sdk)!: require Node 20 for legacy WASM-DPP consumers
lklimek Oct 6, 2026
3271536
chore: move Node runtime requirements to a separate PR
lklimek Oct 6, 2026
d9149f1
chore(platform): pin rust-dashcore to merged dev
lklimek Oct 6, 2026
c0b4b97
chore!: require Node.js >=22 for JS packages and >=24 for dashmate (#…
lklimek Oct 6, 2026
938b60f
Merge branch 'v5.1-dev' into chore/rust-dashcore-1112-v5.1
lklimek Oct 7, 2026
7c73e98
fix(platform-wallet): retain SPV client and track shutdown through ca…
lklimek Oct 7, 2026
4045c13
refactor: share rust-dashcore BLS backend through dpp::bls (#5320)
lklimek Oct 7, 2026
8377b64
fix(platform-wallet)!: tell a retryable SPV stop from one that needs …
Claudius-Maginificent Oct 8, 2026
9af2033
chore(deps)!: pin rust-dashcore to BLS compatibility fix
lklimek Oct 8, 2026
41e9453
chore(deps): pin rust-dashcore to legacy serde restoration
lklimek Oct 9, 2026
1dbcaaf
fix(drive-abci): preserve quorum key storage independently of serde
lklimek Oct 9, 2026
d8b911d
fix(wallet-ffi): adapt platform node ID hashing to rust-dashcore
lklimek Oct 9, 2026
c1c7b09
fix(test-suite): wait for rotated quorum publication before retrying …
lklimek Oct 9, 2026
069a5ca
fix(dpp): require WASM-compatible blst for external consumers
lklimek Oct 9, 2026
cbb694d
test(platform): freeze historical storage and signing vectors
lklimek Oct 9, 2026
f475f72
chore(deps): pin rust-dashcore to PR 1149
lklimek Oct 9, 2026
7ee8f7b
feat(platform-wallet): return dash-spv's verification status with an …
PastaPastaPasta Oct 11, 2026
6744658
chore: merge v5.1-dev and preserve historical compatibility tests
lklimek Oct 12, 2026
f29c092
chore: merge remote quorum verification status update
lklimek Oct 12, 2026
206e86c
fix(platform-wallet-storage): cache the replay claim and swept asset-…
lklimek Oct 12, 2026
dfe9064
fix(platform-wallet-storage): record the spender of a new mempool res…
lklimek Oct 12, 2026
9e41acd
fix(platform-wallet-storage): keep unsafe unconfirmed amounts from fa…
lklimek Oct 12, 2026
981141e
test(platform-wallet-storage): plant writer-encoded outpoints in reco…
lklimek Oct 12, 2026
9183842
build!: pin rust-dashcore to dev d036d844
lklimek Oct 12, 2026
7ada303
chore: merge chore/rust-dashcore-1112-v5.1 into fix/pr-5126
lklimek Oct 12, 2026
d280e72
fix(platform-wallet): keep restored spend claims for accounts added l…
lklimek Oct 12, 2026
4917d07
perf(platform-wallet-storage): reuse cached statements in the replay …
lklimek Oct 12, 2026
251a9b6
fix(platform-wallet-storage): settle set-aside mempool records agains…
lklimek Oct 12, 2026
f29dbd4
fix(platform-wallet-storage): let V019 migrate past an unaccountable …
lklimek Oct 12, 2026
1c86da2
fix(platform-wallet-storage): store a mempool record whose net does n…
lklimek Oct 12, 2026
8624543
docs: name the rust-dashcore#1112 pin in the changelog
lklimek Oct 12, 2026
f49527f
fix(platform-wallet-storage): attribute a held sweep input to its sur…
lklimek Oct 12, 2026
f1bcefe
fix(platform-wallet-storage): keep a mempool record with unsafe owned…
lklimek Oct 12, 2026
c225ab6
fix(platform-wallet-storage): gate spent-claim blob lengths before re…
lklimek Oct 12, 2026
60ca7e2
perf(platform-wallet-storage): sweep at load only where an unconfirme…
lklimek Oct 12, 2026
3b3e073
fix(platform-wallet-storage): gate spent-claim lengths in the reading…
lklimek Oct 12, 2026
a3c1e23
perf(platform-wallet-storage): replay InstantSend-locked records befo…
lklimek Oct 12, 2026
2ee7daf
perf(platform-wallet-storage): hand each planned sweep only what it c…
lklimek Oct 12, 2026
9d29de2
perf(platform-wallet-storage): replay the mempool ancestors of a fina…
lklimek Oct 13, 2026
6633010
perf(platform-wallet-storage): plan conflict sweeps without the walle…
lklimek Oct 13, 2026
484b196
fix(platform-wallet-storage): restore a set-aside record into every a…
lklimek Oct 13, 2026
d6465c1
fix(platform-wallet-storage): restore a record with unsafe input amou…
lklimek Oct 13, 2026
3d4ef96
perf(platform-wallet-storage): cache the contact-ownership probe stat…
lklimek Oct 13, 2026
4db12aa
perf(platform-wallet-storage): cache the prior spend-state probe stat…
lklimek Oct 13, 2026
7d192bf
refactor(swift-sdk): move the SwiftData transaction accounting to its…
lklimek Oct 13, 2026
1b749e9
chore(platform)!: port rust-dashcore migration (secp256k1 0.33) to v5.1
PastaPastaPasta Sep 23, 2026
1aba0bd
chore(platform): pin rust-dashcore to merged dev
lklimek Oct 6, 2026
6e022c0
chore!: require Node.js >=22 for JS packages and >=24 for dashmate (#…
lklimek Oct 6, 2026
70c02af
fix(platform-wallet): retain SPV client and track shutdown through ca…
lklimek Oct 7, 2026
cdbeec5
refactor: share rust-dashcore BLS backend through dpp::bls (#5320)
lklimek Oct 7, 2026
80ee8f5
fix(platform-wallet)!: tell a retryable SPV stop from one that needs …
Claudius-Maginificent Oct 8, 2026
fc62159
chore(deps)!: pin rust-dashcore to BLS compatibility fix
lklimek Oct 8, 2026
1b804dd
chore(deps): pin rust-dashcore to legacy serde restoration
lklimek Oct 9, 2026
007a51f
fix(drive-abci): preserve quorum key storage independently of serde
lklimek Oct 9, 2026
b7a246c
fix(wallet-ffi): adapt platform node ID hashing to rust-dashcore
lklimek Oct 9, 2026
835f6af
fix(test-suite): wait for rotated quorum publication before retrying …
lklimek Oct 9, 2026
0a4ade5
fix(dpp): require WASM-compatible blst for external consumers
lklimek Oct 9, 2026
00b1c6c
test(platform): freeze historical storage and signing vectors
lklimek Oct 9, 2026
dd29a05
chore(deps): pin rust-dashcore to PR 1149
lklimek Oct 9, 2026
97baf6b
feat(platform-wallet): return dash-spv's verification status with an …
PastaPastaPasta Oct 11, 2026
8743c62
Merge branch 'v5.1-dev' into chore/rust-dashcore-1112-v5.1
lklimek Oct 12, 2026
50b28de
build!: pin rust-dashcore to dev d036d844
lklimek Oct 12, 2026
1bc426d
docs(platform-wallet): mark the unvalidated fork rewind in dash-spv
lklimek Oct 12, 2026
e26de73
chore: adopt the rewritten history of the base branch
lklimek Oct 13, 2026
7a48ab6
Merge branch 'chore/rust-dashcore-1112-v5.1' into fix/pr-5126
lklimek Oct 13, 2026
4f30e10
build!: pin rust-dashcore to dev 90359ed5
lklimek Oct 13, 2026
266f76b
feat(dpp): tell whether a BLS public key is the identity point
lklimek Oct 13, 2026
765c7e4
fix(platform-wallet-storage): gate stored widths before the claim sca…
lklimek Oct 13, 2026
691541a
chore: merge v5.1-dev into chore/rust-dashcore-1112-v5.1
lklimek Oct 13, 2026
912e06b
fix(platform-wallet): forward a noted chain-lock height to the core w…
lklimek Oct 13, 2026
39a6de0
chore: merge chore/rust-dashcore-1112-v5.1 and pin rust-dashcore to 9…
lklimek Oct 13, 2026
9774c72
revert(test-suite): drop the rotated-quorum proof retry
PastaPastaPasta Oct 13, 2026
e51d1ec
chore: merge final head of #5307 (9774c72d3c) into fix/pr-5126
lklimek Oct 14, 2026
6aacbf3
chore: merge v5.1-dev before the #5307 squash (6a3f081113) into fix/p…
lklimek Oct 14, 2026
35554cb
chore: record the #5307 squash merge (3b5e4a7dfb) in fix/pr-5126
lklimek Oct 14, 2026
1d003a9
docs(changelog): name the rust-dashcore#1112 revision fix/pr-5126 pins
lklimek Oct 14, 2026
052f100
feat(platform-wallet): expose the verdict a sweep gives a DashPay pay…
lklimek Oct 14, 2026
28158c6
fix(platform-wallet-storage): fail the sent payment of a transaction …
lklimek Oct 14, 2026
80332fa
test(platform-wallet): add shared core fixtures and table-drive proje…
lklimek Oct 14, 2026
3c44f56
test(platform-wallet-storage): share migrated wallet-db fixtures in h…
lklimek Oct 14, 2026
d8828e1
test(platform-wallet-storage): DRY the V019 migration tests
lklimek Oct 14, 2026
a7d8016
test(platform-wallet-storage): build replay tests from shared fixtures
lklimek Oct 14, 2026
cc24eed
test(platform-wallet-storage): table-drive the spent-rehydration scen…
lklimek Oct 14, 2026
3d1d0ee
test(platform-wallet-storage): table-drive clean-restart and constrai…
lklimek Oct 14, 2026
cf9fe4b
test(platform-wallet-storage): compact the replay-amount staging helper
lklimek Oct 14, 2026
f991080
refactor(platform-wallet-storage): share the frozen V019 history repa…
lklimek Oct 14, 2026
34deed4
refactor(platform-wallet-storage): reuse the live repair helpers in V019
lklimek Oct 14, 2026
bbd98f5
docs(platform-wallet-storage): name both guards of the shared V019 re…
lklimek Oct 14, 2026
19b2008
test(platform-wallet-storage): pin V019's repair of an asset lock wit…
lklimek Oct 14, 2026
6e63275
test(platform-wallet-storage): rescan a wallet whose Core history was…
lklimek Oct 14, 2026
4c450e7
fix(platform-wallet-storage)!: rebuild pre-V019 Core history by resca…
lklimek Oct 14, 2026
486e6a2
fix(platform-wallet-storage)!: renumber the Core rescan migration to …
lklimek Oct 14, 2026
62582b0
test(platform-wallet-storage): pin which asset-lock rows a conflict r…
lklimek Oct 14, 2026
6c3b7f8
docs(changelog): note the non-exhaustive WalletStorageError API change
lklimek Oct 14, 2026
8182993
chore: merge v5.1-dev into fix/pr-5126
lklimek Oct 16, 2026
a437848
build!: pin rust-dashcore to the rust-dashcore#1112 head 214f7d3e
lklimek Oct 16, 2026
fa110a1
test(platform-wallet-storage): rescan an upgraded wallet below its re…
lklimek Oct 16, 2026
3d0a7c3
chore: pin rust-dashcore for crypto API migration
lklimek Oct 21, 2026
34d93ec
refactor(wallet): adapt native crypto keys and preserve signature bytes
lklimek Oct 21, 2026
cccf3cc
refactor(ffi): adapt native bindings to typed Core cryptography
lklimek Oct 21, 2026
069207d
test(ffi): pin signer bytes across deterministic digests
lklimek Oct 21, 2026
f17cfde
refactor!: migrate Platform consumers to typed Core cryptography
lklimek Oct 21, 2026
43795f5
fix: adapt zeroizing key exports to signing slices
lklimek Oct 21, 2026
1e87670
fix(dpp): preserve identity public key parse errors
lklimek Oct 21, 2026
4625a62
fix(sdk): remove redundant voucher key reference
lklimek Oct 21, 2026
374d0c6
fix(wallet): convert provider keys at crypto API boundaries
lklimek Oct 21, 2026
dde93e9
fix(wallet): use native secret export autoderef
lklimek Oct 21, 2026
6aee11e
fix: adapt WASM encryption keys and seeded node test keys
lklimek Oct 21, 2026
4ad35d0
fix(wasm): retain private key owner during scalar conversion
lklimek Oct 21, 2026
a9018cd
fix(ffi): preserve key ownership and use typed scalar parsers
lklimek Oct 21, 2026
5c5dfa0
style(wasm): apply crate edition import ordering
lklimek Oct 21, 2026
549d013
test(dpp): assert transparent legacy key parsing errors
lklimek Oct 21, 2026
675a7ea
refactor(dpp): use Core ECDSA verification directly
lklimek Oct 21, 2026
9f28131
test(dpp): assert typed crypto errors and clarify nonce parity
lklimek Oct 21, 2026
d14aa58
test(swift-sdk): retain fixture writer while taking migration snapshot
lklimek Oct 21, 2026
eac4f4c
fix(wallet): merge typed crypto base into transaction accounting
lklimek Oct 21, 2026
0044a40
chore(deps): update rust-dashcore to latest 0.46 dev
lklimek Oct 21, 2026
c653e46
Merge updated rust-dashcore prerequisite into wallet recovery
lklimek Oct 21, 2026
5441a2b
test(wallet-storage): derive sweep fixture IDs from transaction bodies
lklimek Oct 21, 2026
f750022
fix(wallet-storage): reject inconsistent transaction bodies before re…
lklimek Oct 21, 2026
292b510
Merge released crypto prerequisite into wallet recovery
lklimek Oct 21, 2026
dae6045
fix(wallet-storage): withhold unsupported drain operation capability
lklimek Oct 21, 2026
519f7a8
fix(platform-wallet): verify pending coin reservation authorization
lklimek Oct 21, 2026
cdaf796
fix(platform-wallet): preserve noncanonical signed spend authorization
lklimek Oct 21, 2026
06cf4f8
test(platform-wallet): cover nonstandard signed reservation hash flags
lklimek Oct 21, 2026
c7d09cb
fix(wallet-storage): authenticate restored claims and checkpoint prom…
lklimek Oct 22, 2026
6b254b6
fix(wallet-storage): index spend-claim ownership once per load
lklimek Oct 22, 2026
449d31b
fix(wallet-storage)!: keep unmined spend evidence through the V021 re…
lklimek Oct 22, 2026
4766303
test(wallet-storage): pin how kept unmined spends settle after the V0…
lklimek Oct 22, 2026
4e135b8
Merge remote-tracking branch 'origin/v5.1-dev' into merge/pr5150-v51-…
lklimek Oct 23, 2026
b1d19ac
refactor(platform-wallet-storage)!: renumber core transaction account…
lklimek Oct 23, 2026
29c1abe
fix(platform-wallet-storage): index every input of kept pending recor…
lklimek Oct 23, 2026
3ff702d
fix(platform-wallet-storage): index retained coins by funding txid an…
lklimek Oct 23, 2026
19f60d2
fix(platform-wallet-storage): restore set-aside records where their c…
lklimek Oct 23, 2026
841ede2
docs(changelog): note the breaking WalletStorageError change
lklimek Oct 23, 2026
fd8b8ee
test(platform-wallet-storage): widen scaling bounds and pin the V020 …
lklimek Oct 23, 2026
ef7910e
fix(platform-wallet-storage): make V020 honour the load policy on unr…
lklimek Oct 23, 2026
4247fed
Merge commit '132ae31a1356d035cd8326f27c1109685090a71d' into stack/5150
lklimek Oct 23, 2026
5b26750
test(platform-wallet): pin a no-change asset lock's row when a block …
lklimek Oct 23, 2026
48dad85
fix(platform-wallet): fold the manager's held slices into a block's w…
lklimek Oct 23, 2026
d2395b5
test(platform-wallet): pin which held slices a block's wallet-level r…
lklimek Oct 23, 2026
e66df27
fix(platform-wallet-storage): harden V020 reads and preserve its hist…
lklimek Oct 23, 2026
f573d63
fix(platform-wallet-storage): repair authorization by persisted trans…
lklimek Oct 23, 2026
09abc40
fix(platform-wallet-storage): freeze V019 codec and recover corrupt m…
lklimek Oct 23, 2026
08f7c55
fix(platform-wallet-storage): preserve survivor evidence across doubl…
lklimek Oct 23, 2026
f72313e
fix(platform-wallet-storage): guard live migration codec with immutab…
lklimek Oct 23, 2026
e67b481
Merge branch 'v5.1-dev' into fix/pr-5126
lklimek Oct 27, 2026
2197dc2
Merge remote-tracking branch 'origin/v5.1-dev' into fix/pr-5126
lklimek Oct 28, 2026
01baa72
chore: merge v5.1-dev into PR 5150
lklimek Nov 5, 2026
790f05f
refactor(platform-wallet): isolate history accounting from spend replay
lklimek Nov 5, 2026
feea8ad
fix(wallet): preserve held-sibling credit verdicts in buffered blocks
lklimek Nov 5, 2026
ae2f163
fix(wallet-storage): abort V020 recovery on transient repair errors
lklimek Nov 5, 2026
78bd9a8
fix(wallet-storage): read historical asset unlock identities
lklimek Nov 5, 2026
e26ffe3
test(wallet): assert complete coalesced history snapshots
lklimek Nov 5, 2026
f8d15b0
test(wallet): use canonical identity in coalescing snapshots
lklimek Nov 5, 2026
c796d07
chore: merge v5.1-dev into PR 5150
lklimek Nov 6, 2026
a179271
fix(platform-wallet): drop Hash trait imports unused after the rust-d…
lklimek Nov 6, 2026
50eb8b3
style(platform-wallet-storage): drop blank line left by the removed H…
lklimek Nov 6, 2026
bfe6e57
fix(platform-wallet-storage): keep WalletStorageError exhaustive
lklimek Nov 9, 2026
d850f48
docs(book): require exhaustive workspace error enums
lklimek Nov 9, 2026
501e5e0
Merge branch 'v5.1-dev' into fix/pr-5126
lklimek Nov 9, 2026
2d025ae
chore: merge v5.1-dev into fix/pr-5126
lklimek Nov 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Platform uses data contracts to define application data schemas:
Use LF, UTF‑8, and a final newline.
- JS/TS: ESLint (Airbnb/TypeScript rules via package configs). Use camelCase for variables/functions, PascalCase for classes; prefer kebab-case filenames within JS packages.
- Rust: Follow rustfmt defaults; keep code clippy-clean. Modules `snake_case`, types `PascalCase`, constants `SCREAMING_SNAKE_CASE`.
- Architecture rules for Rust and its consumers (FFI, WASM, Swift and Kotlin SDKs) live in The Dash Platform Book (`book/`). Read [book/src/contributing/coding-conventions.md](book/src/contributing/coding-conventions.md) before changing Rust, FFI, WASM, Swift or Kotlin code, and check the change against it before finishing; it states each rule, why it exists, and links to the chapter with the mechanics. Key rules: new behaviour is a new `vN` selected only by the unreleased protocol version's tables, and a shipped `vN` is edited in place only when the edit provably cannot modify consensus there, with the reason in the PR description's "In-place changes to shipped generations" section; numbers go in `SystemLimits`, fees in named `FEE_VERSION*` schedules; `platform_version` is the last parameter; no `unwrap`/`expect` on block-execution paths (a panic halts the chain); imports at the top, no inline `crate::` paths; latest-generation tests use `PlatformVersion::latest()`; FFI, WASM, Swift and Kotlin wrappers marshal rather than decide; validation lives once in its owner and is not duplicated outside it.
- Architecture rules for Rust and its consumers (FFI, WASM, Swift and Kotlin SDKs) live in The Dash Platform Book (`book/`). Read [book/src/contributing/coding-conventions.md](book/src/contributing/coding-conventions.md) before changing Rust, FFI, WASM, Swift or Kotlin code, and check the change against it before finishing; it states each rule, why it exists, and links to the chapter with the mechanics. Key rules: new behaviour is a new `vN` selected only by the unreleased protocol version's tables, and a shipped `vN` is edited in place only when the edit provably cannot modify consensus there, with the reason in the PR description's "In-place changes to shipped generations" section; numbers go in `SystemLimits`, fees in named `FEE_VERSION*` schedules; `platform_version` is the last parameter; no `unwrap`/`expect` on block-execution paths (a panic halts the chain); imports at the top, no inline `crate::` paths; no `#[non_exhaustive]` on the workspace's own error enums, and per-variant matches over them list every variant instead of `_` (a new variant must break the build); latest-generation tests use `PlatformVersion::latest()`; FFI, WASM, Swift and Kotlin wrappers marshal rather than decide; validation lives once in its owner and is not duplicated outside it.

## Testing Guidelines
- Unit/integration tests live alongside each package (e.g., `packages/<name>/tests`). E2E lives in `packages/platform-test-suite`.
Expand Down
16 changes: 16 additions & 0 deletions book/src/contributing/coding-conventions.md
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,22 @@ or `ExecutionError` means the build is wrong, data is corrupt, or an API was
misused. Never return a consensus error for an internal failure or an internal
error for a user mistake; the block loop treats the two classes differently.

### Error enums stay exhaustive

Do not mark the workspace's own error enums `#[non_exhaustive]`. A `match`
that decides something per variant (transient or not, an FFI error code, a
user-facing message) lists every variant instead of ending in `_`. A new
variant must break the build at each such `match`, so the author of the
variant sees every caller in the compiler output and handles it in the same
Comment thread
lklimek marked this conversation as resolved.
Resolved
PR. With
`#[non_exhaustive]`, callers outside the defining crate need a wildcard arm,
and that arm silently absorbs every later variant: the code still compiles and
the new failure takes whatever path the wildcard picked, typically a generic
error or a test panic, without anyone being told. The workspace crates ship
together, so the compile break costs nothing for a consumer outside the crate.
Comment thread
lklimek marked this conversation as resolved.
Resolved
A wildcard is correct only over enums from other repositories that are
`#[non_exhaustive]` upstream (for example `rusqlite::ErrorCode`).

## Module layout and style

- **One method, one directory.** `method_name/mod.rs` holds the public
Expand Down
2 changes: 2 additions & 0 deletions packages/rs-platform-wallet-storage/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ apple-native-keyring-store = { version = "=1.0.0", features = ["keychain"], opti
windows-native-keyring-store = { version = "=1.0.0", optional = true }

[dev-dependencies]
# Safe SQLite fault injection for migration rollback tests.
rusqlite = { version = "0.41", features = ["functions"] }
# `test-utils` reaches `provider_key_test_wallet`, shared with
# `platform-wallet`'s own `rebuild_provider_key_account` tests — see its use
# in `sqlite/provider_accounts.rs`'s test module. It also exposes
Expand Down
33 changes: 32 additions & 1 deletion packages/rs-platform-wallet-storage/SCHEMA.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Any `meta_*` row whose parent object does not exist — because it was never cre

A future garbage-collection pass is expected to reap orphan metadata — rows with no live parent object older than approximately one week — but no such GC is implemented yet. Callers should not rely on orphan metadata persisting forever, nor assume it will be cleaned up promptly. `meta_global` is intentionally parentless and always survives.

The tables are split into five domain diagrams below. `WALLETS` is the root anchor and appears in each diagram. The diagrams cover 21 of V001's 23 tables; `pending_contact_crypto` and `ignored_senders` appear in the [Tables](#tables) section but are not diagrammed. They show the V001 tables as amended in place by every later migration that changes one of them (the current `core_utxos`, `core_transactions`, `platform_addresses`, and `asset_locks` shapes). Nine tables added by later migrations are not yet diagrammed here: `core_address_pool`, `meta_data_versions`, and `meta_store_generation` (V009, plus its V010–V011 `core_address_pool` columns), `invitations` (V003), `shielded_viewing_keys` (V013), `dpns_name_states` (V005), `tracked_masternodes` (V006), and the `identity_scan_states` / `identity_scan_failed_indices` pair (V017) — see the [Migrations](#migrations) log for what each adds in the meantime.
The tables are split into five domain diagrams below. `WALLETS` is the root anchor and appears in each diagram. The diagrams cover 21 of V001's 23 tables; `pending_contact_crypto` and `ignored_senders` appear in the [Tables](#tables) section but are not diagrammed. They show the V001 tables as amended in place by every later migration that changes one of them (the current `core_utxos`, `core_transactions`, `platform_addresses`, and `asset_locks` shapes). Eleven tables added by later migrations are not yet diagrammed here: `core_address_pool`, `meta_data_versions`, and `meta_store_generation` (V009, plus its V010–V011 `core_address_pool` columns), `invitations` (V003), `shielded_viewing_keys` (V013), `dpns_name_states` (V005), `tracked_masternodes` (V006), the `identity_scan_states` / `identity_scan_failed_indices` pair (V017), and `core_transaction_inputs` / `core_transaction_record_originals` (V021) — see the [Migrations](#migrations) log for what each adds in the meantime.

## Diagram 1 — Core / L1 (Bitcoin/Dash layer)

Expand Down Expand Up @@ -440,6 +440,36 @@ held spent and is permanently outside the collector's reach.
the collector's per-round scan touches tombstones rather than the
wallet's full spent history.

### `core_transaction_inputs`

V021 indexes every raw input of each stored transaction, even when its ownership
is not yet known. New historical TXOs locate affected records through this index.
The shared wallet accounting rule updates input/output details, net amount and
direction; it never changes coins, spend claims or finality. Contact-only scripts
are excluded from wallet ownership.

V021 also indexes and repairs existing mined and unmined records using retained
TXOs. Unknown historical ownership is filled when later observations supply it.
No rows are deleted and no sync checkpoint is rewound. The typed backfill uses
the live record decoder, with immutable V019 fixtures pinning codec compatibility.
Type, identifier-width and blob-size gates precede materialization. Strict failure
rolls back the entire migration; Recovery skips an unreadable record without
changing its bytes or partially indexing it. Each record's repair has a savepoint.

- PK: `(wallet_id, txid, outpoint)`.
- FK: `(wallet_id, txid) → core_transactions(wallet_id, txid) ON DELETE CASCADE`.
- Index: `idx_core_transaction_inputs_outpoint(wallet_id, outpoint)`.

### `core_transaction_record_originals`

Append-only archive of the first pre-repair `core_transactions.record_blob`.
Migration and runtime repairs copy original bytes with `INSERT OR IGNORE` before
changing accounting. Later repairs cannot replace this recovery copy.

- PK: `(wallet_id, txid)`.
- FK: `wallet_id → wallets(wallet_id) ON DELETE CASCADE`. The original survives
deletion of its transaction row.

### `core_instant_locks`

Instant-lock blobs for transactions that are broadcast but not yet
Expand Down Expand Up @@ -851,3 +881,4 @@ table-rebuild migration, as V004 does.
| V018 | `V018__identity_hard_delete.rs` | Retires identity tombstoning. Adds `cascade_children_on_identity_delete` (brooms `identity_keys` / `contacts` / `ignored_senders` / `pending_contact_crypto` by the deleted identity id, covering the rows no live FK reaches) plus its access-path indexes `idx_contacts_owner`, `idx_ignored_senders_owner`, and `idx_pending_contact_crypto_owner`; purges every already-tombstoned identity and its dependents; drops `identities.tombstoned`. |
| V019 | `V019__asset_lock_operation_id.rs` | Adds the nullable `asset_locks.operation_id BLOB` column (CHECK: NULL or exactly 16 bytes) that correlates a wallet-drain operation with its funding outpoint; the lifecycle blob is untouched. Adds the unique partial index `asset_locks_wallet_operation_id` on `(wallet_id, operation_id) WHERE operation_id IS NOT NULL` and the `asset_locks_operation_id_immutable` BEFORE UPDATE trigger, which aborts any change to a non-NULL `operation_id`. Purely additive; existing rows read back NULL. |
| V020 | `V020__asset_lock_shielded_recipient.rs` | Adds the nullable `asset_locks.shielded_recipient BLOB` column (CHECK: NULL or exactly 43 bytes, the raw Orchard address) recording the recipient a shielded asset-lock funding was built to pay, so a resume after restart pays that recipient and refuses another; the lifecycle blob is untouched. Adds the `asset_locks_shielded_recipient_immutable` BEFORE UPDATE trigger, which aborts any change to a non-NULL `shielded_recipient`. Purely additive; existing rows read back NULL and keep accepting the resuming caller's recipient. |
| V021 | `V021__core_transaction_accounting.rs` | Adds the raw-input index and original-record archive. Backfills all decodable history and repairs accounting from retained TXOs, preserving coins, claims, checkpoints and unrelated wallet state. |
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
//! Index historical inputs and preserve original records before accounting repair.

pub fn migration() -> String {
"CREATE TABLE core_transaction_inputs (
wallet_id BLOB NOT NULL,
txid BLOB NOT NULL,
outpoint BLOB NOT NULL,
PRIMARY KEY (wallet_id, txid, outpoint),
FOREIGN KEY (wallet_id, txid) REFERENCES core_transactions(wallet_id, txid) ON DELETE CASCADE
);
CREATE INDEX idx_core_transaction_inputs_outpoint
ON core_transaction_inputs(wallet_id, outpoint);
CREATE TABLE core_transaction_record_originals (
wallet_id BLOB NOT NULL,
txid BLOB NOT NULL,
record_blob BLOB NOT NULL,
PRIMARY KEY (wallet_id, txid),
FOREIGN KEY (wallet_id) REFERENCES wallets(wallet_id) ON DELETE CASCADE
);"
.to_owned()
}
44 changes: 44 additions & 0 deletions packages/rs-platform-wallet-storage/src/sqlite/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,38 @@ pub enum WalletStorageError {
blob_height: Option<u32>,
},

/// An incoming transaction record reuses a stored txid with a body whose
/// txid-committed content differs (witness-only differences are not a
/// conflict); neither copy is trusted to replace the other.
#[error(
"transaction {txid} in wallet {} arrived with a body whose txid differs from the stored one",
hex::encode(wallet_id)
)]
TransactionBodyConflict {
wallet_id: [u8; 32],
txid: dashcore::Txid,
},

/// The `wallets.network` label is not one this build knows, so stored
/// scripts cannot be turned back into addresses.
#[error(
"wallet {} has unknown network label {label:?}",
hex::encode(wallet_id)
)]
UnknownWalletNetwork { wallet_id: [u8; 32], label: String },

/// A transaction's net amount (owned outputs minus owned inputs) does not
/// fit the `i64` the record stores.
#[error(
"net amount {value} of transaction {txid} in wallet {} does not fit i64",
hex::encode(wallet_id)
)]
NetAmountOverflow {
wallet_id: [u8; 32],
txid: dashcore::Txid,
value: i128,
},

/// A blob exceeded the decode allocation cap (default 16 MiB).
/// Separate from [`Self::BlobDecode`] so operators can distinguish an
/// oversize blob from a structural decode failure.
Expand Down Expand Up @@ -754,6 +786,9 @@ impl WalletStorageError {
| Self::AssetLockEntryMismatch { .. }
| Self::AssetLockStatusMismatch { .. }
| Self::CoreTransactionEntryMismatch { .. }
| Self::TransactionBodyConflict { .. }
| Self::UnknownWalletNetwork { .. }
| Self::NetAmountOverflow { .. }
| Self::BlobTooLarge { .. }
| Self::IntegerOverflow { .. }
| Self::RehydrationPoolMismatch { .. }
Expand Down Expand Up @@ -799,6 +834,11 @@ impl WalletStorageError {
// Typed re-mapping of an FK violation — same class as the raw
// `ConstraintViolation` above, so it reports the same kind.
Self::IdentityKeyWalletMismatch { .. } => PersistenceErrorKind::Constraint,
// History invariants checked in Rust on the write path: the incoming
// record contradicts stored history, so the data is wrong, not the engine.
Self::TransactionBodyConflict { .. } | Self::NetAmountOverflow { .. } => {
PersistenceErrorKind::Constraint
}
// Refinery surfaces FK / constraint problems through rusqlite;
// if that path leaks through here the typed variant lives in
// `Self::Migration`, which we leave as `Fatal` since a
Expand Down Expand Up @@ -858,6 +898,7 @@ impl WalletStorageError {
| Self::AssetLockEntryMismatch { .. }
| Self::AssetLockStatusMismatch { .. }
| Self::CoreTransactionEntryMismatch { .. }
| Self::UnknownWalletNetwork { .. }
| Self::BlobTooLarge { .. }
| Self::IntegerOverflow { .. }
| Self::RehydrationPoolMismatch { .. }
Expand Down Expand Up @@ -939,6 +980,9 @@ impl WalletStorageError {
Self::AssetLockEntryMismatch { .. } => "asset_lock_entry_mismatch",
Self::AssetLockStatusMismatch { .. } => "asset_lock_status_mismatch",
Self::CoreTransactionEntryMismatch { .. } => "core_transaction_entry_mismatch",
Self::TransactionBodyConflict { .. } => "transaction_body_conflict",
Self::UnknownWalletNetwork { .. } => "unknown_wallet_network",
Self::NetAmountOverflow { .. } => "net_amount_overflow",
Self::BlobTooLarge { .. } => "blob_too_large",
Self::IntegerOverflow { .. } => "integer_overflow",
Self::RehydrationPoolMismatch { .. } => "rehydration_pool_mismatch",
Expand Down
Loading
Loading