Repository navigation
Description
Summary
#5890 pins rust-dashcore dev at 6b985d1f (the merge of dashpay/rust-dashcore#1391). The pin should move to a later dev commit, at or after d659dcd1, which needs two changes in Platform.
Why the pin stopped at 6b985d1f
dashpay/rust-dashcore#1379 makes dashcore::signer::verify_data_signature refuse a high-S ECDSA signature itself, with the error "the signature has a high S value".
packages/rs-dpp/src/util/ecdsa.rs assumes the older order: dashcore verifies the signature, then Platform refuses a high-S one with EcdsaError::VerifyFailed ("signature verification failed"). That text ends up in InvalidStateTransitionSignatureError and BasicECDSAError.
With a pin past #1379 the dpp test state_transition::tests::should_refuse_a_high_s_ecdsa_signature_at_every_protocol_version fails:
- its sanity check expects
dashcorealone to verify the high-S twin; - the error message of a refused high-S signature changes.
Seen in CI on #5890 with the pin at d659dcd1, and reproduced locally.
What to do
-
Adapt
packages/rs-dpp/src/util/ecdsa.rsso a high-S signature is still refused with the same error as before at every protocol version, and update the test's sanity check. -
Move the eight
revlines in the rootCargo.tomlto the chosendevcommit and refreshCargo.lock. -
Drop the two helpers copied into
packages/rs-platform-wallet/src/wallet/outpoint_locks.rsand call the ones feat(key-wallet): exposemasternode_collateralandholds_coinrust-dashcore#1400 made public instead:registration_collateral->key_wallet::wallet::managed_wallet_info::masternode_collateralPlatformWalletInfo::holds_coin->ManagedWalletInfo::holds_coin
The upstream
holds_coinalso counts a coin kept aside as spent, so a tracked masternode's collateral whose spend a fork drops is recognised as held. The local copy looks only at unspent coins. Commite0f5d97beaon the feat(platform-wallet): keep masternode collateral out of coin selection #5890 branch has this change; it was reverted there only because of the pin.
Notes
- Step 1 touches code on the state transition signature path, so it needs the "In-place changes to shipped generations" reasoning in the PR description.
- Other
devcommits between6b985d1fandd659dcd1(chore(dashmate): support new docker version #1393, chore: update tenderdash to v0.13.1 #1392, chore(release): update changelog and bump version to 0.25.0-dev.23 #1388, chore: npm audit fix #1321) compiled against the whole workspace; the full test suite was not run past the first failure.
Activity