Skip to content

dashmate group core reindex skips the DKG-safe stop check and hides which node failed #5857

Open

Description

@shumkov

Problem

dashmate group core reindex (packages/dashmate/src/commands/group/core/reindex.js) has two problems.

  1. It skips the DKG-safe stop check. To skip the per-node confirmation prompt, it sets ctx.isForce = true before running each node's reindexNodeTask. The stop task reads the same flag, so the masternodes are stopped without checking whether they are in a DKG session. Stopping a member mid-session risks a PoSe penalty.
  2. Its per-node tasks have no titles. It runs new Listr(configGroup.map((config) => ({ task: () => reindexNodeTask(config) }))). listr2's default renderer leaves out a subtree whose tasks all lack a title, so when a node fails, the output shows neither which node nor why. feat(dashmate): show what a DKG-safe stop waits for and how long #5843 adds titles to the same pattern in restart, group stop and group restart.

Possible fixes

  • Skip the prompt with a dedicated context flag instead of isForce, so the DKG check still runs. Offer --force to skip it explicitly.
  • Title each node's task, e.g. Reindex ${config.getName()} node.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions