You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
dashmate core reindex leaves reindex=1 in dash.conf when its restart fails #5855
"Start Core in reindex mode" renders core/dash.conf with reindex: true, writes it, and then runs restartNodeTask when the node is running.
"Wait for Core start" writes the regular dash.conf again, without reindex=1, once Core is up.
If the restart fails, step 2 never runs. One cause is the stop task refusing because the masternode is in a DKG session. Dashmate re-renders service configs only when a config changed or was migrated (BaseCommand, config.isChanged()), so the file keeps reindex=1. The next time Core starts, for whatever reason, it reindexes the whole chain. On mainnet that means hours of downtime.
Found while reviewing the DKG-safe stop work (#5841 / #5843). It has been confirmed by reading the code, not reproduced.
Possible fixes
Run the stop's DKG check before writing reindex=1, so a refusal changes nothing.
And/or restore the regular dash.conf when the restart in step 1 fails (try/finally).
Activity