Skip to content

build: shrink the vendoring [patch.crates-io] on the next rust-dashcore bump #5648

Closed

Description

@PastaPastaPasta

#5473 adds a root [patch.crates-io] so cargo vendor --locked works on the workspace again. Dash Core's depends build (dashpay/dash#7623) needs that to bundle dash-sdk-cxx offline. Most of the patch exists only because of the rust-dashcore pin, so the next rust-dashcore bump should remove most of it.

Why it's there

cargo vendor fails when the lockfile has one crate name and version from two sources. At rust-dashcore aca02026 there are four such crates: base58ck, bitcoin_hashes, bitcoin-internals and bitcoin-units. They come from crates.io, and also from rust-bitcoin rev 7ba35c7c through bitcoin-crypto. #5473 points all four at the git rev.

dpp used to pin its own dash-pkc at base-sdk 33fcc59e, so dash-num, dash-pkc and dash-types came from two revisions, which no [patch] can fix. #5473 removes that pin: dpp now uses dashcore_crypto::dash_pkc, so it always gets the base-sdk revision rust-dashcore pins.

What to do on the next bump

On any rust-dashcore bump that includes dashpay/rust-dashcore#1224 (e7f6a135, now in dev):

  • Bump dashcore-crypto with the other rust-dashcore lines; dpp's dash-pkc follows it. dpp calls dash_pkc::bls directly, so check its BLS calls against the new base-sdk revision's renames (89828032 at dev today).
  • Drop the base58ck, bitcoin_hashes and bitcoin-units patch lines. Keep bitcoin-internals.
  • Check with cargo vendor --locked "$(mktemp -d)".

Tested at rust-dashcore 335d3f57 (dev head, 2026-10-28): with dpp aligned, bitcoin-internals is the only line still needed.

Dropping the patch entirely

The last duplicate is bitcoin-internals 0.7.0. It comes from crates.io bitcoin_hashes 0.14 → bitcoin-io → bitcoin-consensus-encoding, and from the git rev through bitcoin-crypto. Capping versions in rust-dashcore could steer around it, but that's fragile. It goes away properly when rust-dashcore takes all of these crates from a single source, for example once rust-bitcoin publishes a bitcoin-crypto that uses secp256k1 0.33.

Activity

  1. added 13 commits that reference this issue on Nov 3, 2026
    11d8387
    28b99a5
    9176fc6
    fda1e70
    444bb7e
    7377b8e
    70aa0a1
    d0345d5
    a103d30
    105aae2
    dbc10ad
    ec20519
    416e1ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions