Skip to content

Drive: read evonode platform ports only from addresses and drop the deprecated flat fields at the next protocol version #5254

Open

Description

@shumkov

Platform reads evonode platform ports from Core's nested addresses, falling back to the deprecated flat platformP2PPort / platformHTTPPort (printed only with -deprecatedrpc=service). The fallback has to stay until the next protocol version, because validator sets must match older Drive binaries, which read only the flat fields.

To remove it, at the next protocol version:

  • Drive resolves evonode platform ports only from addresses, gated by the new protocol version. This needs Core with fix!: report legacy evonode Platform addresses when listdiff changes its address dash#7779 (Core then reports a legacy evonode's platform ports in addresses when its address changes). History is already checked: no affected evonode reached a validator set on mainnet (core ≤ 2548305) or testnet (core ≤ 1564503).
  • rust-dashcore rpc-json: remove legacy_platform_{p2p,http}_port and derive DMNState.service from addresses.core_p2p. Without -deprecatedrpc=service, Core omits service, so an added masternode currently fails to parse with missing field service.
  • Drive: remove the flat-field fallback and the #[allow(deprecated)] reads.
  • dashmate: drop deprecatedrpc=service once legacy JS (js-dapi-client / dashcore-lib, which read service / platformHTTPPort from rs-dapi's masternode list stream) is retired.

Refs: #5227, #5228, dashpay/rust-dashcore#1093, dashpay/dash#7779

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions