Skip to content

platform-wallet: let DashPay document writes set user_fee_increase #5095

Open

Description

@QuantumExplorer

Hosts cannot set state-transition options (for example user_fee_increase) on DashPay document writes.

  • PutDocumentParams (packages/rs-platform-wallet/src/wallet/identity/network/sdk_writer.rs, around line 135) has no settings field, and the put call passes None for every optional argument, including PutSettings (around lines 269-277).
  • The public entry points take no settings either: profile create/update (network/profile.rs) and set_contact_info_with_external_signer (network/contact_info.rs).

So when fees rise or a node rejects a transition for its fee, a DashPay write cannot be retried with a higher fee increase, unlike other document writes through rs-sdk.

To do: thread an optional PutSettings (or just user_fee_increase) from the public DashPay write methods through PutDocumentParams to the put call, and expose it over FFI/JNI where the hosts need it.

Recorded only as an open question in the committed docs/DASHPAY_MIGRATION_PLAN.md, removed in #5060.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions